New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 847101 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 845065



Sign in to add a comment

Update chrome/test/data/extensions/api_test/file_browser/OWNERS

Project Member Reported by noel@chromium.org, May 28 2018

Issue description

This directory [1] contains the tests of the File Manager Private API surface. 

[1] chrome/test/data/extensions/api_test/file_browser/*

The tests cover the API surface.  New tests should be added here, no matter how small or large the associated change to the File Manager Private API.

OWNERS file of this directory needs updating, by the looks.

@sashab, maybe hang this bug off your issue to update OWNERS everywhere?
 

Comment 1 by sashab@chromium.org, May 28 2018

Blocking: 845065
Labels: CrOSFilesCategory-CodeHealth
Status: Assigned (was: Untriaged)
Will do! Thanks for filing this Noel.

Comment 2 by noel@chromium.org, May 28 2018

A code search for the string "file_manager/OWNERS" [1] turns up another place: filed  issue 847105  about that.
Project Member

Comment 4 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/917551fd17c5870aa73379a912e51023470fc2a4

commit 917551fd17c5870aa73379a912e51023470fc2a4
Author: Sasha Morrissey <sashab@chromium.org>
Date: Wed May 30 03:59:05 2018

Update chrome/test/data/extensions/api_test/file_browser/OWNERS

Update chrome/test/data/extensions/api_test/file_browser/OWNERS to match
ui/file_manager/OWNERS, since this contains the testing for the API
layer of the file manager.

Bug:  847101 
Change-Id: I584ee34011187922452660d53dc739777e9556a6
Reviewed-on: https://chromium-review.googlesource.com/1075838
Reviewed-by: Daichi Hirono <hirono@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562726}
[modify] https://crrev.com/917551fd17c5870aa73379a912e51023470fc2a4/chrome/test/data/extensions/api_test/file_browser/OWNERS

Comment 5 by sashab@chromium.org, May 30 2018

Status: Fixed (was: Assigned)

Sign in to add a comment