New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 847098 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Data race in media::pulse::ChannelLayoutToPAChannelMap

Project Member Reported by ClusterFuzz, May 28 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5742025199321088

Fuzzer: phoglund_webrtc_peerconnection
Job Type: linux_tsan_chrome_mp
Platform Id: linux

Crash Type: Data race WRITE 4
Crash Address: 0x7f8d248bd6ec
Crash State:
  media::pulse::ChannelLayoutToPAChannelMap
  media::pulse::CreateOutputStream
  media::PulseAudioOutputStream::Open
  
Sanitizer: thread (TSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_tsan_chrome_mp&range=561853:561855

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5742025199321088

Additional requirements: Requires Gestures

Additional requirements: Requires HTTP

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 28 2018

Components: Blink>Media>Audio
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, May 28 2018

Labels: Test-Predator-Auto-Owner
Owner: guidou@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/f84fffabdef28f8577bf4b8c5f5ec73e73991927 (Improve support for audio-device group IDs on Linux.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.

Comment 3 by guidou@chromium.org, May 28 2018

Cc: maxmorin@chromium.org

Comment 4 by guidou@chromium.org, May 28 2018

Cc: dalecur...@chromium.org olka@chromium.org guidou@chromium.org
 Issue 847058  has been merged into this issue.

Comment 5 by guidou@chromium.org, May 28 2018

 Issue 846783  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, May 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3032d726d13da0c1da0917f363de2a4e7f1b73e7

commit 3032d726d13da0c1da0917f363de2a4e7f1b73e7
Author: Guido Urdaneta <guidou@chromium.org>
Date: Mon May 28 15:36:03 2018

Grab PulseAudio lock in media::pulse::GetRealDefaultDeviceId

This function waits for a PulseAudio signal without holding the lock,
which results in a race.

Drive-by: minor variable rename for consistency with other similar functions.

Bug:  847098 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ifec3f64e55f94ce8aafa89c32b1a542943ec5771
Reviewed-on: https://chromium-review.googlesource.com/1075087
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562266}
[modify] https://crrev.com/3032d726d13da0c1da0917f363de2a4e7f1b73e7/media/audio/pulse/pulse_util.cc

Project Member

Comment 7 by ClusterFuzz, May 29 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5909055269502976 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Comment 8 by guidou@chromium.org, May 29 2018

Cc: brajkumar@chromium.org
 Issue 847282  has been merged into this issue.
Project Member

Comment 9 by ClusterFuzz, May 29 2018

ClusterFuzz has detected this issue as fixed in range 562265:562266.

Detailed report: https://clusterfuzz.com/testcase?key=5742025199321088

Fuzzer: phoglund_webrtc_peerconnection
Job Type: linux_tsan_chrome_mp
Platform Id: linux

Crash Type: Data race WRITE 4
Crash Address: 0x7f8d248bd6ec
Crash State:
  media::pulse::ChannelLayoutToPAChannelMap
  media::pulse::CreateOutputStream
  media::PulseAudioOutputStream::Open
  
Sanitizer: thread (TSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_tsan_chrome_mp&range=561853:561855
Fixed: https://clusterfuzz.com/revisions?job=linux_tsan_chrome_mp&range=562265:562266

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5742025199321088

Additional requirements: Requires Gestures

Additional requirements: Requires HTTP

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Sign in to add a comment