New issue
Advanced search Search tips

Issue 847097 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 17
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

virtual/.../display-none-terminates-animation.html in webkit_layout_tests failing on chromium.webkit/WebKit Mac10.12 (retina)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, May 28 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of tapted@google.com

virtual/.../display-none-terminates-animation.html in webkit_layout_tests failing on chromium.webkit/WebKit Mac10.12 (retina)

Builders failed on: 
- WebKit Mac10.12 (retina): 
  https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.12%20%28retina%29

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fthreaded%2Fanimations%2Fdisplay-none-terminates-animation.html&testType=webkit_layout_tests

flakiness dashboard points to  https://crbug.com/726075  "Replace OSMesa by SwiftShader for Layout Tests"

 

Comment 1 by tapted@chromium.org, May 28 2018

Components: Blink>Animation
Labels: -Sheriff-Chromium OS-Mac Type-Bug
Owner: sugoi@chromium.org
Status: Assigned (was: Available)
sample run in https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.12%20%28retina%29/1234 is just "Roll Fuchsia SDK from 6db428ab1839 to dc0476630293"

failure is a... timeout or a crash? it's weird - https://test-results.appspot.com/data/layout_results/WebKit_Mac10_12__retina_/1234/layout-test-results/results.html

DevTools listening on ws://127.0.0.1:51422/devtools/browser/454d1a6b-ce9b-4275-92b4-ec36e550e0b0
Received signal #CRASHED - gpu

TestExpectations already has 

third_party/WebKit/LayoutTests/TestExpectations: crbug.com/726075  [ Mac ] virtual/threaded/animations/display-none-terminates-animation.html [ Pass Failure Crash ]

so I guess that also needs Timeout :/

disable CL -> https://chromium-review.googlesource.com/#/c/chromium/src/+/1074569 

removing sheriff label
Project Member

Comment 2 by bugdroid1@chromium.org, May 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f948e6abc1ceac383b3a98a9dd1539513501541

commit 5f948e6abc1ceac383b3a98a9dd1539513501541
Author: Trent Apted <tapted@chromium.org>
Date: Mon May 28 05:38:12 2018

Mark virtual/threaded/animations/display-none-terminates-animation.html as Timeout also

TBR=sugoi@chromium.org

Bug:  847097 ,  726075 
Change-Id: I16207dbed3df395155697992d6a5990969833f28
Reviewed-on: https://chromium-review.googlesource.com/1074569
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562186}
[modify] https://crrev.com/5f948e6abc1ceac383b3a98a9dd1539513501541/third_party/WebKit/LayoutTests/TestExpectations

Labels: Test-Layout
Status: Fixed (was: Assigned)
This was re-enabled in http://crrev.com/f73246ba7034539dbda70502ec21b53b06cd68b3

Sign in to add a comment