New issue
Advanced search Search tips

Issue 847089 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in cc::PaintOp::AreSkMatricesEqual

Project Member Reported by ClusterFuzz, May 27 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5111527758364672

Fuzzer: libFuzzer_paint_op_buffer_eq_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  cc::PaintOp::AreSkMatricesEqual
  cc::CompareMatrices
  cc::PaintShader::operator==
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=559165:559191

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5111527758364672

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 27 2018

Components: Internals>Compositing
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, May 27 2018

Cc: enne@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, May 27 2018

Labels: Test-Predator-Auto-Owner
Owner: khushals...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/67c8c7456c0c691da8802a0361486ac5e2187fbc (cc: Fix a bunch of scaling issues with oop raster.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 4 by sheriffbot@chromium.org, May 28 2018

Labels: M-68
Project Member

Comment 5 by sheriffbot@chromium.org, May 28 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, May 28 2018

Labels: Pri-1
Project Member

Comment 7 by sheriffbot@chromium.org, May 30 2018

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ceacc10a9202c5ef15fdbd6aa5d77e07519fa688

commit ceacc10a9202c5ef15fdbd6aa5d77e07519fa688
Author: Khushal <khushalsagar@chromium.org>
Date: Fri Jun 01 17:53:53 2018

cc: Fix matrix comparison in PaintShader.

If the matrix doesn't decompose, the return value is not initialized and
shouldn't be compared.

R=enne@chromium.org

Bug:  847089 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia1b53a0c0167e16c6d6897bc776282c6d27d8a4e
Reviewed-on: https://chromium-review.googlesource.com/1081932
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563710}
[modify] https://crrev.com/ceacc10a9202c5ef15fdbd6aa5d77e07519fa688/cc/paint/paint_shader.cc

Project Member

Comment 9 by ClusterFuzz, Jun 3 2018

ClusterFuzz has detected this issue as fixed in range 563707:563714.

Detailed report: https://clusterfuzz.com/testcase?key=5111527758364672

Fuzzer: libFuzzer_paint_op_buffer_eq_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  cc::PaintOp::AreSkMatricesEqual
  cc::CompareMatrices
  cc::PaintShader::operator==
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=559165:559191
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=563707:563714

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5111527758364672

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Jun 3 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5111527758364672 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by ClusterFuzz, Jun 3 2018

ClusterFuzz has detected this issue as fixed in range 563707:563714.

Detailed report: https://clusterfuzz.com/testcase?key=5111527758364672

Fuzzer: libFuzzer_paint_op_buffer_eq_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  cc::PaintOp::AreSkMatricesEqual
  cc::CompareMatrices
  cc::PaintShader::operator==
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=559165:559191
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=563707:563714

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5111527758364672

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by sheriffbot@chromium.org, Jun 3 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: Merge-Approved-68
Labels: -Merge-Approved-68 Merge-Request-68
Labels: -Merge-Request-68 Merge-Approved-68
Approving merge for 68. branch:3440
Project Member

Comment 16 by sheriffbot@chromium.org, Jun 11 2018

Cc: awhalley@chromium.org abdulsyed@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 17 by sheriffbot@chromium.org, Jun 15 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-68
This doesn't need a merge. The code this affects is behind an experiment flag that will not be enabled in 68.
Labels: -ReleaseBlock-Stable -M-68 M-69
Thanks khushalsagar@
Project Member

Comment 20 by sheriffbot@chromium.org, Sep 9

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment