Issue metadata
Sign in to add a comment
|
FileSystemURLLoaderFactoryTests have incorrect threading |
||||||||||||||||||||||||
Issue descriptionThe CreateFileSystemContextForTesting() helper routines create FileSystemContexts with both the IO and "file" TaskRunners configured to use the calling thread. Since the FileSystemBackend implementations make assumptions that they will be called on the real browser IO thread, this means these tests have broken threading - they perform FileSystem operations on the test main thread while other parts of //content (e.g. FileSystemEntryURLLoader::StartOnIOThread) perform operations on the browser IO thread.
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66633f783f166bb44990bbb427a88fe1696246a5 commit 66633f783f166bb44990bbb427a88fe1696246a5 Author: Wez <wez@chromium.org> Date: Wed May 30 22:12:42 2018 Remove unnecessary WeakPtrFactory from test. Bug: 847032 Change-Id: I09cb5743bcd6b7493329f6a578522362e1da32db Reviewed-on: https://chromium-review.googlesource.com/1074505 Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#563014} [modify] https://crrev.com/66633f783f166bb44990bbb427a88fe1696246a5/content/browser/fileapi/file_system_url_loader_factory_browsertest.cc
,
Aug 9
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by w...@chromium.org
, May 26 2018