New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 847012 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in blink::LayoutBlockFlow::RemoveChild

Project Member Reported by ClusterFuzz, May 26 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5921668984471552

Fuzzer: marty_html_twiddler
Job Type: windows_asan_content_shell
Platform Id: windows

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x12b00203c900
Crash State:
  blink::LayoutBlockFlow::RemoveChild
  blink::LayoutObject::WillBeDestroyed
  blink::LayoutBoxModelObject::WillBeDestroyed
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_content_shell&range=558997:558998

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5921668984471552

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, May 26 2018

Labels: Pri-1
Project Member

Comment 2 by ClusterFuzz, May 26 2018

Labels: M-68 Fuzz-Blocker ReleaseBlock-Beta
This crash occurs very frequently on mac and windows platforms and is likely preventing the fuzzer marty_html_twiddler from making much progress. Fixing this will allow more bugs to be found.

Marking this bug as a blocker for next Beta release.

If this is incorrect, please add ClusterFuzz-Wrong label and remove the ReleaseBlock-Beta label.
Project Member

Comment 3 by ClusterFuzz, May 26 2018

Components: Blink>Layout
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 4 by ClusterFuzz, May 26 2018

Labels: Test-Predator-Auto-Owner
Owner: tkent@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/cd3ebc4c69d7c01770f37f34aad623aa4ab2b128 (content_shell: add --run-web-tests to replace --run-layout-test.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.

Comment 5 by tkent@chromium.org, May 27 2018

Labels: Test-Predator-Wrong-CLs
Owner: e...@chromium.org
Status: Untriaged (was: Assigned)
Assign eae@ for triage.

Project Member

Comment 6 by ClusterFuzz, May 28 2018

ClusterFuzz has detected this issue as fixed in range 562173:562175.

Detailed report: https://clusterfuzz.com/testcase?key=5921668984471552

Fuzzer: marty_html_twiddler
Job Type: windows_asan_content_shell
Platform Id: windows

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x12b00203c900
Crash State:
  blink::LayoutBlockFlow::RemoveChild
  blink::LayoutObject::WillBeDestroyed
  blink::LayoutBoxModelObject::WillBeDestroyed
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_content_shell&range=558997:558998
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_content_shell&range=562173:562175

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5921668984471552

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, May 28 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Untriaged)
ClusterFuzz testcase 5921668984471552 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 8 by sheriffbot@chromium.org, May 28 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: Merge-Approved-68
Looks like this was fixed by: https://chromium.googlesource.com/chromium/src.git/+/2ff81cbf1dab9e224f3252be810c820c480e4922

Requesting merge of that (from  issue 846449 ) to 68
Labels: -Merge-Approved-68 Merge-Request-68
Not sure which CL needs to be merged here. 
Project Member

Comment 12 by sheriffbot@chromium.org, Jun 7 2018

Labels: -Merge-Request-68 Hotlist-Merge-Approved Merge-Approved-68
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by sheriffbot@chromium.org, Jun 11 2018

Cc: awhalley@chromium.org awhalley@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -ReleaseBlock-Beta
Thanks hayato@!
Project Member

Comment 16 by sheriffbot@chromium.org, Jun 15 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: abdulsyed@chromium.org
Pls merge you change to M68 branch 3440 ASAP so we can pick it up for this week Beta release. Merge has to happen latest by 1:00 PM PT tomorrow, Tuesday (06/19), so we can pick it up for Wednesday Beta release.




Ping - has this been merged to 68?
Labels: -Merge-Approved-68
Per #14, no merge required. Removing merge-approved label. 
Project Member

Comment 20 by sheriffbot@chromium.org, Sep 3

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment