[MD-WebUI] "Neu starten" in language DE doesn't fit into the Restart Button at chrome://settings/help |
|||||||||
Issue descriptionChrome Version: 69.0.3441.0 Canary OS: macOS 10.12.x & 10.13.x (but probably OS=ALL) What steps will reproduce the problem? (1) go to chrome://settings/help (2) wait until the update-download process is finished and the Restart button appears (3) What is the expected result? "Neu starten" should be in one row and fit perfectly into the button. What happens instead? "Neu starten" is in two rows doesn't fit into the button. Screenshots are attached. Thanks for looking at this issue in advance, Mehmet
,
May 29 2018
,
May 29 2018
,
May 29 2018
Candidate fix at https://chromium-review.googlesource.com/c/chromium/src/+/1077073. Before/after screenshots attached.
,
May 29 2018
👍 Looks good. Thanks for fixing it in advance.
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8fa6ef8f39e123c81fe6b40df67a3ffe0441506 commit b8fa6ef8f39e123c81fe6b40df67a3ffe0441506 Author: dpapad <dpapad@chromium.org> Date: Tue May 29 21:35:25 2018 Settings MD Refresh: Disallow line wrap within buttons of the About page. Bug: 847007 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I865f56c836845d11b32aba7f4c12e43cd72a9d1a Reviewed-on: https://chromium-review.googlesource.com/1077073 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#562598} [modify] https://crrev.com/b8fa6ef8f39e123c81fe6b40df67a3ffe0441506/chrome/browser/resources/settings/about_page/about_page.html
,
May 30 2018
,
May 30 2018
Unable to verify this as all the test Mac laptops have canary upgraded to the latest version: 69.0.3445.0. Will verify and update the behavior with tomorrow canary upgrade. Thanks.!
,
May 30 2018
,
May 31 2018
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50a9307e7d0cd12a9020ca1f4d19cd5e54b9af45 commit 50a9307e7d0cd12a9020ca1f4d19cd5e54b9af45 Author: dpapad <dpapad@chromium.org> Date: Fri Jun 01 18:29:56 2018 [M68 merge] Settings MD Refresh: Disallow line wrap within buttons of the About page. TBR=dpapad@chromium.org (cherry picked from commit b8fa6ef8f39e123c81fe6b40df67a3ffe0441506) Bug: 847007 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I865f56c836845d11b32aba7f4c12e43cd72a9d1a Reviewed-on: https://chromium-review.googlesource.com/1077073 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#562598} Reviewed-on: https://chromium-review.googlesource.com/1082929 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#96} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/50a9307e7d0cd12a9020ca1f4d19cd5e54b9af45/chrome/browser/resources/settings/about_page/about_page.html |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by meh...@chromium.org
, May 26 201886.1 KB
86.1 KB View Download