New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846996 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Control enable-flloating-virtual-keyboard feature by a finch trial

Project Member Reported by yhanada@chromium.org, May 26 2018

Issue description

Now the feature is enabled only on canary and dev channel by manually flipping the flag.
It should be controlled by a finch trial.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a23fc1891ea7addc6ce3c704734bd844cc38264f

commit a23fc1891ea7addc6ce3c704734bd844cc38264f
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Tue May 29 03:27:13 2018

Set enable-floating-virtual-keyboard feature to disabled by default.

I've set up a finch field trial for this feature.
We don't have to modify this value manually anymore.

Bug:  776260 ,  846996 
Change-Id: I6d4f5428c90393cfaf509bd5ae00dedb235f18f7
Reviewed-on: https://chromium-review.googlesource.com/1074627
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562329}
[modify] https://crrev.com/a23fc1891ea7addc6ce3c704734bd844cc38264f/ui/base/ui_base_features.cc

Labels: Merge-Request-68
Project Member

Comment 3 by sheriffbot@chromium.org, May 31 2018

Labels: -Merge-Request-68 Hotlist-Merge-Approved Merge-Approved-68
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 1 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e049bd00df301d5d5e1594e667b81f4c227cafd6

commit e049bd00df301d5d5e1594e667b81f4c227cafd6
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Fri Jun 01 05:34:51 2018

Set enable-floating-virtual-keyboard feature to disabled by default.

I've set up a finch field trial for this feature.
We don't have to modify this value manually anymore.

Bug:  776260 ,  846996 
Change-Id: I6d4f5428c90393cfaf509bd5ae00dedb235f18f7
Reviewed-on: https://chromium-review.googlesource.com/1074627
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562329}(cherry picked from commit a23fc1891ea7addc6ce3c704734bd844cc38264f)
Reviewed-on: https://chromium-review.googlesource.com/1082131
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#82}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/e049bd00df301d5d5e1594e667b81f4c227cafd6/ui/base/ui_base_features.cc

Status: Fixed (was: Started)

Sign in to add a comment