New issue
Advanced search Search tips

Issue 846986 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: 2018-05-29
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Add user metrics for visiting the error console in the chrome://extensions page

Project Member Reported by rdevlin....@chromium.org, May 26 2018

Issue description

The error console in chrome://extensions is enabled beginning in M68; we should add a user action for visiting it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49c133f28cb03f233048caf31357013d7cfdfa9a

commit 49c133f28cb03f233048caf31357013d7cfdfa9a
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Sat May 26 03:30:01 2018

[Extensions WebUI] Add a user action for viewing extension errors

Bug:  846986 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I659bfa56ec2a8257402f9b80b489caa27131cf60
Reviewed-on: https://chromium-review.googlesource.com/1070467
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562111}
[modify] https://crrev.com/49c133f28cb03f233048caf31357013d7cfdfa9a/chrome/browser/resources/md_extensions/BUILD.gn
[modify] https://crrev.com/49c133f28cb03f233048caf31357013d7cfdfa9a/chrome/browser/resources/md_extensions/error_page.js
[modify] https://crrev.com/49c133f28cb03f233048caf31357013d7cfdfa9a/tools/metrics/actions/actions.xml

NextAction: 2018-05-29
We should merge this to 68; setting a reminder for Tuesday to check Canary and request a merge.
The NextAction date has arrived: 2018-05-29
Labels: Merge-Request-68
Status: Fixed (was: Started)
Requesting merge to M68.
Project Member

Comment 5 by sheriffbot@chromium.org, May 31 2018

Labels: -Merge-Request-68 Hotlist-Merge-Approved Merge-Approved-68
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 4 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 4 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7021129aacc0420a9639bd9ed1bd34f09e72859c

commit 7021129aacc0420a9639bd9ed1bd34f09e72859c
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Mon Jun 04 17:12:03 2018

[Extensions WebUI] Add a user action for viewing extension errors

TBR=rdevlin.cronin@chromium.org

(cherry picked from commit 49c133f28cb03f233048caf31357013d7cfdfa9a)

Bug:  846986 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I659bfa56ec2a8257402f9b80b489caa27131cf60
Reviewed-on: https://chromium-review.googlesource.com/1070467
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562111}
Reviewed-on: https://chromium-review.googlesource.com/1085484
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#137}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/7021129aacc0420a9639bd9ed1bd34f09e72859c/chrome/browser/resources/md_extensions/BUILD.gn
[modify] https://crrev.com/7021129aacc0420a9639bd9ed1bd34f09e72859c/chrome/browser/resources/md_extensions/error_page.js
[modify] https://crrev.com/7021129aacc0420a9639bd9ed1bd34f09e72859c/tools/metrics/actions/actions.xml

Sign in to add a comment