Polymer2 migration: Remove usage of element.getPropertyInfo |
||
Issue descriptionPer migration guide, element.getPropertyInfo() has been removed. It is currently used by the Bookmarks page at [2] @calamity: Is this something you could tackle? If not, feel free to mark it as available and unassign yourself. The migration guide does not suggest what the alternative to that API would be. I'll post some more info when I meet with the Polymer team. Having said that, is the check at [2] necessary at all? [1] https://www.polymer-project.org/2.0/docs/upgrade#removed-apis [2] https://cs.chromium.org/chromium/src/chrome/browser/resources/md_bookmarks/store_client.js?type=cs&q=getPropertyInfo+lang:js&g=0&l=52
,
May 28 2018
This is a landmine for checking that a watch is assigned to an actual declared property. It's basically like doing some runtime typechecking. It can be removed; RIP getPropertyInfo.
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d94097261b83d3fe2af86de8b22a81da603c0ea commit 9d94097261b83d3fe2af86de8b22a81da603c0ea Author: Christopher Lam <calamity@chromium.org> Date: Wed May 30 05:31:35 2018 [MD Bookmarks] Remove getPropertyInfo. This CL removes a call to getPropertyInfo which blocks Polymer 2 migration. Bug: 846980 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id9210441348f7cfb737679bf7f60e49dfd29a86f Reviewed-on: https://chromium-review.googlesource.com/1074577 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#562745} [modify] https://crrev.com/9d94097261b83d3fe2af86de8b22a81da603c0ea/chrome/browser/resources/md_bookmarks/store_client.js
,
May 30 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by dpa...@chromium.org
, May 26 2018