New Android horizontal tab switcher doesn't snap to tab properly when re-loading tabs on cold start |
|||
Issue description1. Have more than one (non-NTP tab open) 2. Kill Chrome and restart 3. Tab snapping is broken
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b5a6340325f497c5dab3bf74646327775805832 commit 2b5a6340325f497c5dab3bf74646327775805832 Author: Ryan Landay <rlanday@chromium.org> Date: Fri Jun 01 17:55:41 2018 Fix snapping in Android horizontal tab switcher when reloading from cold start We currently have a bug in the new horizontal tab switcher on Android where if tabs get reloaded after a cold start, the snap distance is not set properly, so the snapping behavior doesn't work properly. The fix is to update the snap distance in NonOverlappingStack#notifySizeChanged() in addition to contextChanged() (apparently when reloading tabs, contextChanged() is not called again after the StackLayout's size is properly set). Bug: 846961 , 831359 Change-Id: I8c1be9f38889d6d1c45adefeb51af30d6a8bb4e3 Reviewed-on: https://chromium-review.googlesource.com/1081091 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#563647}(cherry picked from commit a73bfcdab75e5ae85d3d97af584dacacd5c0431d) Reviewed-on: https://chromium-review.googlesource.com/1082852 Reviewed-by: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#94} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/2b5a6340325f497c5dab3bf74646327775805832/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/NonOverlappingStack.java
,
Jun 1 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jun 1 2018