The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca49d4cfb6140e56f16ed6b37a3169f7858c0c9d

commit ca49d4cfb6140e56f16ed6b37a3169f7858c0c9d
Author: Patrick Monette <pmonette@chromium.org>
Date: Wed May 30 05:30:08 2018

Adding a class to drain the load attempt log

Bug: 846953
Change-Id: I39f556b5e612c6fe617d53ae5ab0c6fa88059031
Reviewed-on: https://chromium-review.googlesource.com/1074247
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Penny MacNeil <pennymac@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562744}
[modify] https://crrev.com/ca49d4cfb6140e56f16ed6b37a3169f7858c0c9d/chrome/browser/BUILD.gn
[modify] https://crrev.com/ca49d4cfb6140e56f16ed6b37a3169f7858c0c9d/chrome/browser/conflicts/DEPS
[modify] https://crrev.com/ca49d4cfb6140e56f16ed6b37a3169f7858c0c9d/chrome/browser/conflicts/module_blacklist_cache_util_win.cc
[modify] https://crrev.com/ca49d4cfb6140e56f16ed6b37a3169f7858c0c9d/chrome/browser/conflicts/module_blacklist_cache_util_win.h
[modify] https://crrev.com/ca49d4cfb6140e56f16ed6b37a3169f7858c0c9d/chrome/browser/conflicts/module_blacklist_cache_util_win_unittest.cc
[add] https://crrev.com/ca49d4cfb6140e56f16ed6b37a3169f7858c0c9d/chrome/browser/conflicts/module_load_attempt_log_listener_win.cc
[add] https://crrev.com/ca49d4cfb6140e56f16ed6b37a3169f7858c0c9d/chrome/browser/conflicts/module_load_attempt_log_listener_win.h
[add] https://crrev.com/ca49d4cfb6140e56f16ed6b37a3169f7858c0c9d/chrome/browser/conflicts/module_load_attempt_log_listener_win_unittest.cc
[modify] https://crrev.com/ca49d4cfb6140e56f16ed6b37a3169f7858c0c9d/chrome/test/BUILD.gn
[modify] https://crrev.com/ca49d4cfb6140e56f16ed6b37a3169f7858c0c9d/chrome_elf/BUILD.gn
[modify] https://crrev.com/ca49d4cfb6140e56f16ed6b37a3169f7858c0c9d/chrome_elf/chrome_elf_test_stubs.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a080883be19513f221aee57e0b85ecd0d21d634

commit 8a080883be19513f221aee57e0b85ecd0d21d634
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Wed May 30 06:02:06 2018

Revert "Adding a class to drain the load attempt log"

This reverts commit ca49d4cfb6140e56f16ed6b37a3169f7858c0c9d.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 562744 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2NhNDlkNGNmYjYxNDBlNTZmMTZlZDZiMzdhMzE2OWY3ODU4YzBjOWQM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Win/31079

Sample Failed Step: compile

Original change's description:
> Adding a class to drain the load attempt log
> 
> Bug: 846953
> Change-Id: I39f556b5e612c6fe617d53ae5ab0c6fa88059031
> Reviewed-on: https://chromium-review.googlesource.com/1074247
> Commit-Queue: Patrick Monette <pmonette@chromium.org>
> Reviewed-by: Penny MacNeil <pennymac@chromium.org>
> Reviewed-by: Greg Thompson <grt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#562744}

Change-Id: Ief94febfc7e3bc136f20acd41b567adbdef49c19
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 846953
Reviewed-on: https://chromium-review.googlesource.com/1078147
Cr-Commit-Position: refs/heads/master@{#562746}
[modify] https://crrev.com/8a080883be19513f221aee57e0b85ecd0d21d634/chrome/browser/BUILD.gn
[modify] https://crrev.com/8a080883be19513f221aee57e0b85ecd0d21d634/chrome/browser/conflicts/DEPS
[modify] https://crrev.com/8a080883be19513f221aee57e0b85ecd0d21d634/chrome/browser/conflicts/module_blacklist_cache_util_win.cc
[modify] https://crrev.com/8a080883be19513f221aee57e0b85ecd0d21d634/chrome/browser/conflicts/module_blacklist_cache_util_win.h
[modify] https://crrev.com/8a080883be19513f221aee57e0b85ecd0d21d634/chrome/browser/conflicts/module_blacklist_cache_util_win_unittest.cc
[delete] https://crrev.com/9d94097261b83d3fe2af86de8b22a81da603c0ea/chrome/browser/conflicts/module_load_attempt_log_listener_win.cc
[delete] https://crrev.com/9d94097261b83d3fe2af86de8b22a81da603c0ea/chrome/browser/conflicts/module_load_attempt_log_listener_win.h
[delete] https://crrev.com/9d94097261b83d3fe2af86de8b22a81da603c0ea/chrome/browser/conflicts/module_load_attempt_log_listener_win_unittest.cc
[modify] https://crrev.com/8a080883be19513f221aee57e0b85ecd0d21d634/chrome/test/BUILD.gn
[modify] https://crrev.com/8a080883be19513f221aee57e0b85ecd0d21d634/chrome_elf/BUILD.gn
[modify] https://crrev.com/8a080883be19513f221aee57e0b85ecd0d21d634/chrome_elf/chrome_elf_test_stubs.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e67eff3054984d6284ffcc6612aa0ef9296bbc26

commit e67eff3054984d6284ffcc6612aa0ef9296bbc26
Author: Patrick Monette <pmonette@chromium.org>
Date: Thu May 31 17:26:46 2018

Reland "Adding a class to drain the load attempt log"

This is a reland of ca49d4cfb6140e56f16ed6b37a3169f7858c0c9d,
and it only contains the missing includes needed to fix the
compilation error.

Original change's description:
> Adding a class to drain the load attempt log
>
> Bug: 846953
> Change-Id: I39f556b5e612c6fe617d53ae5ab0c6fa88059031
> Reviewed-on: https://chromium-review.googlesource.com/1074247
> Commit-Queue: Patrick Monette <pmonette@chromium.org>
> Reviewed-by: Penny MacNeil <pennymac@chromium.org>
> Reviewed-by: Greg Thompson <grt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#562744}

Bug: 846953
Change-Id: I28bf6fca0aa419b288e8ec7f9e396af7ff5c1b46
Reviewed-on: https://chromium-review.googlesource.com/1080287
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Penny MacNeil <pennymac@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563296}
[modify] https://crrev.com/e67eff3054984d6284ffcc6612aa0ef9296bbc26/chrome/browser/BUILD.gn
[modify] https://crrev.com/e67eff3054984d6284ffcc6612aa0ef9296bbc26/chrome/browser/conflicts/DEPS
[modify] https://crrev.com/e67eff3054984d6284ffcc6612aa0ef9296bbc26/chrome/browser/conflicts/module_blacklist_cache_util_win.cc
[modify] https://crrev.com/e67eff3054984d6284ffcc6612aa0ef9296bbc26/chrome/browser/conflicts/module_blacklist_cache_util_win.h
[modify] https://crrev.com/e67eff3054984d6284ffcc6612aa0ef9296bbc26/chrome/browser/conflicts/module_blacklist_cache_util_win_unittest.cc
[add] https://crrev.com/e67eff3054984d6284ffcc6612aa0ef9296bbc26/chrome/browser/conflicts/module_load_attempt_log_listener_win.cc
[add] https://crrev.com/e67eff3054984d6284ffcc6612aa0ef9296bbc26/chrome/browser/conflicts/module_load_attempt_log_listener_win.h
[add] https://crrev.com/e67eff3054984d6284ffcc6612aa0ef9296bbc26/chrome/browser/conflicts/module_load_attempt_log_listener_win_unittest.cc
[modify] https://crrev.com/e67eff3054984d6284ffcc6612aa0ef9296bbc26/chrome/test/BUILD.gn
[modify] https://crrev.com/e67eff3054984d6284ffcc6612aa0ef9296bbc26/chrome_elf/BUILD.gn
[modify] https://crrev.com/e67eff3054984d6284ffcc6612aa0ef9296bbc26/chrome_elf/chrome_elf_test_stubs.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9951262c957a4dba57fa24dbf34d06ef11d31e9

commit e9951262c957a4dba57fa24dbf34d06ef11d31e9
Author: Patrick Monette <pmonette@chromium.org>
Date: Thu May 31 23:20:04 2018

Expose possible failures for ReadModuleBlacklistCache()

Bug: 846953
Change-Id: If1b0b8b7253453b7dc71fb490a49c6e6a03eeb25
Reviewed-on: https://chromium-review.googlesource.com/1075721
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563425}
[modify] https://crrev.com/e9951262c957a4dba57fa24dbf34d06ef11d31e9/chrome/browser/conflicts/module_blacklist_cache_util_win.cc
[modify] https://crrev.com/e9951262c957a4dba57fa24dbf34d06ef11d31e9/chrome/browser/conflicts/module_blacklist_cache_util_win.h
[modify] https://crrev.com/e9951262c957a4dba57fa24dbf34d06ef11d31e9/chrome/browser/conflicts/module_blacklist_cache_util_win_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e31f63e2e4f36cd14354165f098e33f114067841

commit e31f63e2e4f36cd14354165f098e33f114067841
Author: Patrick Monette <pmonette@chromium.org>
Date: Wed Jun 06 00:10:34 2018

Introduce ModuleBlacklistCacheUpdater

This class is responsible to keep the module blacklist cache
updated when the ThirdPartyModulesBlocking feature is enabled.

Bug: 846953
Change-Id: Ib8a99ac0352702daec6b79d15324c2e7787d4d1a
Reviewed-on: https://chromium-review.googlesource.com/1055893
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564721}
[modify] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/chrome/browser/BUILD.gn
[modify] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/chrome/browser/chrome_browser_main_win.cc
[add] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/chrome/browser/conflicts/module_blacklist_cache_updater_win.cc
[add] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/chrome/browser/conflicts/module_blacklist_cache_updater_win.h
[add] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/chrome/browser/conflicts/module_blacklist_cache_updater_win_unittest.cc
[modify] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/chrome/browser/conflicts/module_database_win.cc
[modify] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/chrome/browser/conflicts/module_database_win.h
[modify] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/chrome/browser/conflicts/module_info_util_win.cc
[modify] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/chrome/browser/conflicts/module_info_util_win.h
[modify] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/chrome/browser/conflicts/module_info_win.cc
[modify] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/chrome/browser/conflicts/module_info_win.h
[modify] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/chrome/browser/conflicts/module_info_win_unittest.cc
[modify] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/chrome/browser/conflicts/module_list_filter_win.cc
[add] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/chrome/browser/conflicts/third_party_blocking_browsertest.cc
[modify] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/chrome/browser/conflicts/third_party_conflicts_manager_win.cc
[modify] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/chrome/browser/conflicts/third_party_conflicts_manager_win.h
[modify] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/chrome/browser/conflicts/third_party_metrics_recorder_win.cc
[modify] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/chrome/browser/prefs/chrome_pref_service_factory.cc
[modify] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/chrome/common/chrome_features.cc
[modify] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/chrome/common/chrome_features.h
[modify] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/chrome/common/pref_names.cc
[modify] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/chrome/common/pref_names.h
[modify] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/chrome/test/BUILD.gn
[modify] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/e31f63e2e4f36cd14354165f098e33f114067841/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ea1f46791d6b47fffb9174e448306e6a9927b6d

commit 2ea1f46791d6b47fffb9174e448306e6a9927b6d
Author: Patrick Monette <pmonette@chromium.org>
Date: Fri Jul 06 22:09:13 2018

Add a BlacklistStatus histogram

This counts the number of blocked modules during the execution of
Chrome and the number of newly blacklisted modules.

Bug: 846953
Change-Id: Ic41ebd85055a999784c26afae75587e65b3e627b
Reviewed-on: https://chromium-review.googlesource.com/1127343
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573087}
[modify] https://crrev.com/2ea1f46791d6b47fffb9174e448306e6a9927b6d/chrome/browser/conflicts/module_blacklist_cache_updater_win.cc
[modify] https://crrev.com/2ea1f46791d6b47fffb9174e448306e6a9927b6d/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/2ea1f46791d6b47fffb9174e448306e6a9927b6d/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24f87d0a0079f97ab14e0ad0255f3985728242c2

commit 24f87d0a0079f97ab14e0ad0255f3985728242c2
Author: Patrick Monette <pmonette@chromium.org>
Date: Tue Jul 10 01:52:20 2018

Write the path of the blacklist cache in the registry

Enables chrome_elf to find the blacklist without figuring out the path
to the User Data directory by itself.

This is a follow up of
https://chromium-review.googlesource.com/c/chromium/src/+/1117498.

Bug: 846953
Change-Id: Ib868925da8b845d38ec120d585a5cf33e1e107f1
Reviewed-on: https://chromium-review.googlesource.com/1120639
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Penny MacNeil <pennymac@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573594}
[modify] https://crrev.com/24f87d0a0079f97ab14e0ad0255f3985728242c2/chrome/browser/component_updater/third_party_module_list_component_installer_win.cc
[modify] https://crrev.com/24f87d0a0079f97ab14e0ad0255f3985728242c2/chrome/browser/conflicts/module_blacklist_cache_updater_win.cc
[modify] https://crrev.com/24f87d0a0079f97ab14e0ad0255f3985728242c2/chrome/browser/conflicts/module_blacklist_cache_updater_win.h
[modify] https://crrev.com/24f87d0a0079f97ab14e0ad0255f3985728242c2/chrome/browser/conflicts/module_blacklist_cache_updater_win_unittest.cc
[modify] https://crrev.com/24f87d0a0079f97ab14e0ad0255f3985728242c2/chrome/browser/conflicts/module_blacklist_cache_util_win.cc
[modify] https://crrev.com/24f87d0a0079f97ab14e0ad0255f3985728242c2/chrome/browser/conflicts/module_blacklist_cache_util_win.h
[modify] https://crrev.com/24f87d0a0079f97ab14e0ad0255f3985728242c2/chrome/browser/conflicts/third_party_blocking_browsertest.cc
[modify] https://crrev.com/24f87d0a0079f97ab14e0ad0255f3985728242c2/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb8a757d7ad4d5281451ba491494bcb65a244b80

commit bb8a757d7ad4d5281451ba491494bcb65a244b80
Author: Patrick Monette <pmonette@chromium.org>
Date: Tue Jul 10 18:57:06 2018

Don't warn about modules that are added to the blacklist cache.

Bug: 846953
Change-Id: I33e710005af02f9e6a553cfc0ef18acd3eaa2d8f
Reviewed-on: https://chromium-review.googlesource.com/1128371
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573838}
[modify] https://crrev.com/bb8a757d7ad4d5281451ba491494bcb65a244b80/chrome/browser/conflicts/incompatible_applications_updater_win.cc
[modify] https://crrev.com/bb8a757d7ad4d5281451ba491494bcb65a244b80/chrome/browser/conflicts/incompatible_applications_updater_win_unittest.cc
[modify] https://crrev.com/bb8a757d7ad4d5281451ba491494bcb65a244b80/chrome/browser/conflicts/module_blacklist_cache_updater_win.cc
[modify] https://crrev.com/bb8a757d7ad4d5281451ba491494bcb65a244b80/chrome/browser/conflicts/module_blacklist_cache_updater_win_unittest.cc
[modify] https://crrev.com/bb8a757d7ad4d5281451ba491494bcb65a244b80/chrome/browser/conflicts/module_database_win.cc
[modify] https://crrev.com/bb8a757d7ad4d5281451ba491494bcb65a244b80/chrome/browser/conflicts/module_database_win.h
[modify] https://crrev.com/bb8a757d7ad4d5281451ba491494bcb65a244b80/chrome/browser/conflicts/module_info_win.cc
[modify] https://crrev.com/bb8a757d7ad4d5281451ba491494bcb65a244b80/chrome/browser/conflicts/module_info_win.h
[modify] https://crrev.com/bb8a757d7ad4d5281451ba491494bcb65a244b80/chrome/browser/conflicts/third_party_conflicts_manager_win.cc
[modify] https://crrev.com/bb8a757d7ad4d5281451ba491494bcb65a244b80/chrome/browser/conflicts/third_party_conflicts_manager_win.h
[modify] https://crrev.com/bb8a757d7ad4d5281451ba491494bcb65a244b80/chrome/browser/conflicts/third_party_metrics_recorder_win.cc
[modify] https://crrev.com/bb8a757d7ad4d5281451ba491494bcb65a244b80/chrome/browser/ui/webui/conflicts_handler.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0582b161a84a9168d78f3725cfbaa3e6a009961b

commit 0582b161a84a9168d78f3725cfbaa3e6a009961b
Author: Patrick Monette <pmonette@chromium.org>
Date: Thu Jul 12 21:29:09 2018

Add OnKnownModuleLoaded to ModuleDatabaseObserver

This will be used by the IncompatibleApplicationsUpdater and
ModuleBlacklistCacheUpdater instances to re-analyze a module when it
loads into the process.

Bug: 846953
Change-Id: I327fce954cc281dd312732823ef168a4086ea787
Reviewed-on: https://chromium-review.googlesource.com/1135634
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574728}
[modify] https://crrev.com/0582b161a84a9168d78f3725cfbaa3e6a009961b/chrome/browser/conflicts/module_database_observer_win.h
[modify] https://crrev.com/0582b161a84a9168d78f3725cfbaa3e6a009961b/chrome/browser/conflicts/module_database_win.cc
[modify] https://crrev.com/0582b161a84a9168d78f3725cfbaa3e6a009961b/chrome/browser/conflicts/module_database_win.h
[modify] https://crrev.com/0582b161a84a9168d78f3725cfbaa3e6a009961b/chrome/browser/conflicts/module_database_win_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab13ebac17508dfe27ccbd6d362bbe4075e6ec18

commit ab13ebac17508dfe27ccbd6d362bbe4075e6ec18
Author: Patrick Monette <pmonette@chromium.org>
Date: Fri Jul 13 15:22:40 2018

Save the warning and blocking decision of each module.

This will be used in an upcoming update to the chrome://conflicts page
to show why a particular module was blocked or caused an incompatibility
warning to be shown.

Bug: 846953
Change-Id: I6e6eab9f4f9805b5fb67a00eb9f5521c006f11ff
Reviewed-on: https://chromium-review.googlesource.com/1135658
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574923}
[modify] https://crrev.com/ab13ebac17508dfe27ccbd6d362bbe4075e6ec18/chrome/browser/conflicts/incompatible_applications_updater_win.cc
[modify] https://crrev.com/ab13ebac17508dfe27ccbd6d362bbe4075e6ec18/chrome/browser/conflicts/incompatible_applications_updater_win.h
[modify] https://crrev.com/ab13ebac17508dfe27ccbd6d362bbe4075e6ec18/chrome/browser/conflicts/incompatible_applications_updater_win_unittest.cc
[modify] https://crrev.com/ab13ebac17508dfe27ccbd6d362bbe4075e6ec18/chrome/browser/conflicts/module_blacklist_cache_updater_win.cc
[modify] https://crrev.com/ab13ebac17508dfe27ccbd6d362bbe4075e6ec18/chrome/browser/conflicts/module_blacklist_cache_updater_win.h
[modify] https://crrev.com/ab13ebac17508dfe27ccbd6d362bbe4075e6ec18/chrome/browser/conflicts/module_blacklist_cache_updater_win_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/215847e9409dbd67da7583948a388b76e904f8ab

commit 215847e9409dbd67da7583948a388b76e904f8ab
Author: Patrick Monette <pmonette@chromium.org>
Date: Fri Jul 13 15:50:18 2018

Augment the ThirdPartyConflictsManager state to include features status

Bug: 846953
Change-Id: I6ee9d0d9557fa981726316994661ac0aad3c9631
Reviewed-on: https://chromium-review.googlesource.com/1135696
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574928}
[modify] https://crrev.com/215847e9409dbd67da7583948a388b76e904f8ab/chrome/browser/conflicts/third_party_conflicts_manager_win.cc
[modify] https://crrev.com/215847e9409dbd67da7583948a388b76e904f8ab/chrome/browser/conflicts/third_party_conflicts_manager_win.h
[modify] https://crrev.com/215847e9409dbd67da7583948a388b76e904f8ab/chrome/browser/conflicts/third_party_conflicts_manager_win_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb609e97fd1f812c8803f8339a35ddfd4973a490

commit bb609e97fd1f812c8803f8339a35ddfd4973a490
Author: Patrick Monette <pmonette@chromium.org>
Date: Wed Jul 18 21:22:29 2018

Add a comment to the ThirdPartyModulesBlocking feature flag

The comment explains that 2 browser starts are required to fully enable
or disable the feature.

Bug: 846953
Change-Id: I44037ab9d1c8b3a1c3f2692916ad945fedfa2b2e
Reviewed-on: https://chromium-review.googlesource.com/1142345
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576214}
[modify] https://crrev.com/bb609e97fd1f812c8803f8339a35ddfd4973a490/chrome/common/chrome_features.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6abfcb7fd59c1ef32e895181f2fcf0e2ef263c7

commit e6abfcb7fd59c1ef32e895181f2fcf0e2ef263c7
Author: Patrick Monette <pmonette@chromium.org>
Date: Thu Jul 19 19:53:06 2018

Fix the whitelisting of modules in the blacklist cache when updating it

Bug: 846953
Change-Id: Ib8df36ef1366eed19bc157cd6b63ee009881aee5
Reviewed-on: https://chromium-review.googlesource.com/1143899
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576593}
[modify] https://crrev.com/e6abfcb7fd59c1ef32e895181f2fcf0e2ef263c7/chrome/browser/conflicts/module_blacklist_cache_util_win.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c28098f7c19d521925e780372a2abb9d33c88c9

commit 5c28098f7c19d521925e780372a2abb9d33c88c9
Author: Patrick Monette <pmonette@chromium.org>
Date: Fri Jul 20 18:15:28 2018

Always drain blocked modules log

Since it is possible for a module to be blocked even though the feature
is disabled, the class that drains the log of blocked modules is now
part of the ModuleDatabase and always initialized.

Also, the ModuleDatabase is now aware of blocked modules and they are
shown in the chrome://conflicts page.

Bug: 846953
Change-Id: I993a51571e4d4f630ab6852b54920598bad26ac3
Reviewed-on: https://chromium-review.googlesource.com/1141158
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576925}
[modify] https://crrev.com/5c28098f7c19d521925e780372a2abb9d33c88c9/chrome/browser/conflicts/module_blacklist_cache_updater_win.cc
[modify] https://crrev.com/5c28098f7c19d521925e780372a2abb9d33c88c9/chrome/browser/conflicts/module_blacklist_cache_updater_win.h
[modify] https://crrev.com/5c28098f7c19d521925e780372a2abb9d33c88c9/chrome/browser/conflicts/module_blacklist_cache_updater_win_unittest.cc
[modify] https://crrev.com/5c28098f7c19d521925e780372a2abb9d33c88c9/chrome/browser/conflicts/module_database_win.cc
[modify] https://crrev.com/5c28098f7c19d521925e780372a2abb9d33c88c9/chrome/browser/conflicts/module_database_win.h
[modify] https://crrev.com/5c28098f7c19d521925e780372a2abb9d33c88c9/chrome/browser/conflicts/module_info_win.h
[modify] https://crrev.com/5c28098f7c19d521925e780372a2abb9d33c88c9/chrome/browser/conflicts/module_load_attempt_log_listener_win.cc
[modify] https://crrev.com/5c28098f7c19d521925e780372a2abb9d33c88c9/chrome/browser/conflicts/module_load_attempt_log_listener_win.h
[modify] https://crrev.com/5c28098f7c19d521925e780372a2abb9d33c88c9/chrome/browser/conflicts/module_load_attempt_log_listener_win_unittest.cc
[modify] https://crrev.com/5c28098f7c19d521925e780372a2abb9d33c88c9/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/5c28098f7c19d521925e780372a2abb9d33c88c9/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[add] https://crrev.com/5c28098f7c19d521925e780372a2abb9d33c88c9/chrome/browser/ui/webui/conflicts/OWNERS
[rename] https://crrev.com/5c28098f7c19d521925e780372a2abb9d33c88c9/chrome/browser/ui/webui/conflicts/conflicts_handler.cc
[rename] https://crrev.com/5c28098f7c19d521925e780372a2abb9d33c88c9/chrome/browser/ui/webui/conflicts/conflicts_handler.h
[rename] https://crrev.com/5c28098f7c19d521925e780372a2abb9d33c88c9/chrome/browser/ui/webui/conflicts/conflicts_ui.cc
[rename] https://crrev.com/5c28098f7c19d521925e780372a2abb9d33c88c9/chrome/browser/ui/webui/conflicts/conflicts_ui.h
[modify] https://crrev.com/5c28098f7c19d521925e780372a2abb9d33c88c9/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/5c28098f7c19d521925e780372a2abb9d33c88c9/tools/metrics/histograms/histograms.xml

Requesting merge to m69 for #14, CL named "Always drain blocked modules log"

This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

How safe is the change listed at #15 to merge to M69 and why it is needed?

It is safe because it is behind a finch flag that we can turn off.

This change is needed to make sure the ThirdPartyModulesBlocking feature is working as expected, which is a feature we're enabling in m69

Approving merge to M69 branch 3497 based on comment #18. Please merge ASAP. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ac3fc6205cfae02f95604a15b6f1e1fcd74d8f5

commit 5ac3fc6205cfae02f95604a15b6f1e1fcd74d8f5
Author: Patrick Monette <pmonette@chromium.org>
Date: Tue Jul 24 18:20:48 2018

Always drain blocked modules log

Since it is possible for a module to be blocked even though the feature
is disabled, the class that drains the log of blocked modules is now
part of the ModuleDatabase and always initialized.

Also, the ModuleDatabase is now aware of blocked modules and they are
shown in the chrome://conflicts page.

Bug: 846953
Change-Id: I993a51571e4d4f630ab6852b54920598bad26ac3
Reviewed-on: https://chromium-review.googlesource.com/1141158
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#576925}(cherry picked from commit 5c28098f7c19d521925e780372a2abb9d33c88c9)
Reviewed-on: https://chromium-review.googlesource.com/1148504
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#46}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/5ac3fc6205cfae02f95604a15b6f1e1fcd74d8f5/chrome/browser/conflicts/module_blacklist_cache_updater_win.cc
[modify] https://crrev.com/5ac3fc6205cfae02f95604a15b6f1e1fcd74d8f5/chrome/browser/conflicts/module_blacklist_cache_updater_win.h
[modify] https://crrev.com/5ac3fc6205cfae02f95604a15b6f1e1fcd74d8f5/chrome/browser/conflicts/module_blacklist_cache_updater_win_unittest.cc
[modify] https://crrev.com/5ac3fc6205cfae02f95604a15b6f1e1fcd74d8f5/chrome/browser/conflicts/module_database_win.cc
[modify] https://crrev.com/5ac3fc6205cfae02f95604a15b6f1e1fcd74d8f5/chrome/browser/conflicts/module_database_win.h
[modify] https://crrev.com/5ac3fc6205cfae02f95604a15b6f1e1fcd74d8f5/chrome/browser/conflicts/module_info_win.h
[modify] https://crrev.com/5ac3fc6205cfae02f95604a15b6f1e1fcd74d8f5/chrome/browser/conflicts/module_load_attempt_log_listener_win.cc
[modify] https://crrev.com/5ac3fc6205cfae02f95604a15b6f1e1fcd74d8f5/chrome/browser/conflicts/module_load_attempt_log_listener_win.h
[modify] https://crrev.com/5ac3fc6205cfae02f95604a15b6f1e1fcd74d8f5/chrome/browser/conflicts/module_load_attempt_log_listener_win_unittest.cc
[modify] https://crrev.com/5ac3fc6205cfae02f95604a15b6f1e1fcd74d8f5/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/5ac3fc6205cfae02f95604a15b6f1e1fcd74d8f5/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[add] https://crrev.com/5ac3fc6205cfae02f95604a15b6f1e1fcd74d8f5/chrome/browser/ui/webui/conflicts/OWNERS
[rename] https://crrev.com/5ac3fc6205cfae02f95604a15b6f1e1fcd74d8f5/chrome/browser/ui/webui/conflicts/conflicts_handler.cc
[rename] https://crrev.com/5ac3fc6205cfae02f95604a15b6f1e1fcd74d8f5/chrome/browser/ui/webui/conflicts/conflicts_handler.h
[rename] https://crrev.com/5ac3fc6205cfae02f95604a15b6f1e1fcd74d8f5/chrome/browser/ui/webui/conflicts/conflicts_ui.cc
[rename] https://crrev.com/5ac3fc6205cfae02f95604a15b6f1e1fcd74d8f5/chrome/browser/ui/webui/conflicts/conflicts_ui.h
[modify] https://crrev.com/5ac3fc6205cfae02f95604a15b6f1e1fcd74d8f5/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/5ac3fc6205cfae02f95604a15b6f1e1fcd74d8f5/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10d16dc9765d6ffe16f6015af8b067f947c96d3b

commit 10d16dc9765d6ffe16f6015af8b067f947c96d3b
Author: Patrick Monette <pmonette@chromium.org>
Date: Fri Jul 27 18:48:25 2018

Put the basename of unsigned modules into crash keys

The crash keys are named "unsigned-modules-*" where * is a number from
0 to 9.

This will allow us to assess which accessibility software doesn't sign
all of their modules.

Bug: 846953
Change-Id: Iea0aabc1694972120c7ef48327c0b982092ed179
Reviewed-on: https://chromium-review.googlesource.com/1148990
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578727}
[modify] https://crrev.com/10d16dc9765d6ffe16f6015af8b067f947c96d3b/chrome/browser/conflicts/third_party_metrics_recorder_win.cc
[modify] https://crrev.com/10d16dc9765d6ffe16f6015af8b067f947c96d3b/chrome/browser/conflicts/third_party_metrics_recorder_win.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3a501dbe44708533971a697aced9fcde5cf448b

commit b3a501dbe44708533971a697aced9fcde5cf448b
Author: Chris Hamilton <chrisha@chromium.org>
Date: Tue Aug 07 18:15:20 2018

Add unsigned module count to ThirdParty modules UMA metrics.

BUG=846953

Change-Id: Ic354c61147f14f080341aba36220cb81324df81e
Reviewed-on: https://chromium-review.googlesource.com/1165302
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581285}
[modify] https://crrev.com/b3a501dbe44708533971a697aced9fcde5cf448b/chrome/browser/conflicts/third_party_metrics_recorder_win.cc
[modify] https://crrev.com/b3a501dbe44708533971a697aced9fcde5cf448b/chrome/browser/conflicts/third_party_metrics_recorder_win.h
[modify] https://crrev.com/b3a501dbe44708533971a697aced9fcde5cf448b/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89224288032c838f884b442e155f2d904ff65428

commit 89224288032c838f884b442e155f2d904ff65428
Author: Patrick Monette <pmonette@chromium.org>
Date: Tue Aug 07 23:43:57 2018

Track modules that bypass the blocking in chrome_elf

Also render them valid to trigger an incompatible applications warning.

Bug: 846953
Change-Id: I6fa9951043d19a44a820aeaf44cab1c0e9b981e2
Reviewed-on: https://chromium-review.googlesource.com/1158986
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581393}
[modify] https://crrev.com/89224288032c838f884b442e155f2d904ff65428/chrome/browser/conflicts/module_blacklist_cache_updater_win.cc
[modify] https://crrev.com/89224288032c838f884b442e155f2d904ff65428/chrome/browser/conflicts/module_blacklist_cache_updater_win.h
[modify] https://crrev.com/89224288032c838f884b442e155f2d904ff65428/chrome/browser/conflicts/module_blacklist_cache_updater_win_unittest.cc
[modify] https://crrev.com/89224288032c838f884b442e155f2d904ff65428/chrome/browser/conflicts/third_party_conflicts_manager_win.cc
[modify] https://crrev.com/89224288032c838f884b442e155f2d904ff65428/chrome/browser/conflicts/third_party_conflicts_manager_win.h
[modify] https://crrev.com/89224288032c838f884b442e155f2d904ff65428/chrome/browser/ui/webui/conflicts/conflicts_handler.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb47ccc0ca7ea6021e704dce5501d0c0dc17d3be

commit bb47ccc0ca7ea6021e704dce5501d0c0dc17d3be
Author: Patrick Monette <pmonette@chromium.org>
Date: Thu Aug 30 19:39:31 2018

Adding fieldtrial testing config for ThirdPartyModulesBlocking

Bug: 846953
Change-Id: Id9e80e045a598ae59617ebdd5b4d08a2eba961bf
Reviewed-on: https://chromium-review.googlesource.com/1153448
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587713}
[modify] https://crrev.com/bb47ccc0ca7ea6021e704dce5501d0c0dc17d3be/testing/variations/fieldtrial_testing_config.json