New issue
Advanced search Search tips

Issue 846940 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----



Sign in to add a comment

AppList app context menus should align right

Project Member Reported by newcomer@chromium.org, May 25 2018

Issue description

For applist only
Now they are left aligned by default. They should right align instead.
 
Labels: Pri-1
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7a810a2705cfb5af38d365c1f17eb4c0a580a3c

commit b7a810a2705cfb5af38d365c1f17eb4c0a580a3c
Author: Alex Newcomer <newcomer@chromium.org>
Date: Fri Jun 22 23:27:03 2018

cros: Add a right alightment option for touchable menus

Add a right alignment option for touchable menus.

Bug:  846940 
Change-Id: I5a41d915fa76eff9d99ebb5d2b57a68c79d53082
Reviewed-on: https://chromium-review.googlesource.com/1103381
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569835}
[modify] https://crrev.com/b7a810a2705cfb5af38d365c1f17eb4c0a580a3c/ui/views/controls/menu/menu_controller.cc
[modify] https://crrev.com/b7a810a2705cfb5af38d365c1f17eb4c0a580a3c/ui/views/controls/menu/menu_item_view.cc
[modify] https://crrev.com/b7a810a2705cfb5af38d365c1f17eb4c0a580a3c/ui/views/controls/menu/menu_scroll_view_container.cc
[modify] https://crrev.com/b7a810a2705cfb5af38d365c1f17eb4c0a580a3c/ui/views/controls/menu/menu_types.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1c89a2256764a188345b60cd31d536043d7e778

commit e1c89a2256764a188345b60cd31d536043d7e778
Author: Alex Newcomer <newcomer@chromium.org>
Date: Tue Jun 26 00:00:42 2018

cros: Make AppList Menus right align

Change the alignment for app menus to right aligned instead of left
aligned.

Bug:  846940 
Change-Id: I34d8736d93117aa39306b5beb4c2e48b11f4122e
Reviewed-on: https://chromium-review.googlesource.com/1103383
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570247}
[modify] https://crrev.com/e1c89a2256764a188345b60cd31d536043d7e778/ash/app_list/views/app_list_item_view.cc
[modify] https://crrev.com/e1c89a2256764a188345b60cd31d536043d7e778/ash/app_list/views/search_result_tile_item_view.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment