All app icon context menus should anchor on the app icon, not the click point |
||||
Issue descriptionAll icon context menus should anchor as if they are touch.
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c9cfa06ac506c8eb0ebd33fb48e190574f16748 commit 9c9cfa06ac506c8eb0ebd33fb48e190574f16748 Author: Alex Newcomer <newcomer@chromium.org> Date: Thu May 31 17:29:12 2018 cros: Anchor touch and mouse menus similarly. Per UX request, anchor all application/context menus the same (based on the app icon). Previous behavior was to anchor mouse menus based on the click point, the new behavior anchors the menu based on the app icon regardless of whether the event summoning the menus is touch or click. Bug: 846939 Change-Id: I7c8993c5fc0281bf4cc4bd906af13f2fb10ad2eb Reviewed-on: https://chromium-review.googlesource.com/1077195 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#563298} [modify] https://crrev.com/9c9cfa06ac506c8eb0ebd33fb48e190574f16748/ash/shelf/shelf_view.cc [modify] https://crrev.com/9c9cfa06ac506c8eb0ebd33fb48e190574f16748/ash/shelf/shelf_view.h [modify] https://crrev.com/9c9cfa06ac506c8eb0ebd33fb48e190574f16748/ash/shelf/shelf_view_test_api.cc [modify] https://crrev.com/9c9cfa06ac506c8eb0ebd33fb48e190574f16748/ash/shelf/shelf_view_test_api.h [modify] https://crrev.com/9c9cfa06ac506c8eb0ebd33fb48e190574f16748/ash/shelf/shelf_view_unittest.cc
,
May 31 2018
,
May 31 2018
Issue 844053 has been merged into this issue.
,
May 31 2018
Shelf is done, launcher side is waiting on review https://chromium-review.googlesource.com/c/chromium/src/+/1077308
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e373bd340adbb3451da4108ac0b68e95e54ee9b commit 6e373bd340adbb3451da4108ac0b68e95e54ee9b Author: Alex Newcomer <newcomer@chromium.org> Date: Wed Jun 06 17:21:28 2018 cros: anchor touch and mouse menus the same As per request from ux, anchor touch and mouse menus similarly. Previously touch menus were anchored based on the app icon, and mouse menus were anchored on the click point. Now we will anchor all menus on the app icon. Bug: 846939 Change-Id: I6d2aea28096701c0109081059be40dca5a9ce93c Reviewed-on: https://chromium-review.googlesource.com/1077308 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#564940} [modify] https://crrev.com/6e373bd340adbb3451da4108ac0b68e95e54ee9b/ui/app_list/views/app_list_item_view.cc [modify] https://crrev.com/6e373bd340adbb3451da4108ac0b68e95e54ee9b/ui/app_list/views/search_result_tile_item_view.cc
,
Jun 6 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by newcomer@chromium.org
, May 29 2018