New issue
Advanced search Search tips

Issue 846925 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[WPT import] Importer fails because it can't fetch the rotation calendar

Project Member Reported by robertma@chromium.org, May 25 2018

Issue description

https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.infra.cron%2Fwpt-importer%2F18571%2F%2B%2Frecipes%2Fsteps%2FImport_changes_from_WPT_to_Chromium%2F0%2Fstdout


Traceback (most recent call last):
  File "/b/rr/tmpM8aEDu/w/src/third_party/blink/tools/wpt_import.py", line 27, in <module>
    main()
  File "/b/rr/tmpM8aEDu/w/src/third_party/blink/tools/wpt_import.py", line 20, in main
    host.exit(importer.main())
  File "/b/rr/tmpM8aEDu/w/src/third_party/blink/tools/blinkpy/w3c/test_importer.py", line 169, in main
    self._upload_cl()
  File "/b/rr/tmpM8aEDu/w/src/third_party/blink/tools/blinkpy/w3c/test_importer.py", line 451, in _upload_cl
    sheriff_email = self.tbr_reviewer()
  File "/b/rr/tmpM8aEDu/w/src/third_party/blink/tools/blinkpy/w3c/test_importer.py", line 525, in tbr_reviewer
    username = self._fetch_ecosystem_infra_sheriff_username()
  File "/b/rr/tmpM8aEDu/w/src/third_party/blink/tools/blinkpy/w3c/test_importer.py", line 531, in _fetch_ecosystem_infra_sheriff_username
    content = self.host.web.get_binary(ROTATIONS_URL)
  File "/b/rr/tmpM8aEDu/w/src/third_party/blink/tools/blinkpy/common/net/web.py", line 37, in get_binary
    return NetworkTransaction(return_none_on_404=return_none_on_404).run(lambda: urllib2.urlopen(url).read())
  File "/b/rr/tmpM8aEDu/w/src/third_party/blink/tools/blinkpy/common/net/network_transaction.py", line 61, in run
    self._check_for_timeout()
  File "/b/rr/tmpM8aEDu/w/src/third_party/blink/tools/blinkpy/common/net/network_transaction.py", line 68, in _check_for_timeout
    raise NetworkTimeout()
blinkpy.common.net.network_transaction.NetworkTimeout: NetworkTimeout


The immediate fix is to catch this exception and carry on. We also need to find out why the rotation calendar disappeared.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6226c51778dd90113b1a3d3815c343d15994391

commit e6226c51778dd90113b1a3d3815c343d15994391
Author: Robert Ma <robertma@chromium.org>
Date: Sat May 26 02:44:15 2018

[WPT importer] Catch NetworkError when fetching rotation calendar

Also change the fallback to me.

Bug:  846925 
Change-Id: Ia9e0389e91d70532d8ae05369b7635495b0b0d25
Reviewed-on: https://chromium-review.googlesource.com/1074168
Commit-Queue: Robert Ma <robertma@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562104}
[modify] https://crrev.com/e6226c51778dd90113b1a3d3815c343d15994391/third_party/blink/tools/blinkpy/w3c/test_importer.py
[modify] https://crrev.com/e6226c51778dd90113b1a3d3815c343d15994391/third_party/blink/tools/blinkpy/w3c/test_importer_unittest.py

Status: Fixed (was: Started)
The fix above addressed the immediate issue.

The rotation calendar also has come back online. It was probably a transient problem.

Sign in to add a comment