webkit_layout_tests (experimental) failing on chromium.win/Win7 Tests (dbg)(1) |
|||||||||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of sandersd@chromium.org webkit_layout_tests (experimental) failing on chromium.win/Win7 Tests (dbg)(1) Builders failed on: - Win7 Tests (dbg)(1): https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29
,
May 25 2018
The actual cause was https://chromium-review.googlesource.com/c/chromium/src/+/1070504, which enabled the failing tests. Given that this failure isn't actually blocking anything I'm just going to make the test more robust to floating point rounding issues.
,
May 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/172ad9caabf6c3c39b8a2715f6d925353d00f0b7 commit 172ad9caabf6c3c39b8a2715f6d925353d00f0b7 Author: Robbie McElrath <rmcelrath@chromium.org> Date: Sat May 26 00:01:19 2018 Fix devtools deviceorientation layout test This fails due to a floating point rounding error, so I'm only checking the first 6 digits to get around it. Bug: 846920 Change-Id: I7faaaee9aeedec8c0cceb1089830f5fa3c206d50 Reviewed-on: https://chromium-review.googlesource.com/1074170 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#562071} [modify] https://crrev.com/172ad9caabf6c3c39b8a2715f6d925353d00f0b7/third_party/WebKit/LayoutTests/http/tests/devtools/device-orientation-success-expected.txt [modify] https://crrev.com/172ad9caabf6c3c39b8a2715f6d925353d00f0b7/third_party/WebKit/LayoutTests/http/tests/devtools/device-orientation-success.js
,
May 26 2018
,
May 28 2018
device-orientation-success.js is still failing, but flakily latest run: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20%28dbg%29/13013 https://test-results.appspot.com/data/layout_results/WebKit_Linux_Trusty__dbg_/13013/layout-test-results/results.html --- /b/s/w/io8rZhTh/layout-test-results/http/tests/devtools/device-orientation-success-expected.txt +++ /b/s/w/io8rZhTh/layout-test-results/http/tests/devtools/device-orientation-success-actual.txt @@ -15,5 +15,5 @@ inspected-page.html:1 A reload is required so that the existing AbsoluteOrientationSensor and RelativeOrientationSensor objects on this page use the overridden values that have been provided. Close the inspector and reload again to return to the normal behavior. device-orientation-success.js:22 alpha: 90 beta: 0 gamma: 0 device-orientation-success.js:29 quaternion: 0.000000,0.000000,0.707107,0.707107 -device-orientation-success.js:22 alpha: 1.1 beta: 2.2 gamma: 3.3 +device-orientation-success.js:22 alpha: null beta: null gamma: null
,
May 28 2018
disable cl -> https://chromium-review.googlesource.com/c/chromium/src/+/1074791
,
May 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/095fe4f2eb66f97cb3a4029b3a7cf7aa7d492a44 commit 095fe4f2eb66f97cb3a4029b3a7cf7aa7d492a44 Author: Trent Apted <tapted@chromium.org> Date: Mon May 28 01:34:28 2018 Mark http/tests/devtools/device-orientation-success.js flaky TBR=rmcelrath@chromium.org Bug: 846920 Change-Id: Ia99888c418c10dcc2d67976bdae56632e5e31209 Reviewed-on: https://chromium-review.googlesource.com/1074791 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#562158} [modify] https://crrev.com/095fe4f2eb66f97cb3a4029b3a7cf7aa7d492a44/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/383ea4e718310f7d214061c8081202cc2f2937c2 commit 383ea4e718310f7d214061c8081202cc2f2937c2 Author: Robbie McElrath <rmcelrath@chromium.org> Date: Thu Jun 07 17:50:33 2018 Re-enable device-orientation-success.js layout test I've made several sensor changes since this test was disabled that should fix the flakiness. Bug: 846920 Change-Id: Ibe38cad96acd7d5636f89d0eb8a6d915ab6798a0 Reviewed-on: https://chromium-review.googlesource.com/1089712 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#565335} [modify] https://crrev.com/383ea4e718310f7d214061c8081202cc2f2937c2/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/383ea4e718310f7d214061c8081202cc2f2937c2/third_party/WebKit/LayoutTests/http/tests/devtools/device-orientation-success-expected.txt
,
Jun 7 2018
I'll watch the test for a couple days, and mark this as fixed if there are no further issues.
,
Jun 8 2018
It's now failing pretty often (one out of four runs fails, without any patches). https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng Please take a look ASAP.
,
Jun 8 2018
Correction: I was misreading the results. About half the runs fail. It looks like different failures each time. Here are the four most recent failed builds as of the time of this post: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/69598 Unexpected Failures: * virtual/threaded/http/tests/devtools/tracing/console-timeline.js https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/69597 Unexpected Failures: * http/tests/devtools/tracing/timeline-time/timeline-usertiming.js https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/69594 Unexpected Failures: * http/tests/devtools/tracing/timeline-style/timeline-style-recalc-all-invalidator-types.js * virtual/threaded/http/tests/devtools/tracing/timeline-style/timeline-style-recalc-with-invalidator-invalidations.js https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/69592 Unexpected Failures: * virtual/threaded/http/tests/devtools/tracing/anonymous-image-object.js * virtual/threaded/http/tests/devtools/tracing/timeline-style/timeline-style-recalc-all-invalidator-types.js
,
Jun 8 2018
Just noticed those tests were marked as flaky a few hours ago in bug 850892 , so some of those at least will no longer cause test failure complaints. virtual/threaded/http/tests/devtools/tracing/timeline-style/timeline-style-recalc-with-invalidator-invalidations.js and virtual/threaded/http/tests/devtools/tracing/anonymous-image-object.js were not marked as flaky in that bug.
,
Jun 8 2018
I'm reassigning to mpearson since this is a different issue now, and I couldn't quickly figure out who caused the current flakiness.
,
Jun 8 2018
Punting back to sheriff queue
,
Jun 8 2018
Removing from sheriff queue; things seem sane now.
,
Jun 11 2018
,
Jun 11 2018
It seems that all tests mentioned in #12 and before have been addressed except for: 1) virtual/threaded/http/tests/devtools/tracing/timeline-style/timeline-style-recalc-with-invalidator-invalidations.js Still has timeouts on Windows bots. 2) virtual/threaded/http/tests/devtools/tracing/anonymous-image-object.js Based on the flakiness dashboard, this no longer seems flaky. alph@, could you please take a look at the (1) test?
,
Jul 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34cfe3d9636865cca808b512982e58b8942519dc commit 34cfe3d9636865cca808b512982e58b8942519dc Author: Alexei Filippov <alph@chromium.org> Date: Wed Jul 04 01:34:28 2018 DevTools: Fix race in TracingHandler::OnBufferUsage The OnBufferUsage is called through double async chain and by that time the tracing can already be stopped. Do not report usage in this case. The bug caused several tests to flake, e.g. http/tests/devtools/tracing/timeline-style/timeline-style-recalc-all-invalidator-types.js BUG= 846920 Change-Id: I94259e38e49e35f21974faf9aef69f96d118c36b Reviewed-on: https://chromium-review.googlesource.com/1125213 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#572436} [modify] https://crrev.com/34cfe3d9636865cca808b512982e58b8942519dc/content/browser/devtools/protocol/tracing_handler.cc
,
Jul 6
,
Jul 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d662169bf9c7f34df828294c9e0f65d56d3072b commit 9d662169bf9c7f34df828294c9e0f65d56d3072b Author: Alexei Filippov <alph@chromium.org> Date: Fri Jul 06 18:18:05 2018 Unmark several DevTools layout tests as flaky The issue has been fixed. NOTRY=true TBR=vasilii@chromium.org BUG= 859629 , 846920 Change-Id: I92edb313f646d9469f92e5230229ba6aa7139f20 Reviewed-on: https://chromium-review.googlesource.com/1128168 Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#573016} [modify] https://crrev.com/9d662169bf9c7f34df828294c9e0f65d56d3072b/third_party/WebKit/LayoutTests/TestExpectations
,
Jul 6
,
Jul 6
Issue 857225 has been merged into this issue.
,
Jul 6
Issue 860101 has been merged into this issue.
,
Jul 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95a1fb174c2701e8a24dd71943599e559b10d701 commit 95a1fb174c2701e8a24dd71943599e559b10d701 Author: Alexei Filippov <alph@chromium.org> Date: Fri Jul 06 22:40:52 2018 Unmark http/tests/devtools/tracing/worker-events.js as flaky NOTRY=true TBR=shimazu@chromium.org BUG= 860101 , 846920 Change-Id: Ied88e402a63631cb6c67225f79ca990e3b8a3628 Reviewed-on: https://chromium-review.googlesource.com/1128370 Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#573097} [modify] https://crrev.com/95a1fb174c2701e8a24dd71943599e559b10d701/third_party/WebKit/LayoutTests/TestExpectations |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by sande...@chromium.org
, May 25 2018Status: Assigned (was: Available)