New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846915 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 832309



Sign in to add a comment

Create a tool for migrating hosts between AFE DB and Skylab

Project Member Reported by nxia@chromium.org, May 25 2018

Issue description

The tool should support:

1) migrating hosts from AFE DB to Skylab
2) rolling back hosts to AFE DB in case migration doesn't work.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c46bdd159b3b2b1fb18c86160b8da237bc4eebea

commit c46bdd159b3b2b1fb18c86160b8da237bc4eebea
Author: Ningning Xia <nxia@google.com>
Date: Thu May 31 19:26:21 2018

Add "atest host rename".

In order to support rollback hosts in case hosts don't work afer
migration, add the "atest host rename" command.
"--for-migration" should be called after we migrate hosts from
staging/prod to skylab.
"--for-rollback" should be called after we rollback hosts in
skylab.

BUG= chromium:846915 
TEST="atest host rename"

Change-Id: Icf341557443b341254c5e7f4eab27252e5a9271f
Reviewed-on: https://chromium-review.googlesource.com/1077375
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/c46bdd159b3b2b1fb18c86160b8da237bc4eebea/cli/host.py
[modify] https://crrev.com/c46bdd159b3b2b1fb18c86160b8da237bc4eebea/cli/atest_unittest.py

Comment 2 by nxia@chromium.org, Jun 1 2018

Blocking: 832309
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/skylab_inventory/+/7a2ef46dbe05a92159ff3b40c41d66f64ba73d3e

commit 7a2ef46dbe05a92159ff3b40c41d66f64ba73d3e
Author: Ningning Xia <nxia@google.com>
Date: Fri Jun 01 21:45:41 2018

Add move_devices for migrating hosts between skylab_inventory and AFE DB.

BUG= chromium:846915 
TEST="atest host migrate"

Change-Id: Ib5dbd8f77f8823ffa98ce62f9b104959ac02b33a
Reviewed-on: https://chromium-review.googlesource.com/1081177
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/7a2ef46dbe05a92159ff3b40c41d66f64ba73d3e/venv/skylab_inventory/lib/device.py

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9df3d153391e8d29d8001cdae2cafe6d0a89a33c

commit 9df3d153391e8d29d8001cdae2cafe6d0a89a33c
Author: Ningning Xia <nxia@google.com>
Date: Tue Jun 05 00:23:24 2018

Add "atest host migrate".

"atest host migrate" support host migration or rollback by pool
and model.

BUG= chromium:846915 
TEST="atest host migrate"

Change-Id: I119f1f2b25227c67d224c1b86056e2da63583ff5
Reviewed-on: https://chromium-review.googlesource.com/1080044
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/9df3d153391e8d29d8001cdae2cafe6d0a89a33c/cli/topic_common.py
[modify] https://crrev.com/9df3d153391e8d29d8001cdae2cafe6d0a89a33c/cli/host.py
[modify] https://crrev.com/9df3d153391e8d29d8001cdae2cafe6d0a89a33c/cli/atest_unittest.py

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/skylab_inventory/+/fa1b33c8224fe667098f5b99adf6e63d03d9e877

commit fa1b33c8224fe667098f5b99adf6e63d03d9e877
Author: Ningning Xia <nxia@google.com>
Date: Thu Jun 07 01:51:47 2018

Verify hosts don't exist in destination before migration.

BUG= chromium:846915 
TEST="atest host migrate"

Change-Id: Ida9fbd2922568af53d388f77cf1d5937ec02d224
Reviewed-on: https://chromium-review.googlesource.com/1087320
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/fa1b33c8224fe667098f5b99adf6e63d03d9e877/venv/skylab_inventory/lib/device.py

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/56d6843ff25804acab2642c7af983cd88ea879a9

commit 56d6843ff25804acab2642c7af983cd88ea879a9
Author: Ningning Xia <nxia@google.com>
Date: Fri Jun 08 00:00:23 2018

Do not migrate hosts with invalid hostnames.

When a host is migrated, it'll be renamed to host-migrated-do-not-use
in AFE DB. hosts with names ending with "-migrated-do-not-use" can't
be migrated to skylab. This was noticed in CL:*636668

BUG= chromium:846915 
TEST="atest host migrate"

Change-Id: I741f83615c7f42d84b3c63c5161bccd0dbc769bc
Reviewed-on: https://chromium-review.googlesource.com/1089479
Reviewed-by: Xixuan Wu <xixuan@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Commit-Queue: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/56d6843ff25804acab2642c7af983cd88ea879a9/cli/host.py

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/423c79665592ee0cbf17c88b8efe35a0807ebedb

commit 423c79665592ee0cbf17c88b8efe35a0807ebedb
Author: Ningning Xia <nxia@google.com>
Date: Fri Jun 08 06:33:53 2018

Change commit message and add TODO.

BUG= chromium:846915 
TEST=None

Change-Id: I0f6c943a0bc087a7a6daaeb1a55bbb27b787f1fa
Reviewed-on: https://chromium-review.googlesource.com/1091916
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/423c79665592ee0cbf17c88b8efe35a0807ebedb/cli/host.py

Comment 8 by nxia@chromium.org, Jun 8 2018

Summary: Create a tool for migrating hosts between AFE DB and Skylab (was: Create a tool for migrating hosts from AFE DB to Skylab)
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 13 2018

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/skylab_inventory/+/6d412fceea5a645d99e09de83bc61afe83761b3e

commit 6d412fceea5a645d99e09de83bc61afe83761b3e
Author: Ningning Xia <nxia@google.com>
Date: Wed Jun 13 17:54:50 2018

Add API to remove dut uids from a server.

BUG= chromium:846915 
TEST="atest host migrate --rollback"

Change-Id: Ic481f21cc230316290a5cf0edeae9694f24de745
Reviewed-on: https://chromium-review.googlesource.com/1093551
Reviewed-by: Xixuan Wu <xixuan@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/6d412fceea5a645d99e09de83bc61afe83761b3e/venv/skylab_inventory/lib/server.py

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ffb3c1faaa358fd57dfd034777a1c72b7747e88b

commit ffb3c1faaa358fd57dfd034777a1c72b7747e88b
Author: Ningning Xia <nxia@google.com>
Date: Wed Jun 13 17:55:07 2018

Assign migrated duts to a random skylab drone.

BUG= chromium:846915 
TEST="atest host migrate"
CQ-DEPEND=CL:1093375

Change-Id: I39b0e3c7ee389bb07d5dde18abac17099ab49adf
Reviewed-on: https://chromium-review.googlesource.com/1092160
Reviewed-by: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/ffb3c1faaa358fd57dfd034777a1c72b7747e88b/cli/host.py

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/877817f09b138c1109f62b4e9ddd66549e18a2d8

commit 877817f09b138c1109f62b4e9ddd66549e18a2d8
Author: Ningning Xia <nxia@google.com>
Date: Wed Jun 13 17:55:25 2018

Remove dut uids from drone when rollback hosts.

BUG= chromium:846915 
TEST="atest host migrate --rollback"
CQ-DEPEND=CL:1093551

Change-Id: I5bcc6ba15afdfd16029820a7533d664f25d820d7
Reviewed-on: https://chromium-review.googlesource.com/1093296
Reviewed-by: Xixuan Wu <xixuan@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/877817f09b138c1109f62b4e9ddd66549e18a2d8/cli/host.py

Status: Fixed (was: Untriaged)
If there's follow up work, please file new bugs against me.

Sign in to add a comment