Save card infobar on Android and iOS are missing the card network label |
||||
Issue descriptionSave card infobar on Android and iOS must have a label that indicates the card network, similar to Desktop. This is an accessibility issue on mobile
,
May 25 2018
Could the image view read out the network for accessibility?
,
May 25 2018
It is possible to do that. Maybe as a future work? This is an easier fix for both platforms and is consistent with Desktop. Maybe rfeng@ has other reasons as well for wanting it there.
,
May 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7194fce22eabb9b8a847b7bd4323feb12e37e10 commit a7194fce22eabb9b8a847b7bd4323feb12e37e10 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Sun May 27 20:12:42 2018 [AF] Add the card issuer network label to save card infobar on mobile This improves accessiblity of the infobar and makes it consistent with Desktop. Bug: 846888 Change-Id: I9e696898d9b43e9b73fcdfab5c451f9164444627 Reviewed-on: https://chromium-review.googlesource.com/1073912 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#562154} [modify] https://crrev.com/a7194fce22eabb9b8a847b7bd4323feb12e37e10/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
,
May 28 2018
,
May 29 2018
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5cdc949103b5eabf711744cc3cb9b57fa7bf543 commit d5cdc949103b5eabf711744cc3cb9b57fa7bf543 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Tue May 29 19:03:09 2018 [AF] Add the card issuer network label to save card infobar on mobile This improves accessiblity of the infobar and makes it consistent with Desktop. Bug: 846888 Change-Id: I9e696898d9b43e9b73fcdfab5c451f9164444627 Reviewed-on: https://chromium-review.googlesource.com/1073912 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#562154}(cherry picked from commit a7194fce22eabb9b8a847b7bd4323feb12e37e10) Reviewed-on: https://chromium-review.googlesource.com/1077028 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#31} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/d5cdc949103b5eabf711744cc3cb9b57fa7bf543/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by mahmadi@chromium.org
, May 25 201853.8 KB
53.8 KB View Download
63.4 KB
63.4 KB View Download
143 KB
143 KB View Download