Enable built-in DNSClient with the network service |
|||||
Issue descriptionWe should hool up IOThread::dns_client_enabled_ to the network service, and move the tracking logic to SystemNetworkContextManager in the process. This will be simplest to do once https://chromium-review.googlesource.com/c/chromium/src/+/1067959 lands, as it will ensure SystemNetworkContextManager knows when the network service is restarting, and can re-pass in the status. Unlike most settings, this should be applied to the NetworkService, since it has a global HostResolver. Ideally, we'd add integrations tests for this, but not sure how practical that is, since it causes us to get settings from the system.
,
Jun 1 2018
+ericorth@ as this is tangentially related to Eric's work on unifying DNS interfaces and exposing the functionalities through network service.
,
Jun 1 2018
One thing I noticed is that the network service currently creates one HostResolver per NetworkContext when the network service is enabled (But not in tests!). I'm going to fix that so it always creates a global one when out of process. Other than that, I don't think we'll trip over each other much.
,
Jun 8 2018
,
Jun 13 2018
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b67c0a8eaa84c767041a00d5f0033e95e179e2e0 commit b67c0a8eaa84c767041a00d5f0033e95e179e2e0 Author: Matt Menke <mmenke@chromium.org> Date: Thu Jun 14 22:41:04 2018 Hook up stub host resolver when the network service is enabled. This covers both enabling it, and enabling DNS over HTTPS. DNS over HTTPS requires a global URLRequestContext. To handle that, DNS over HTTPS now also uses the "use_to_validate_certs" NetworkContext, which has been renamed the "primary" NetworkContext. Bug: 846883 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Idff65040dd67853efd6aa98fdfbeb06b6bd86778 Reviewed-on: https://chromium-review.googlesource.com/1093158 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#567448} [modify] https://crrev.com/b67c0a8eaa84c767041a00d5f0033e95e179e2e0/chrome/browser/io_thread.cc [modify] https://crrev.com/b67c0a8eaa84c767041a00d5f0033e95e179e2e0/chrome/browser/io_thread.h [modify] https://crrev.com/b67c0a8eaa84c767041a00d5f0033e95e179e2e0/chrome/browser/net/system_network_context_manager.cc [modify] https://crrev.com/b67c0a8eaa84c767041a00d5f0033e95e179e2e0/chrome/browser/net/system_network_context_manager.h [modify] https://crrev.com/b67c0a8eaa84c767041a00d5f0033e95e179e2e0/net/dns/dns_config_service.h [modify] https://crrev.com/b67c0a8eaa84c767041a00d5f0033e95e179e2e0/net/dns/host_resolver.cc [modify] https://crrev.com/b67c0a8eaa84c767041a00d5f0033e95e179e2e0/net/dns/host_resolver.h [modify] https://crrev.com/b67c0a8eaa84c767041a00d5f0033e95e179e2e0/net/dns/host_resolver_impl.cc [modify] https://crrev.com/b67c0a8eaa84c767041a00d5f0033e95e179e2e0/net/dns/host_resolver_impl.h [modify] https://crrev.com/b67c0a8eaa84c767041a00d5f0033e95e179e2e0/services/network/network_context.cc [modify] https://crrev.com/b67c0a8eaa84c767041a00d5f0033e95e179e2e0/services/network/network_context.h [modify] https://crrev.com/b67c0a8eaa84c767041a00d5f0033e95e179e2e0/services/network/network_service.cc [modify] https://crrev.com/b67c0a8eaa84c767041a00d5f0033e95e179e2e0/services/network/network_service.h [modify] https://crrev.com/b67c0a8eaa84c767041a00d5f0033e95e179e2e0/services/network/network_service_unittest.cc [modify] https://crrev.com/b67c0a8eaa84c767041a00d5f0033e95e179e2e0/services/network/public/mojom/network_context.mojom [modify] https://crrev.com/b67c0a8eaa84c767041a00d5f0033e95e179e2e0/services/network/public/mojom/network_service.mojom
,
Jun 15 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mmenke@chromium.org
, Jun 1 2018Status: Assigned (was: Untriaged)