Web Bluetooth device chooser does not display signal strength |
||
Issue descriptionChrome Version: 66.0.3359.181 OS: MacOS 10.13.3 What steps will reproduce the problem? (1) Visit https://permission.site. (2) Click the Bluetooth button. What is the expected result? Devices displayed in the chooser dialog should have a signal strength associated. What happens instead? Signal strength is not shown. The cause of this is https://chromium-review.googlesource.com/c/chromium/src/+/875162 which made the return value of BluetoothChooserController::ShouldShowIconBeforeText dependent on whether any devices had been found so far. Since the list starts out empty the views::TableView is constructed in TEXT_ONLY mode which means that the icons are never displayed.
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d40b4f19c4c01a54f49e522853a59d559ee81814 commit d40b4f19c4c01a54f49e522853a59d559ee81814 Author: Reilly Grant <reillyg@chromium.org> Date: Mon Jun 04 17:02:42 2018 Restore RSSI indicators to Web Bluetooth chooser dialog This partially reverts the changes made in commit 9e098bcbd1252eeda8747f in order to restore the RSSI indicators in the Web Bluetooth chooser dialog. The return value of ShouldShowIconBeforeText() cannot change because the views::TableView has no way of changing its layout after creation. Bug: 846879 Change-Id: I81c9e90997b1a6f9143b571d0b17395653832ac1 Reviewed-on: https://chromium-review.googlesource.com/1083219 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#564119} [modify] https://crrev.com/d40b4f19c4c01a54f49e522853a59d559ee81814/chrome/browser/chooser_controller/fake_bluetooth_chooser_controller.cc [modify] https://crrev.com/d40b4f19c4c01a54f49e522853a59d559ee81814/chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc
,
Jun 4 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by reillyg@chromium.org
, May 25 2018