New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846874 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 825063



Sign in to add a comment

Mobile entries in src-internal DEPS are unpinned on branches

Project Member Reported by mmoss@chromium.org, May 25 2018

Issue description

These were pinned in the old branch buildspecs, and should be pinned, or branched, in the new src-internal branches too. They almost certainly shouldn't be floating on HEAD. Not sure if this is because of a bug or just an oversight in the new branching recipes.
 

Comment 1 by mmoss@chromium.org, May 25 2018

Ah, I think it's because the method of determining if entries are pinned ('gclient revinfo') isn't setting "checkout_mobile_internal", so it's processing those entries.
Project Member

Comment 2 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/release/scripts/+/7c5076212f339478f6113e6ad3b74f8c2e34f437

commit 7c5076212f339478f6113e6ad3b74f8c2e34f437
Author: Michael Moss <mmoss@google.com>
Date: Tue May 29 20:19:59 2018

Project Member

Comment 3 by bugdroid1@chromium.org, May 29 2018

Labels: merge-merged-3440
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/release/scripts/+/21f64525972559b80c8cfb930c9375ef3d25a2f8

commit 21f64525972559b80c8cfb930c9375ef3d25a2f8
Author: Michael Moss <mmoss@google.com>
Date: Tue May 29 20:32:59 2018

Comment 4 by mmoss@chromium.org, May 29 2018

Status: Fixed (was: Started)
Should be fixed in the next releases.

Sign in to add a comment