Spacing and indentation in save card infobar are incorrect |
|||||
Issue descriptionAll the padding/spacing must be 16pt with the exception of the card details that must be 8pt. Card details must be indented unless GPay logo is showing.
,
May 29 2018
,
May 30 2018
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 30 2018
Verified on Chrome Canary 69.0.3445.0
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7a441f9f831bcafdc4ad173627282f9955ad1ce commit f7a441f9f831bcafdc4ad173627282f9955ad1ce Author: Moe Ahmadi <mahmadi@chromium.org> Date: Wed May 30 14:37:20 2018 [AF] Fixes the spacing and indentation in the save card infobar in iOS screenshots: https://drive.google.com/corp/drive/u/0/folders/1N8KNauAjwWkHSpVPXJjqdCu3FWT4iLjp Bug: 846856 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib4051d327b1eeeee254abe62a99b51b9a9369821 Reviewed-on: https://chromium-review.googlesource.com/1073748 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#562306}(cherry picked from commit 0d21a41a7f82614de3355d4d6a986bd3d3290fbf) Reviewed-on: https://chromium-review.googlesource.com/1079147 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#42} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/f7a441f9f831bcafdc4ad173627282f9955ad1ce/ios/chrome/browser/ui/autofill/save_card_infobar_controller.mm [modify] https://crrev.com/f7a441f9f831bcafdc4ad173627282f9955ad1ce/ios/chrome/browser/ui/autofill/save_card_infobar_view.h [modify] https://crrev.com/f7a441f9f831bcafdc4ad173627282f9955ad1ce/ios/chrome/browser/ui/autofill/save_card_infobar_view.mm |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, May 28 2018