New issue
Advanced search Search tips

Issue 846851 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

[WPT] New failures introduced in external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/shapes1 by import https://crrev.com/c/1073627

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, May 25 2018

Issue description

WPT import https://crrev.com/c/1073627 introduced new failures in external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/shapes1:

List of new failures:
external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-polygon-032.html [ Failure ]

This import contains upstream changes from 8111e49db7ed5ced2d44e974fcedaba6cd86e4a7 to 046d3c9bd3a1a560ad45e9a9fde4f32fdff9b72b:
Sync Mozilla tests as of https://hg.mozilla.org/mozilla-central/rev/fe66c9e30a203531fe312dc052882e25a34f806e . (#11168): https://github.com/w3c/web-platform-tests/commit/046d3c9bd3a1a560ad45e9a9fde4f32fdff9b72b [affecting this directory]
Add regression test for  https://crbug.com/843523 .: https://github.com/w3c/web-platform-tests/commit/f73282e06fe91bd60e188f39887332c63e80a419
Fix errors in wpt/css/css-masking/* tests: https://github.com/w3c/web-platform-tests/commit/f901588ec487b07487f52b15317afd6c4b1fe4ae [affecting this directory]

 

Comment 1 by e...@chromium.org, May 29 2018

Owner: ikilpatrick@chromium.org
Status: Assigned (was: Untriaged)
I hear you lave css shapes Ian...

Comment 2 by e...@chromium.org, May 29 2018

s/lave/love/
Cc: foolip@chromium.org
I *think* this is a bad test - mozilla are probably resolving percentages within a shape of the containing block, (i.e. the normal percentage resolution size), and we are doing it - as per the spec - https://drafts.csswg.org/css-shapes/#basic-shape-functions off the floats actual size.

Do we just mark this as WontFix?
The status of this test has changed now, after https://github.com/web-platform-tests/wpt/pull/11536.


Looking at https://wpt.fyi/results/css/vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-polygon-032.html?label=stable it seems like Chrome is the outlier though. ikilpatrick@, can you check if the other 3 engines agree on the behavior here, or if they fail in different ways? If Chrome is the outlier, then maybe we should change the spec and align?
I haven't looked at the test again, but Safari is passing for me locally? (and Edge doesn't implement the spec).
Status: WontFix (was: Assigned)
shape-outside-polygon-032.html appears to be passing in Chrome infra now, and for Chrome on wpt.fyi:
https://wpt.fyi/results/css/vendor-imports/mozilla/mozilla-central-reftests/shapes1/shape-outside-polygon-032.html?labels=experimental

Going with WontFix.

There are other Chrome-only failures in that directory which might be interesting to look at, though.

Sign in to add a comment