Exclude dangerous downloads from download home and infobar |
||||||||
Issue descriptionDangerous downloads should not be shown on the download progress infobar until they are confirmed by the user that they are safe. Today they are already filtered out from the notifications through DownloadController::OnDownloadUpdated. We should add the same check to DownloadManagerService. For download home, this still is debatable whether we should show or not. We should revisit that as a different issue.
,
Jun 2 2018
,
Jun 2 2018
,
Jun 3 2018
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ddd446ec94354912bb90dbc324f49aa3e3ad5f76 commit ddd446ec94354912bb90dbc324f49aa3e3ad5f76 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Mon Jun 04 19:51:27 2018 Downloads infobar : Exclude dangerous downloads Dangerous downloads should not be shown on the download progress infobar until they are confirmed by the user that they are safe. Added a field isDangerous to DownloadInfo and OfflineItem. Bug: 846849 Change-Id: I375a52f00e0c4b7f527b03820accfc7ad6df5d24 Reviewed-on: https://chromium-review.googlesource.com/1073666 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#563876}(cherry picked from commit 4f5e606e0b1366b12109644198bbcb4960c84873) Reviewed-on: https://chromium-review.googlesource.com/1085929 Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#159} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/ddd446ec94354912bb90dbc324f49aa3e3ad5f76/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfo.java [modify] https://crrev.com/ddd446ec94354912bb90dbc324f49aa3e3ad5f76/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfoBarController.java [modify] https://crrev.com/ddd446ec94354912bb90dbc324f49aa3e3ad5f76/chrome/browser/android/download/download_manager_service.cc [modify] https://crrev.com/ddd446ec94354912bb90dbc324f49aa3e3ad5f76/components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/OfflineItem.java [modify] https://crrev.com/ddd446ec94354912bb90dbc324f49aa3e3ad5f76/components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/bridges/OfflineItemBridge.java [modify] https://crrev.com/ddd446ec94354912bb90dbc324f49aa3e3ad5f76/components/offline_items_collection/core/android/offline_item_bridge.cc [modify] https://crrev.com/ddd446ec94354912bb90dbc324f49aa3e3ad5f76/components/offline_items_collection/core/offline_item.cc [modify] https://crrev.com/ddd446ec94354912bb90dbc324f49aa3e3ad5f76/components/offline_items_collection/core/offline_item.h
,
Jun 4 2018
,
Jun 4 2018
Fixed for download progress infobar i.e. dangerous download will not be shown on download progress infobar anymore.
,
Jun 14 2018
Verified in 68.0.3440.23 build and not see "“Speeding up your download” info-bar for dangerous downloads
,
Jun 18 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Jun 2 2018