New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846848 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 2
Type: Bug



Sign in to add a comment

BrowserFocusTest.PopupLocationBar not_site_per_process_interactive_ui_tests flaky on chromium.linux/Linux Tests

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, May 25 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of sandersd@chromium.org

not_site_per_process_interactive_ui_tests failing on chromium.linux/Linux Tests

Builders failed on: 
- Linux Tests: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests


 
Unable to reproduce BrowserFocusTest.PopupLocationBar failure locally.

Comment 2 by tapted@chromium.org, May 28 2018

Cc: sdy@chromium.org
Components: UI>Browser>WebAppInstalls
Labels: OS-Linux OS-Mac Type-Bug
Owner: ortuno@chromium.org
Status: Assigned (was: Available)
Summary: BrowserFocusTest.PopupLocationBar not_site_per_process_interactive_ui_tests flaky on chromium.linux/Linux Tests (was: not_site_per_process_interactive_ui_tests failing on chromium.linux/Linux Tests)
This was the run in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests/70062

I think the test is just flaky. It's disabled on Mac - due in part to  Issue 769327 

disable CL -> https://chromium-review.googlesource.com/#/c/chromium/src/+/1074891

error is

[ RUN      ] BrowserFocusTest.PopupLocationBar
Xlib:  extension "RANDR" missing on display ":99".
[14771:14771:0525/111947.838918:WARNING:password_store_factory.cc(250)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[14771:14806:0525/111947.841380:ERROR:bus.cc(394)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
(interactive_ui_tests:14771): LIBDBUSMENU-GLIB-WARNING **: Unable to get session bus: Unknown or unsupported transport 'disabled' for address 'disabled:'
BrowserTestBase received signal: Segmentation fault. Backtrace:
#0 0x00000407a6ec base::debug::StackTrace::StackTrace()
#1 0x000003b00035 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7fd3a9e4fcb0 <unknown>
#3 0x000001cefa49 ui_test_utils::IsViewFocused()
#4 0x000001c02d39 (anonymous namespace)::BrowserFocusTest_PopupLocationBar_Test::RunTestOnMainThread()
#5 0x000003affd5a content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#6 0x0000037be191 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#7 0x0000037bcefa ChromeBrowserMainParts::PreMainMessageLoopRun()
#8 0x00000271b801 content::BrowserMainLoop::PreMainMessageLoopRun()
#9 0x000002a7d5f7 content::StartupTaskRunner::RunAllTasksNow()
#10 0x00000271a372 content::BrowserMainLoop::CreateStartupTasks()
#11 0x00000271dee5 content::BrowserMainRunnerImpl::Initialize()
#12 0x00000271817c content::BrowserMain()
#13 0x00000377b02a content::ContentMainRunnerImpl::Run()
#14 0x000004fd5372 service_manager::Main()
#15 0x000003779014 content::ContentMain()
#16 0x000003aff939 content::BrowserTestBase::SetUp()
#17 0x000003792869 InProcessBrowserTest::SetUp()
#18 0x000001e0c53d testing::Test::Run()
#19 0x000001e0d1a0 testing::TestInfo::Run()
#20 0x000001e0d6b7 testing::TestCase::Run()
#21 0x000001e18f97 testing::internal::UnitTestImpl::RunAllTests()
#22 0x000001e18b0d testing::UnitTest::Run()
#23 0x000003fdea11 base::TestSuite::Run()
#24 0x000001c62c20 InteractiveUITestSuiteRunner::RunTestSuite()
#25 0x000003b0660f content::LaunchTests()
#26 0x00000378e383 LaunchChromeTests()
#27 0x000001c62b9d main
#28 0x7fd3a9e3af45 __libc_start_main
#29 0x000001b1102a _start

Comment 3 by tapted@chromium.org, May 28 2018

Labels: -Sheriff-Chromium
Project Member

Comment 4 by bugdroid1@chromium.org, May 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8d652b1a25a8496a2d2c2b201d90b2f77564451

commit b8d652b1a25a8496a2d2c2b201d90b2f77564451
Author: Trent Apted <tapted@chromium.org>
Date: Mon May 28 06:12:32 2018

Disable flaky BrowserFocusTest.PopupLocationBar

TBR=ortuno@chromium.org

Bug:  846848 ,  769327 ,  831483 
Change-Id: Iaebe8329099b47a369322541eabb50b8307eca41
Reviewed-on: https://chromium-review.googlesource.com/1074891
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562192}
[modify] https://crrev.com/b8d652b1a25a8496a2d2c2b201d90b2f77564451/chrome/browser/ui/browser_focus_uitest.cc

Comment 5 by ortuno@chromium.org, May 29 2018

Status: Started (was: Assigned)
The test is crashing because FocusManager returns nullptr for GetFocusedView().

I believe it's because the browser is not active when clicking on the browser view, so it doesn't actually get focused. Adding a delay between opening the browser and clicking on the browser view fixes the crash.

Still looking for a better solution.
Project Member

Comment 6 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e739e2671933d445245532567494738aa37c5b2

commit 6e739e2671933d445245532567494738aa37c5b2
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Wed May 30 07:34:54 2018

bookmark-apps: Fix focus test for popup and app windows

The browser window wasn't active by the time the test tried to focus
it. This caused GetFocusedView() in IsViewFocused() to return nullptr
and cause a seg fault.

Fixes the test by ensuring the browser is brought to the front before
trying to focus it. Also replaces ClickOnView with FocusView since
ClickOnView could end up clicking the window in the back if the popup
wasn't opened yet.

Bug:  846848 ,  831483 
Change-Id: I66b75dc264b6a82896d5ef20b1a44bc937d367e1
Reviewed-on: https://chromium-review.googlesource.com/1077109
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562757}
[modify] https://crrev.com/6e739e2671933d445245532567494738aa37c5b2/chrome/browser/ui/browser_focus_uitest.cc

Comment 7 by ortuno@chromium.org, May 30 2018

Status: Fixed (was: Started)
*fingers crossed*

Sign in to add a comment