New issue
Advanced search Search tips

Issue 846842 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

method_count.py reading split dex

Project Member Reported by smaier@chromium.org, May 25 2018

Issue description

method_count.py has an option to point at an .apk, but it aggregates all methods in the .apk across any number of .dex files. We should split the information from each .dex file as we work on splitting up the .dex files in release.

 
Project Member

Comment 1 by sheriffbot@chromium.org, May 28 2018

Labels: Hotlist-Recharge-BouncingOwner
Owner: ----
Status: Untriaged (was: Started)
The assigned owner "smaier@chromium.org" is not able to receive e-mails, please re-triage.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb7233cee8436ea524be3eb000e21c54c1c64f69

commit eb7233cee8436ea524be3eb000e21c54c1c64f69
Author: Sam Maier <smaier@chromium.org>
Date: Tue May 29 13:36:55 2018

method_count.py reports split dex seperately.

It is now useful to do "method_count.py ChromePublic.apk" for split dex
testing.

Tested resource_sizes.py by diffing the output of it with and without
my change - the output (from that file) appears identical.

Bug:  846842 
Change-Id: Ieaf05e595f397b2881d55a48cdfa1d15b4e30326
Reviewed-on: https://chromium-review.googlesource.com/1073662
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562409}
[modify] https://crrev.com/eb7233cee8436ea524be3eb000e21c54c1c64f69/build/android/method_count.py
[modify] https://crrev.com/eb7233cee8436ea524be3eb000e21c54c1c64f69/build/android/resource_sizes.py

Comment 3 by smaier@chromium.org, May 30 2018

Owner: smaier@chromium.org
Project Member

Comment 4 by sheriffbot@chromium.org, May 30 2018

Owner: ----
The assigned owner "smaier@chromium.org" is not able to receive e-mails, please re-triage.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: smaier@chromium.org
Status: Fixed (was: Untriaged)

Sign in to add a comment