Icons in gnome theme are not found |
|||
Issue descriptionVarious applications will rely on icons only in the 'gnome' theme directory and not into the 'hicolor' directory. Examples are gnome-terminal (which won't show up by default due to properties in the .desktop file) and gdebi. We should modify garcon so that it looks in the 'gnome' theme directory first and then in 'hicolor' because based on the spec, hicolor should always be the last directory searched so it would be odd to search gnome second as a fallback.
,
May 31 2018
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/dea76cee64f3ee6bc977801d2478597c2f41a85a commit dea76cee64f3ee6bc977801d2478597c2f41a85a Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Wed Jun 13 08:01:01 2018 vm_tools: Expand theme and type searching for icons This expands the icon search so we first check the gnome theme and then the hicolor theme. It also allows icons from not only the Applications context but also the MimeTypes context. BUG= chromium:846832 TEST=Gdeb and gnome-terminal (w/ modified .desktop) icons show up Change-Id: Id73e6a238edfd2bd7964c9a8a5c1dbf0500b0086 Reviewed-on: https://chromium-review.googlesource.com/1081356 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: David Reveman <reveman@chromium.org> [modify] https://crrev.com/dea76cee64f3ee6bc977801d2478597c2f41a85a/vm_tools/garcon/icon_index_file.cc [modify] https://crrev.com/dea76cee64f3ee6bc977801d2478597c2f41a85a/vm_tools/garcon/icon_finder_unittest.cc [modify] https://crrev.com/dea76cee64f3ee6bc977801d2478597c2f41a85a/vm_tools/garcon/icon_finder.cc
,
Jun 13 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by jkardatzke@chromium.org
, May 25 2018