New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846822 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

Virtual keyboard keys are not role='button'

Project Member Reported by katie@chromium.org, May 25 2018

Issue description

If they were role='button' Chromevox and Select-to-Speak would highlight more than just the inlineTextBox and Chromevox would be able to know more about the key as well.
 

Comment 1 by katie@chromium.org, May 25 2018

Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39c185606b8153fe182be00a7a4987aacf86acd6

commit 39c185606b8153fe182be00a7a4987aacf86acd6
Author: Katie D <katie@chromium.org>
Date: Tue Jun 05 16:44:40 2018

Accessibility fixes for Virtual Keyboard: Use role 'button', fix space label.

With role of 'button', Chromevox and Select-to-Speak will draw a focus rect
around the entire area of a button instead of just around the inlineTextBox
(i.e. the letter 'a' or 'b').

The spacebar was being read as "English", but should be read as "Space", this
hooks up setting the content description as well.

Bug:  846823 , 846822 
Change-Id: I03846b3f823fefd45b3a9fe1bd2feac0c1094ed3
Reviewed-on: https://chromium-review.googlesource.com/1073641
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564538}
[modify] https://crrev.com/39c185606b8153fe182be00a7a4987aacf86acd6/third_party/google_input_tools/src/chrome/os/inputview/elements/content/characterkey.js
[modify] https://crrev.com/39c185606b8153fe182be00a7a4987aacf86acd6/third_party/google_input_tools/src/chrome/os/inputview/elements/content/functionalkey.js
[modify] https://crrev.com/39c185606b8153fe182be00a7a4987aacf86acd6/third_party/google_input_tools/src/chrome/os/inputview/elements/content/material/spacekey.js
[modify] https://crrev.com/39c185606b8153fe182be00a7a4987aacf86acd6/third_party/google_input_tools/src/chrome/os/inputview/elements/content/spacekey.js

Comment 3 by katie@chromium.org, Jun 5 2018

Status: Fixed (was: Assigned)

Sign in to add a comment