New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 846811 link

Starred by 2 users
Status: Assigned
Owner:
samans@chromium.org
Cc:
█ fsam...@chromium.org
m...@chromium.org
kylec...@chromium.org
jonr...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Merge DevToolsVideoConsumer into ClientFrameSinkVideoCapturer

Project Member Reported by samans@chromium.org, May 25 2018 
DevToolsVideoConsumer exists to prevent writing boilerplate code in different clients of FrameSinkVideoCapturer in DevTools. We can hide the common code inside ClientFrameSinkVideoCapturer and get rid of DevToolsVideoConsumer.

Comment 1 by m...@chromium.org, May 29 2018 

IMHO, it's good that ClientFrameSinkVideoCapturer is only functionally responsible for auto-reconnect after a VIZ crash. I'm concerned about overloading it with other, orthogonal functionality, especially since the requirements of content::FrameSinkVideoCaptureDevice differ from the DevTools requirements in many key ways.

Comment 2 by samans@chromium.org, Jun 1 2018 

It can do some basic stuff like wrapping the shared memory into a VideoFrame and providing a method to convert VideoFrame to Bitmap.

Comment 3 by samans@chromium.org, Jun 1 2018 

I think that's the main purpose of DevToolsVideoConsumer.

Comment 4 by benhenry@chromium.org, Aug 2

Status: Assigned (was: Available)
►

Sign in to add a comment