Padding on secondary accounts sign in promo bubble is double what it should be |
|||||
Issue descriptionIt looks like something changed in MacViews between 67 and 68 that's causing the padding in our Dice sign in promo menus to be a bit off. I looked at this with Joel, and he said it looked like the top and bottom padding was double what it should be. Comparing Beta and Canary below. Screenshot of secondary accounts menu on Beta: https://screenshot.googleplex.com/sSxVud0xbQH.png Screenshot of secondary accounts menu on Canary: https://screenshot.googleplex.com/4tZ1Sk4zhS2.png Not sure who to assign this to, or whether this is actually WAI. Assigning to Elly for help with MacViews triaging and cc'ing some other MacViews folks.
,
May 29 2018
That's odd - I didn't touch that spacing. Can you point me at the MenuModel for your menu?
,
May 29 2018
https://cs.chromium.org/chromium/src/chrome/browser/ui/views/profiles/dice_accounts_menu.cc?dr=CSs&g=0&l=77 this separator probably accounts for the extra space - does the menu look right if you remove it?
,
May 29 2018
,
May 30 2018
Yes, it's the separator! (I just tested it on my MacBook.) Thanks! It looks like it's part of the new material design specs. And only for MacViews: https://cs.chromium.org/chromium/src/ui/views/controls/menu/menu_config_mac.mm?sq=package:chromium&g=0&l=17 Do you know if it will change for Win/Linux in the future?
,
May 30 2018
+cc bsep@ for #6 :)
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c8aaaae31ae1a790f4b71533c9cd48b2a51663e commit 2c8aaaae31ae1a790f4b71533c9cd48b2a51663e Author: Thomas Tangl <tangltom@chromium.org> Date: Wed May 30 15:05:17 2018 [Dice] Fix accounts submenu border on Mac This CL removes the additional top/bottom separator of the accounts submenu on Mac. Bug: 846803 Change-Id: I7331c010a8734f62cac8bf48d19bb9854f0a0492 Reviewed-on: https://chromium-review.googlesource.com/1078752 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#562825} [modify] https://crrev.com/2c8aaaae31ae1a790f4b71533c9cd48b2a51663e/chrome/browser/ui/views/profiles/dice_accounts_menu.cc
,
May 30 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by meh...@chromium.org
, May 25 2018Status: Assigned (was: Untriaged)