asvitkine@: Are you using Chrome 66 Stable? Not sure, but your issue sounds like  bug 843075 , which will be fixed in Chrome 67.

I'm talking about the "speaker" emoji icon in the "Window" menu (which doesn't exist at all - rather than not having a color), not the "recording" icon in the tab not having a color.

I can reproduce this locally. We probably need to fix the behavior of BrowserWindowCocoa::WindowTitle() (and match it in the Views code perhaps).

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf2d5c1f1587d0cdd040cfb95f56555141ff53f9

commit cf2d5c1f1587d0cdd040cfb95f56555141ff53f9
Author: Leonard Grey <lgrey@chromium.org>
Date: Mon Jul 23 23:44:18 2018

MacViews: Add icon to audio playing/muted tabs in Window menu

Bug:  846796 
Change-Id: I417702c78b1b5dec4914a9efbc0ec16e1d016de9
Reviewed-on: https://chromium-review.googlesource.com/1147148
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577335}
[modify] https://crrev.com/cf2d5c1f1587d0cdd040cfb95f56555141ff53f9/chrome/browser/ui/views/frame/browser_view.cc

Tried checking the issue on chrome version 66.0.3359.181 and on the latest canary 70.0.3501.0 using Mac 10.13.1 with the below mentioned steps.
1. Launched Chrome
2. Signed in google account
3. Made a Hangout call
In both the versions we observed similar behaviour i.e., audio playing icon isn't observed. Attaching the screenshot of the same for reference.

@Leonard Grey: Could you please let us know if we have missed anything in the process of checking and requesting you to help us in verifying the fix.

Thanks!

Deleted: 846796 CL Verif.png 184 KB

	846796 CL Verif.png 184 KB View Download

Re c#5, it's not fixed. The above CL was to add the basic functionality to MacViews; the Hangouts part will be addressed later.

So it looks like the media capture tab alert state trumps the audio playing state in Hangouts (and probably other WebRTC type situations?)

So now the question is: can we determine if a media capture session is also playing audio?
+miu@ adding you based on https://chromium-review.googlesource.com/c/chromium/src/+/1065065 Do you know the answer to the above question? If not, do you know the best person to ask?

 Issue 884487  has been merged into this issue.

Would it also be possible to port the browser_window_cocoa_unittest for this (https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm?l=40&rcl=c363b5b5f180353ffd6c926f17a484cb3c5a6051) ?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a7e677a460c8db87ce94f3f31c360508ca9879d

commit 5a7e677a460c8db87ce94f3f31c360508ca9879d
Author: Leonard Grey <lgrey@chromium.org>
Date: Tue Oct 09 20:16:28 2018

Mac: Add test for audio indicators in Window menu

Bug:  846796 
Change-Id: Ie69dbe8cfa27817db25ba899422f8d0a920e5eca
Reviewed-on: https://chromium-review.googlesource.com/c/1270351
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598058}
[modify] https://crrev.com/5a7e677a460c8db87ce94f3f31c360508ca9879d/chrome/browser/ui/views/frame/browser_view_unittest.cc

In the code change referenced in comment #4, it'd probably be better for the menu item to determine if audio is playing by NOT using chrome::GetTabAlertStateForContents(). That function holds the logic that determines which alert icon will show up in the tab strip. Since there can only be one alert icon, it has logic to decide which to show when multiple conditions are present. This is not the behavior we'd want in the window menu, since we only care about sound output there.

Instead, I would suggest using chrome/browser/ui/recently_audible_helper.h instead. Probably something like:

  title = ...GetWindowTitleForCurrentTab...;
#ifdef OS_MAC
  if (contents->IsAudioMuted()) {
    title = ...IDS_WINDOW_AUDIO_MUTING_MAC...;
  } else if (auto* helper = RecentlyAudibleHelper::FromWebContents(contents)) {
    if (helper->WasRecentlyAudible()) {
      title = ...IDS_WINDOW_AUDIO_PLAYING_MAC...;
    }
  }
#endif

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/546926a459db3b5fa2b4c1bcea2566b3b539781b

commit 546926a459db3b5fa2b4c1bcea2566b3b539781b
Author: Leonard Grey <lgrey@chromium.org>
Date: Tue Oct 16 17:40:40 2018

Mac: Don't use tab icons to set window title audio state icons

Bug:  846796 
Change-Id: If5ba4f29ace1dce12e13a9bfdae3ee9154811187
Reviewed-on: https://chromium-review.googlesource.com/c/1283549
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600032}
[modify] https://crrev.com/546926a459db3b5fa2b4c1bcea2566b3b539781b/chrome/browser/ui/views/frame/browser_view.cc

Thanks for the suggestion, miu@!