Issue metadata
Sign in to add a comment
|
Audio mute/unmute button is displaced in cast ui while using Castouts |
||||||||||||||||||||||
Issue descriptionChrome Version: 68.0.3432.3 OS: Win, Mac, etc. MR: 6818.521.0.0 What steps will reproduce the problem? (1) open cast UI (2) select meeting/call from device list What is the expected result? mute button used to be aligned with the checkbox for smooth motion. What happens instead? mute button is no longer aligned with the checkbox for smooth motion.
,
May 29 2018
,
May 29 2018
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd2798b8c57210e155a452e8a0ade68cf5a2aea7 commit bd2798b8c57210e155a452e8a0ade68cf5a2aea7 Author: Scott Chen <scottchen@chromium.org> Date: Wed May 30 01:17:28 2018 Cast: makes checkbox alignment same as before Bug: 846795 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I75f1f23bfbf090b9eeaaebfc46c566e1c620c639 Reviewed-on: https://chromium-review.googlesource.com/1076811 Reviewed-by: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#562685} [modify] https://crrev.com/bd2798b8c57210e155a452e8a0ade68cf5a2aea7/chrome/browser/resources/media_router/elements/route_controls/route_controls.css
,
May 30 2018
The issue can't be verified from TE-end as we don't have any casting devices to test the issue. dbbrooks@ - Requesting to please help us in verifying the fix. Thanks...!!
,
May 30 2018
Verified it looks correct now on 69.0.3445.0. Thanks!
,
May 30 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-68; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-68 label, otherwise remove Merge-TBD label. Thanks.
,
May 30 2018
,
May 31 2018
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 31 2018
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7bc4f1a76dc951f65fce9469c12d4159f3cfc35 commit f7bc4f1a76dc951f65fce9469c12d4159f3cfc35 Author: Scott Chen <scottchen@chromium.org> Date: Fri Jun 01 19:47:43 2018 Cast: makes checkbox alignment same as before Bug: 846795 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I75f1f23bfbf090b9eeaaebfc46c566e1c620c639 Reviewed-on: https://chromium-review.googlesource.com/1076811 Reviewed-by: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#562685}(cherry picked from commit bd2798b8c57210e155a452e8a0ade68cf5a2aea7) Reviewed-on: https://chromium-review.googlesource.com/1083018 Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#97} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/f7bc4f1a76dc951f65fce9469c12d4159f3cfc35/chrome/browser/resources/media_router/elements/route_controls/route_controls.css |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by taku...@chromium.org
, May 25 2018Labels: -Type-Bug M-68 Type-Bug-Regression