Thanks for finding this. This is a good edge case.

Taking ownership.

The NextAction date has arrived: 2018-06-20

 Issue 847433  has been merged into this issue.

Hi Ed, any update here?

This does not feel like an M69 RBS to me. The behavior might be unexpected, but there isn't any data loss, right?  If the only result is that you end up with two copies of the tab, I'd be comfortable fixing this in M70.

CL is in-flight.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9898ecfdda0b5bf9ea4cedb713726db3e2eba225

commit 9898ecfdda0b5bf9ea4cedb713726db3e2eba225
Author: edchin <edchin@chromium.org>
Date: Wed Aug 08 18:40:52 2018

[ios] Update recently closed tabs after undoing close all

When undoing a close all tabs action, the recently closed tabs would
continue to show all the tabs. This CL properly removes the restored
tabs by removing them from the TabRestoreService.

Bug:  846786 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3c02270cd8f4e9998f3e51032f5973fe0329bf6e
Reviewed-on: https://chromium-review.googlesource.com/1167118
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581640}
[modify] https://crrev.com/9898ecfdda0b5bf9ea4cedb713726db3e2eba225/ios/chrome/browser/ui/tab_grid/tab_grid_mediator.mm
[modify] https://crrev.com/9898ecfdda0b5bf9ea4cedb713726db3e2eba225/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

This bug requires manual review: Less than 23 days to go before AppStore submit on M69
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Tested on 70.0.3517.0 Canary, iPad Pro 12.9  iOS10.3.3 with hardware keyboard attached.

Issue is still repro.
https://drive.google.com/file/d/14tWEeY9jR030B4feSf1dM071CBemwDco/view

We should get this fixed, but it's well below the bar for M69 at this point, and I don't think it's worth merging the existing fix in.

Dropping to P2, removing merge labels and RBS.

Verified on 70.0.3517.0 Canary, iPad Pro 12.9  iOS 10.3.3 , iOS 11.4 with hardware keyboard attached.
After discussing this with Ed, this bug is working fine now.hence closing it as Verified.

Steps Verified :

  1. Launch Google Chrome (Cold Start without any previous tabs)
  2. Navigate to a webpage say (google.com)
  3. Enter TabSwitcher mode
  4. Tap Close All
  5. Tap Undo
  6. Exit Tab Switcher.
  7. Send command "Cmd + Shift + T" from the attached keyboard.


Current Result: Previously closed Tab(google.com) opens.

marq@, I'd like to merge this. This is fixed and works well.

vbhatsoori@, the important thing to verify is that the keyboard shortcut reopens from the list of recently closed tabs. If there are recently closed tabs, then it will be reopened. If there are none, then it will not open anything. 

Can you confirm this? 

This bug requires manual review: Less than 21 days to go before AppStore submit on M69
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Approved.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c2f8fe24c9779b48f642fa5bf5f6a3c03b2f3bb

commit 0c2f8fe24c9779b48f642fa5bf5f6a3c03b2f3bb
Author: edchin <edchin@chromium.org>
Date: Fri Aug 10 19:04:06 2018

[ios] Update recently closed tabs after undoing close all

When undoing a close all tabs action, the recently closed tabs would
continue to show all the tabs. This CL properly removes the restored
tabs by removing them from the TabRestoreService.

Bug:  846786 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3c02270cd8f4e9998f3e51032f5973fe0329bf6e
Reviewed-on: https://chromium-review.googlesource.com/1167118
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#581640}(cherry picked from commit 9898ecfdda0b5bf9ea4cedb713726db3e2eba225)
Reviewed-on: https://chromium-review.googlesource.com/1171422
Cr-Commit-Position: refs/branch-heads/3497@{#542}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/0c2f8fe24c9779b48f642fa5bf5f6a3c03b2f3bb/ios/chrome/browser/ui/tab_grid/tab_grid_mediator.mm
[modify] https://crrev.com/0c2f8fe24c9779b48f642fa5bf5f6a3c03b2f3bb/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

Verified on 69.0.3497.41 beta, iPad Pro 12.9  iOS 10.3.3 , iOS 11.4 with hardware keyboard attached as per #22
@edchin : Looks good.