New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 846769 link

Starred by 1 user
Status: Verified
Owner:
kkhorimoto@chromium.org
Closed: Jul 10
Cc:
█ ghendel@chromium.org
srikanthg@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Results are not spoken after performing voice search.

Project Member Reported by srikanthg@chromium.org, May 25 2018 
App Version: 68.0.3440.0 canary
iOS Version: 11.2.6, 11.4
Device: iPads, iPhones
URL: any

Precondition: Enable #ui-refresh-phase-1 from about://flags

Steps to reproduce:
  1. Launch Google Chrome
  2. Tap on the VoiceSearch icon.
  3. Perform voice search for "What is the time now"

Observed results: Search results for time are displayed, but results are not spoken 

Expected results: Results should be spoken.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes

Comment 1 by kkhorimoto@chromium.org, May 31 2018

Owner: kkhorimoto@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by kkhorimoto@chromium.org, May 31 2018

Labels: ReleaseBlock-Stable M-69

Comment 3 by kkhorimoto@chromium.org, Jun 6 2018

Status: Started (was: Assigned)

Comment 5 by marq@chromium.org, Jun 27 2018

Labels: Q2
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba73c2613a66a6cbce098e06e6925104cb4ce4e4

commit ba73c2613a66a6cbce098e06e6925104cb4ce4e4
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Tue Jul 10 21:53:13 2018

[iOS] Create TextToSpeechPlaybackController.

Since we no longer are useing the GLIF "talking dots" animations after
enabling the UI refresh flag, there are no UI elements waiting for
TTS notifications.  This CL introduces a KeyedService that handles
listening for TTS notifications, starting playback, and cancelling
playback for WebState and WebStateObserver changes.

Bug:  846769 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I09f5143b26951bb3db4dad58f1a61ee94434785b
Reviewed-on: https://chromium-review.googlesource.com/1095817
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573932}
[modify] https://crrev.com/ba73c2613a66a6cbce098e06e6925104cb4ce4e4/ios/chrome/browser/browser_state/BUILD.gn
[modify] https://crrev.com/ba73c2613a66a6cbce098e06e6925104cb4ce4e4/ios/chrome/browser/browser_state/browser_state_keyed_service_factories.mm
[modify] https://crrev.com/ba73c2613a66a6cbce098e06e6925104cb4ce4e4/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/ba73c2613a66a6cbce098e06e6925104cb4ce4e4/ios/chrome/browser/ui/voice/BUILD.gn
[add] https://crrev.com/ba73c2613a66a6cbce098e06e6925104cb4ce4e4/ios/chrome/browser/ui/voice/text_to_speech_notification_handler.h
[add] https://crrev.com/ba73c2613a66a6cbce098e06e6925104cb4ce4e4/ios/chrome/browser/ui/voice/text_to_speech_notification_handler.mm
[add] https://crrev.com/ba73c2613a66a6cbce098e06e6925104cb4ce4e4/ios/chrome/browser/ui/voice/text_to_speech_playback_controller.h
[add] https://crrev.com/ba73c2613a66a6cbce098e06e6925104cb4ce4e4/ios/chrome/browser/ui/voice/text_to_speech_playback_controller.mm
[add] https://crrev.com/ba73c2613a66a6cbce098e06e6925104cb4ce4e4/ios/chrome/browser/ui/voice/text_to_speech_playback_controller_factory.h
[add] https://crrev.com/ba73c2613a66a6cbce098e06e6925104cb4ce4e4/ios/chrome/browser/ui/voice/text_to_speech_playback_controller_factory.mm

Comment 7 by kkhorimoto@chromium.org, Jul 10

Status: Fixed (was: Started)

Comment 8 by kkhorimoto@chromium.org, Jul 11

Cc: srikanthg@chromium.org ghendel@chromium.org
srikanthg@: This landed yesterday, and seems to be working in Canary.  However, Gabe tested in Dev, and it isn't working for him.  We're not sure if this is because the fix wasn't included in time for the Dev build, or if there's an actual issue with the CL.  If you are able to repro this bug on the latest canary, can you update with repro steps?  Thanks!

Comment 9 by srikanthg@chromium.org, Jul 11

Status: Verified (was: Fixed)
The fix is available on M69.0.3488.0 canary. We sent 69.0.3487.0 to dogfoody and doesn't have this fix.

I have verified the fix on latest canary and Text to Speech is working fine.

Comment 10 by kkhorimoto@chromium.org, Jul 11 

Great, thanks for the verification!
►

Sign in to add a comment