New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 846764 link

Starred by 2 users
Status: Verified
Owner:
justincohen@chromium.org
Closed: Jun 2018
Cc:
gambard@chromium.org
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug
Q2



Sign in to add a comment

Shortcut icons from NewTabPage are not functional when omnibox is focused.

Project Member Reported by srikanthg@chromium.org, May 25 2018 
App Version: 68.0.3440.0 canary
iOS Version: 11.2.6, 11.4
Device: iPads only
URL: any

Precondition: Enable #ui-refresh-phase-1 from about://flags

Steps to reproduce:
  1. Launch Google Chrome
  2. Tap on "Search or type URL" to focus
  3. Tap on any of the icons Bookmarks/ReadingList/RecentTabs/History

Observed results: No action performed. Omnibox is defocused.

Expected results: Omnibox should defocus, and tap action should be performed.

Working fine when tapping on other elements like, MostVisited icons, ContentSuggestions etc.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes

Comment 1 by twelling...@chromium.org, May 29 2018

Labels: zine-triaged

Comment 2 by kkhorimoto@chromium.org, May 31 2018

Cc: gambard@chromium.org
Owner: justincohen@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by justincohen@chromium.org, May 31 2018

Labels: ReleaseBlock-Stable M-69

Comment 4 by justincohen@chromium.org, Jun 21 2018

Status: Started (was: Assigned)

Comment 5 by marq@chromium.org, Jun 27 2018

Labels: Q2
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4eaca7cab78c60fdd8906ce9d643fa71aeb5b2d4

commit 4eaca7cab78c60fdd8906ce9d643fa71aeb5b2d4
Author: Justin Cohen <justincohen@google.com>
Date: Wed Jun 27 15:17:51 2018

[ios] Various NTP fixes for UI Refresh.

-Fix tapping NTP action cells when omnibox is focused.
-Do not remove action items when most visited is empty.
-Disable dynamic type sizes on most visited and action items.
-Fix omnibox visibility on iPad when search provider changes.

Bug:  846764 ,  852108 , 850469, 848762
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie1c38be47fb9a60325387a78f55eb1a548dae831
Reviewed-on: https://chromium-review.googlesource.com/1110148
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570777}
[modify] https://crrev.com/4eaca7cab78c60fdd8906ce9d643fa71aeb5b2d4/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_action_cell.mm
[modify] https://crrev.com/4eaca7cab78c60fdd8906ce9d643fa71aeb5b2d4/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_cell.mm
[modify] https://crrev.com/4eaca7cab78c60fdd8906ce9d643fa71aeb5b2d4/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.mm
[modify] https://crrev.com/4eaca7cab78c60fdd8906ce9d643fa71aeb5b2d4/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm
[modify] https://crrev.com/4eaca7cab78c60fdd8906ce9d643fa71aeb5b2d4/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm
[modify] https://crrev.com/4eaca7cab78c60fdd8906ce9d643fa71aeb5b2d4/ios/chrome/browser/ui/content_suggestions/content_suggestions_mediator.mm

Comment 7 by justincohen@chromium.org, Jun 27 2018

Status: Fixed (was: Started)

Comment 8 by shbarezer@chromium.org, Jul 3

Status: Verified (was: Fixed)
Verified in 69.0.3480.0 Canary, iPhone X  iOS 11.4, iPad Air  iOS11.4
Looks good
►

Sign in to add a comment