Issue metadata
Sign in to add a comment
|
Don't show progress bar in iPad toolbar. |
||||||||||||||||||||||
Issue descriptionApp Version: 68.0.3440.0 canary iOS Version: 11.2.6, 11.4 Device: iPads URL: any Precondition: Enable #ui-refresh-phase-1 from about://flags Steps to reproduce: 1. Launch Google Chrome 2. Navigate to any webpage say www.google.com Observed results: Observe that while loading the page, progress is displayed under the toolbar. This issue was fixed in the past for non-UI-Refresh. http://crbug/749788 Works fine for Regular Chrome(ie: without UI-Refresh). Expected results: Progress bar shouldn't be displayed for iPads. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes
,
Jun 1 2018
Assigning to Pete for opinion. Do we want to have the progress bar?
,
Jun 4 2018
The behavior should match what we have in stable today: 2 distinct progress indicators. Now, however, we can apply them more cleanly based on size classes rather than device idioms: A) When the tab strip is visible (RxR size class), we should use the circular progress indicator that replaces the favicon in the focused tab shape. B) In all other size classes (where there is no tab strip), we should use the progress bar that runs horizontally along the bottom edge of the top toolbar.
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45dffb6b54114b9fc95f2152fb5ddcb752bfef29 commit 45dffb6b54114b9fc95f2152fb5ddcb752bfef29 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Jun 05 15:30:33 2018 Do not show the progress bar with the TabStrip This CL makes sure the progress bar is hidden when the TabStrip is shown on Regular x Regular size class. Bug: 846759 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I664ab653abc7547f5416c3ec4b57b6df3c5857c7 Reviewed-on: https://chromium-review.googlesource.com/1086803 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#564513} [modify] https://crrev.com/45dffb6b54114b9fc95f2152fb5ddcb752bfef29/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.mm
,
Jun 5 2018
,
Jun 6 2018
The NextAction date has arrived: 2018-06-06
,
Jun 12 2018
Verified in 69.0.3456.0 Canary, iPad Air iOS11.4. Looks good. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kkhorimoto@chromium.org
, May 31 2018Status: Assigned (was: Untriaged)