New issue
Advanced search Search tips

Issue 846742 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Task



Sign in to add a comment

Separate MachineLevelUserCloudPolicy logic from ChromeBrowserPolicyConnector.

Project Member Reported by zmin@chromium.org, May 25 2018

Issue description

As the code of MachineLevelUserCloudPolicy become more and more complicated. It worth to refactor the code to move the cloud policy logic into its individual class.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b48a67472f9a20a4e9742e35c51d12f07e6cf2c4

commit b48a67472f9a20a4e9742e35c51d12f07e6cf2c4
Author: Owen Min <zmin@chromium.org>
Date: Tue Jun 12 21:41:22 2018

Refactor ChromeBrowserPolicyConnector.

Refactor the class to move most of MachineLevelUserCloudPolicy related code
into its own class.

Bug:  846742 
Change-Id: I7d548a1d1e96de7ebbecf48a7e4e29d1cc033c12
Reviewed-on: https://chromium-review.googlesource.com/1089922
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566583}
[modify] https://crrev.com/b48a67472f9a20a4e9742e35c51d12f07e6cf2c4/chrome/browser/BUILD.gn
[modify] https://crrev.com/b48a67472f9a20a4e9742e35c51d12f07e6cf2c4/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/b48a67472f9a20a4e9742e35c51d12f07e6cf2c4/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper.cc
[modify] https://crrev.com/b48a67472f9a20a4e9742e35c51d12f07e6cf2c4/chrome/browser/policy/chrome_browser_policy_connector.cc
[modify] https://crrev.com/b48a67472f9a20a4e9742e35c51d12f07e6cf2c4/chrome/browser/policy/chrome_browser_policy_connector.h
[modify] https://crrev.com/b48a67472f9a20a4e9742e35c51d12f07e6cf2c4/chrome/browser/policy/cloud/machine_level_user_cloud_policy_browsertest.cc
[add] https://crrev.com/b48a67472f9a20a4e9742e35c51d12f07e6cf2c4/chrome/browser/policy/machine_level_user_cloud_policy_controller.cc
[add] https://crrev.com/b48a67472f9a20a4e9742e35c51d12f07e6cf2c4/chrome/browser/policy/machine_level_user_cloud_policy_controller.h
[modify] https://crrev.com/b48a67472f9a20a4e9742e35c51d12f07e6cf2c4/chrome/browser/policy/machine_level_user_cloud_policy_register_watcher.cc
[modify] https://crrev.com/b48a67472f9a20a4e9742e35c51d12f07e6cf2c4/chrome/browser/policy/machine_level_user_cloud_policy_register_watcher.h
[modify] https://crrev.com/b48a67472f9a20a4e9742e35c51d12f07e6cf2c4/chrome/browser/policy/machine_level_user_cloud_policy_register_watcher_unittest.cc

Comment 2 by zmin@chromium.org, Jun 15 2018

Status: Fixed (was: Assigned)

Sign in to add a comment