New issue
Advanced search Search tips

Issue 846733 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make forced subresource_filter activation simulate the site matching the safe browsing list

Project Member Reported by csharrison@chromium.org, May 25 2018

Issue description

This will:
1. Simplify the code a lot (and blocks  issue 717590 )

2. Make the devtools setting more useful, since it actually shows
   developers what would happen if their site starts failing BAS.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d94c1d3fd49150b5cd2872df17f5411969238b8

commit 6d94c1d3fd49150b5cd2872df17f5411969238b8
Author: Charlie Harrison <csharrison@chromium.org>
Date: Thu May 31 02:33:01 2018

Remove forced activation

This CL has one major behavior change:
Forcing activation via the devtools setting simulates the current
site being on the blacklist. This means it will get full UI and
settings treatment.

Fallout from this change is:
1. Remove the driver factory entirely, and put the SubresourceFilterClient
   in the throttle manager
2. Refactor the SubresourceFilterClient to make its activation overriding
   more flexible (and put devtools stuff there). This moves all devtools
   knowledge out of //components layer.

TBR=avi@chromium.org
Bug:  717590 ,  846733 

Change-Id: Ifeff329499f9d39f1140b4c34643e67d6a79d0ab
Reviewed-on: https://chromium-review.googlesource.com/1066898
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563126}
[modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/chrome/browser/subresource_filter/chrome_subresource_filter_client.cc
[modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/chrome/browser/subresource_filter/chrome_subresource_filter_client.h
[modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/chrome/browser/subresource_filter/subresource_filter_abusive_unittest.cc
[modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/chrome/browser/subresource_filter/subresource_filter_devtools_browsertest.cc
[modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/chrome/browser/subresource_filter/subresource_filter_test_harness.cc
[modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/chrome/browser/subresource_filter/subresource_filter_unittest.cc
[modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/chrome/browser/ui/tab_helpers.cc
[modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/components/subresource_filter/content/browser/BUILD.gn
[delete] https://crrev.com/b4283ffba108e3d9ae5de968e56b38e8ff7c7571/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
[delete] https://crrev.com/b4283ffba108e3d9ae5de968e56b38e8ff7c7571/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h
[modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc
[modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h
[modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc
[modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/components/subresource_filter/content/browser/subresource_filter_client.h
[modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc
[modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc
[modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/components/subresource_filter/core/browser/subresource_filter_features.cc
[modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/components/subresource_filter/core/browser/subresource_filter_features.h
[modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc
[modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/components/subresource_filter/core/common/activation_decision.h
[modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment