New issue
Advanced search Search tips

Issue 846732 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename services/proxy_resolver/public/mojom/proxy_resolver.mojom

Project Member Reported by xunji...@chromium.org, May 25 2018

Issue description

services/proxy_resolver/public/mojom/proxy_resolver.mojom is specific to PAC script. It doesn't provide a general proxy resolution interface.
It should be renamed to reflect that. Probably to pac_executor as suggested by mmenke@.
 
Owner: xunji...@chromium.org

Comment 2 by mmenke@chromium.org, May 25 2018

Cc: eroman@chromium.org
Probably best to give eroman a chance to weigh in on naming before writing a CL.

Comment 3 by eroman@chromium.org, May 30 2018

The current name seems OK to me.

The interface is pretty close to https://chromium.googlesource.com/chromium/src/+/master/net/proxy_resolution/proxy_resolver.h, but with some extra dependencies used specifically for running PAC.

Given that a "proxy resolver" is already a well established term in the codebase, I would say it is better to keep close to that than to use new nomenclature like "pac executor".

If we really wanted to clarify, could call it PacProxyResolver to emphasize that it is a for PAC. Or keep it as ProxyResolver, but rename the dependencies to include the word PAC in them.

Comment 4 by mmenke@chromium.org, May 30 2018

Note that external consumers will need an API to map a GURL to a proxy...I'd call that "proxy resolution".

Also, "ProxyResolutionService" vs "ProxyResolver" seems very non-intuitive naming.  One would think they do the same thing.
Owner: ----
Status: Available (was: Assigned)

Sign in to add a comment