Rename services/proxy_resolver/public/mojom/proxy_resolver.mojom |
|||
Issue descriptionservices/proxy_resolver/public/mojom/proxy_resolver.mojom is specific to PAC script. It doesn't provide a general proxy resolution interface. It should be renamed to reflect that. Probably to pac_executor as suggested by mmenke@.
,
May 25 2018
Probably best to give eroman a chance to weigh in on naming before writing a CL.
,
May 30 2018
The current name seems OK to me. The interface is pretty close to https://chromium.googlesource.com/chromium/src/+/master/net/proxy_resolution/proxy_resolver.h, but with some extra dependencies used specifically for running PAC. Given that a "proxy resolver" is already a well established term in the codebase, I would say it is better to keep close to that than to use new nomenclature like "pac executor". If we really wanted to clarify, could call it PacProxyResolver to emphasize that it is a for PAC. Or keep it as ProxyResolver, but rename the dependencies to include the word PAC in them.
,
May 30 2018
Note that external consumers will need an API to map a GURL to a proxy...I'd call that "proxy resolution". Also, "ProxyResolutionService" vs "ProxyResolver" seems very non-intuitive naming. One would think they do the same thing.
,
Jul 24
|
|||
►
Sign in to add a comment |
|||
Comment 1 by xunji...@chromium.org
, May 25 2018