New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846724 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Feature



Sign in to add a comment

Improvements on the initial behavior for AEC3

Project Member Reported by peah@chromium.org, May 25 2018

Issue description

The nearend speaker can be muted for a short period of time at the beginning of a call when the echo canceler has not yet converged. 

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/dd0928751459b7890afeb11060e6a76ce8f3f071

commit dd0928751459b7890afeb11060e6a76ce8f3f071
Author: Jesús de Vicente Peña <devicentepena@webrtc.org>
Date: Fri May 25 15:49:38 2018

AEC3: Gain limiter: Improving the behavior of the gain limiter.

In this work, we change the behavior of the gain limiter so it also looks at the energy
 on farend around the default delay for deciding the suppression gain
that should be applied at the initial portion of the call.

Bug:  webrtc:9311 , chromium:846724 
Change-Id: I0b777cedbbd7fd689e72070f72237296ce120d3c
Reviewed-on: https://webrtc-review.googlesource.com/78960
Reviewed-by: Per Åhgren <peah@webrtc.org>
Commit-Queue: Jesus de Vicente Pena <devicentepena@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23400}
[modify] https://crrev.com/dd0928751459b7890afeb11060e6a76ce8f3f071/api/audio/echo_canceller3_config.cc
[modify] https://crrev.com/dd0928751459b7890afeb11060e6a76ce8f3f071/api/audio/echo_canceller3_config.h
[modify] https://crrev.com/dd0928751459b7890afeb11060e6a76ce8f3f071/modules/audio_processing/aec3/aec_state.cc
[modify] https://crrev.com/dd0928751459b7890afeb11060e6a76ce8f3f071/modules/audio_processing/aec3/aec_state.h
[modify] https://crrev.com/dd0928751459b7890afeb11060e6a76ce8f3f071/modules/audio_processing/aec3/residual_echo_estimator.cc
[modify] https://crrev.com/dd0928751459b7890afeb11060e6a76ce8f3f071/modules/audio_processing/aec3/residual_echo_estimator.h
[modify] https://crrev.com/dd0928751459b7890afeb11060e6a76ce8f3f071/modules/audio_processing/aec3/suppression_gain_limiter.cc
[modify] https://crrev.com/dd0928751459b7890afeb11060e6a76ce8f3f071/modules/audio_processing/aec3/suppression_gain_limiter.h
[modify] https://crrev.com/dd0928751459b7890afeb11060e6a76ce8f3f071/modules/audio_processing/aec3/vector_buffer.h
[modify] https://crrev.com/dd0928751459b7890afeb11060e6a76ce8f3f071/modules/audio_processing/test/audio_processing_simulator.cc

Project Member

Comment 2 by bugdroid1@chromium.org, May 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d981f1898a06b013204ece2ffec8500a1abcb09

commit 4d981f1898a06b013204ece2ffec8500a1abcb09
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon May 28 11:18:19 2018

Roll src/third_party/webrtc/ d7a076cc8..b3085b288 (3 commits)

https://webrtc.googlesource.com/src.git/+log/d7a076cc8e3f..b3085b288b17

$ git log d7a076cc8..b3085b288 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG= chromium:846724 


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ia387c7487ea4137de4ccd0b30bd80580b6cb19bb
Reviewed-on: https://chromium-review.googlesource.com/1074451
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#562232}
[modify] https://crrev.com/4d981f1898a06b013204ece2ffec8500a1abcb09/DEPS

Is this finished?
Labels: -Type-Bug Type-Feature
Status: Fixed (was: Assigned)

Sign in to add a comment