New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846720 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 845511
issue 845555



Sign in to add a comment

Telemetry tests failing with "This page uses too much memory, so Chrome paused it" error

Project Member Reported by sullivan@google.com, May 25 2018

Issue description

In  bug 845555 , two blink_perf.bindings tests are failing with this error. Screenshots:
https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/91bee880-5dbd-11e8-87e7-0242ac110005
https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/96c57a42-5dbd-11e8-87e7-0242ac110005

In  bug 845511 , dromaeo modify test is failing with the same error. Screenshot:
https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/742ee054-5d9f-11e8-acf1-0242ac110008

The build broke between r560427-r540432 so this is hard to narrow down, but I noticed r540430 is in that range and it changes the thresholds for OOM intervention. Sid, any ideas if that could be related? Or see anything in the range that could cause OOMs to start happening?
 
Cc: perezju@chromium.org mariakho...@chromium.org
I was thinking that we should "--supress-memory-intervention" flag to Telemetry. But wonder whether that just delay the problem of OOM. 

Comment 2 by ssid@chromium.org, May 25 2018

Owner: ssid@chromium.org
Sorry I forgot to update the test finch json file in chrome. This caused wrong intervention to b enabled on tests. I will fix the config. The cl was reverted.

Comment 3 by ssid@chromium.org, May 25 2018

Status: Fixed (was: Untriaged)
Re #1: I do not think the pages would trigger intervention. If you see this problem again after the config is fixed, let's think about adding flag.
To clarify, I should re-enable the test cases for the blocking bugs?

Comment 5 by ssid@chromium.org, May 30 2018

Status: Available (was: Fixed)
I am sorry, was any tests disabled because of this issue?
This issue should no longer show up and was caused by a mistake in CL which was reverted the next day:
https://chromium-review.googlesource.com/c/chromium/src/+/1069567

Please re-enable any test that was disabled.
Status: Fixed (was: Available)
Sent reverts of test disables to the CQ.
Project Member

Comment 7 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68e9e68a28a07b35f63ce23485feefefeb5541e7

commit 68e9e68a28a07b35f63ce23485feefefeb5541e7
Author: Annie Sullivan <sullivan@chromium.org>
Date: Wed May 30 18:00:46 2018

Revert "Disable failing dromaeo modify benchmark on Nexus 5X."

This reverts commit e4fe92c0fd2538d87f738f1d5cd3bc8dedd11427.

Reason for revert: The memory issues should be fixed per  crbug.com/846720 

Bug:  846720 ,  845511 

Original change's description:
> Disable failing dromaeo modify benchmark on Nexus 5X.
> 
> Bug:  845511 
> Change-Id: Id4e81ee812e4f2e3005b0d1f8392bd01be6e340d
> TBR: charliea@chromium.org
> NOTRY: true
> Reviewed-on: https://chromium-review.googlesource.com/1069123
> Reviewed-by: Annie Sullivan <sullivan@chromium.org>
> Commit-Queue: Annie Sullivan <sullivan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560606}

TBR=sullivan@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  845511 
Change-Id: Iab5dd9abfdad3f235335e52cd5caa24dfa25e6b8
Reviewed-on: https://chromium-review.googlesource.com/1079088
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562908}
[modify] https://crrev.com/68e9e68a28a07b35f63ce23485feefefeb5541e7/tools/perf/expectations.config

Project Member

Comment 8 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e230397109e3d49b3f68664a6552df7e8ace9c58

commit e230397109e3d49b3f68664a6552df7e8ace9c58
Author: Annie Sullivan <sullivan@chromium.org>
Date: Wed May 30 18:08:17 2018

Revert "Disable failing blink_perf.bindings stories on Nexus 5X."

This reverts commit 44f61c439253aa1ec2a11d298c832e2210eabe5c.

Reason for revert: This should be fixed per comments in  bug 846720 .

Bug:  846720 ,  845555 

Original change's description:
> Disable failing blink_perf.bindings stories on Nexus 5X.
> 
> Bug:  845555 
> Change-Id: I029cf1f8e916b41febc69824d637a459c0d38921
> TBR: charliea@chromium.org
> NOTRY: true
> Reviewed-on: https://chromium-review.googlesource.com/1069313
> Reviewed-by: Annie Sullivan <sullivan@chromium.org>
> Commit-Queue: Annie Sullivan <sullivan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560703}

TBR=sullivan@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  845555 
Change-Id: If858136272d96640f192a87a28bd62681ee6d33d
Reviewed-on: https://chromium-review.googlesource.com/1079089
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562914}
[modify] https://crrev.com/e230397109e3d49b3f68664a6552df7e8ace9c58/tools/perf/expectations.config

Sign in to add a comment