The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6084538725786a456c42c5b2acf316b0c26cf18d

commit 6084538725786a456c42c5b2acf316b0c26cf18d
Author: Olga Sharonova <olka@chromium.org>
Date: Fri May 25 13:50:38 2018

Updating composited-animation-independent-transform-cancel.html expectations.

Crashes/Fails.

Bug:846693

NOTRY=true
TBR=sky@chromium.org

Change-Id: I73715824038690d32d0ae047430cbabdf79280a7
Reviewed-on: https://chromium-review.googlesource.com/1073454
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561852}
[modify] https://crrev.com/6084538725786a456c42c5b2acf316b0c26cf18d/third_party/WebKit/LayoutTests/TestExpectations

This looks like some sort of Mac GPU bug, not sure how we're causing it to occur. The test actually passes in some cases, then there are a few GPU related error messages but no clear crash:

https://test-results.appspot.com/data/layout_results/Mac10_10_Tests/32603/layout-test-results/results.html

crash log for gpu (pid <unknown>):
STDOUT: This is a testharness.js-based test.
STDOUT: PASS Compositor Animation on transform is cancelled by transform
STDOUT: PASS Compositor Animation on transform is cancelled by translate
STDOUT: PASS Compositor Animation on transform is cancelled by rotate
STDOUT: PASS Compositor Animation on transform is cancelled by scale
STDOUT: PASS Compositor Animation on translate is cancelled by transform
STDOUT: PASS Compositor Animation on translate is cancelled by rotate
STDOUT: PASS Compositor Animation on translate is cancelled by scale
STDOUT: PASS Compositor Animation on translate is cancelled by translate
STDOUT: PASS Compositor Animation on rotate is cancelled by transform
STDOUT: PASS Compositor Animation on rotate is cancelled by rotate
STDOUT: PASS Compositor Animation on rotate is cancelled by scale
STDOUT: PASS Compositor Animation on rotate is cancelled by translate
STDOUT: PASS Compositor Animation on scale is cancelled by transform
STDOUT: PASS Compositor Animation on scale is cancelled by rotate
STDOUT: PASS Compositor Animation on scale is cancelled by scale
STDOUT: PASS Compositor Animation on scale is cancelled by translate
STDOUT: PASS Compositor Animation on opacity is not cancelled by transform
STDOUT: PASS Compositor Animation on opacity is not cancelled by translate
STDOUT: PASS Compositor Animation on opacity is not cancelled by rotate
STDOUT: PASS Compositor Animation on opacity is not cancelled by scale
STDOUT: Harness: the test ran to completion.
STDOUT: 
STDERR: [03:16:32.027] vtDecompressionDuctCreate signalled err=-8973 (err) (Could not select and open decoder instance) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.240/Sources/VideoToolbox/VTDecompressionSession.c line 1181
STDERR: <<<< VTVideoEncoderSelection >>>> VTSelectAndCreateVideoEncoderInstanceInternal: no video encoder found for 'avc1'
STDERR: 
STDERR: [03:16:32.144] VTSelectAndCreateVideoEncoderInstanceInternal signalled err=-12908 (err) (Video encoder not available) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.240/Sources/VideoToolbox/VTVideoEncoderSelection.c line 1245
STDERR: [03:16:32.144] VTCompressionSessionCreate signalled err=-12908 (err) (Could not select and open encoder instance) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.240/Sources/VideoToolbox/VTCompressionSession.c line 946
STDERR: Received signal 11 SEGV_MAPERR 00011e8d5f00


https://test-results.appspot.com/data/layout_results/Mac10_12_Tests/13307/layout-test-results/results.html
crash log for gpu (pid <unknown>):
STDOUT: <empty>
STDERR: Received signal 11 SEGV_MAPERR 000119bf0c00
STDERR:  [0x000107bbdaec]
STDERR:  [0x000107bbd9d1]
STDERR:  [0x7fff9382db3a]
STDERR: [end of stack trace]

So when I run virtual/threaded/animations locally on a Mac Pro, a huge number of the tests fail due to GPU crashes:

Found 801 tests; running 801, skipping 0.
Running 18 Content Shells in parallel.                                        

[32/801] virtual/threaded/animations/usecounters/animated-css-property-usecounter-for-transitions.html failed unexpectedly (gpu crashed)
[36/801] virtual/threaded/animations/stability/keyword-composition-crash.html failed unexpectedly (gpu crashed)
[37/801] virtual/threaded/animations/timing/timing-functions.html failed unexpectedly (gpu crashed)
[45/801] virtual/threaded/animations/inline-block-transform.html failed unexpectedly (gpu crashed)         
[47/801] virtual/threaded/animations/hit-testing/composited-with-hit-testing.html failed unexpectedly (gpu crashed)
[48/801] virtual/threaded/animations/custom-properties/time-type-interpolation.html failed unexpectedly (gpu crashed)
[49/801] virtual/threaded/animations/svg/svg-composition-ignores-css-composition-flag.html failed unexpectedly (gpu crashed)
[52/801] virtual/threaded/animations/responsive/animations-responsive-fontSize.html failed unexpectedly (gpu crashed)
[54/801] virtual/threaded/animations/direction-and-fill/fill-mode-multiple-keyframes.html failed unexpectedly (gpu crashed)
[56/801] virtual/threaded/animations/svg-attribute-interpolation/svg-radius-interpolation.html failed unexpectedly (gpu crashed)
[58/801] virtual/threaded/animations/responsive/interpolation/font-size-responsive.html failed unexpectedly (gpu crashed)
[61/801] virtual/threaded/animations/interpolation/calc-interpolation.html failed unexpectedly (gpu crashed)
[75/801] virtual/threaded/animations/stability/d-path-neutral-value-crash.html failed unexpectedly (gpu crashed) 
[149/801] virtual/threaded/animations/prefixed/animation-events-prefixed-02.html failed unexpectedly (test timed out, text diff)
[163/801] virtual/threaded/animations/events/negative-delay-events.html failed unexpectedly (test timed out, text diff)
[172/801] virtual/threaded/animations/svg-attribute-composition/svg-startOffset-composition-003.html failed unexpectedly (test timed out, -expected.txt was missing)
[186/801] virtual/threaded/animations/responsive/responsive-neutral-keyframes.html failed unexpectedly (gpu crashed)
[188/801] virtual/threaded/animations/web-animations/the-effect-value-of-a-keyframe-effect.html failed unexpectedly (test timed out, -expected.txt was missing)
[189/801] virtual/threaded/animations/composition/border-bottom-left-radius-composition.html failed unexpectedly (test timed out, -expected.txt was missing)
[198/801] virtual/threaded/animations/composited-animation-style-update.html failed unexpectedly (gpu crashed)
[210/801] virtual/threaded/animations/prefixed/animation-unprefixed-string.html failed unexpectedly (gpu crashed)
[211/801] virtual/threaded/animations/custom-properties/unregistered-element-animate.html failed unexpectedly (gpu crashed)
[221/801] virtual/threaded/animations/3d/replace-filling-transform.html failed unexpectedly (test timed out, -expected.txt was missing)
[230/801] virtual/threaded/animations/web-animations/KeyframeEffect-getKeyframes-correct-context.html failed unexpectedly (gpu crashed)
[254/801] virtual/threaded/animations/unsigned-underflow.html failed unexpectedly (gpu crashed)            
[266/801] virtual/threaded/animations/interpolation/svg-lighting-color-interpolation.html failed unexpectedly (gpu crashed)
[267/801] virtual/threaded/animations/svg-attribute-interpolation/svg-specularConstant-interpolation.html failed unexpectedly (gpu crashed)
[275/801] virtual/threaded/animations/timing/implicit-keyframe-with-timing-function.html failed unexpectedly (test timed out, -expected.txt was missing)
[290/801] virtual/threaded/animations/responsive/animations-responsive-assorted-lengths.html failed unexpectedly (gpu crashed)
[291/801] virtual/threaded/animations/svg-attribute-composition/svg-targetX-targetY-composition.html failed unexpectedly (gpu crashed)
[303/801] virtual/threaded/animations/prefixed/keyframes-cssom-prefixed-01.html failed unexpectedly (gpu crashed)
[313/801] virtual/threaded/animations/stability/inherit-crash.html failed unexpectedly (test timed out, text diff)
[324/801] virtual/threaded/animations/direction-and-fill/fill-mode-removed.html failed unexpectedly (test timed out, text diff)
[411/801] virtual/threaded/animations/reverse-transition-with-negative-delay.html failed unexpectedly (gpu crashed)
[525/801] virtual/threaded/animations/stability/animation-end-event-destroy-renderer.html failed unexpectedly (gpu crashed)
[561/801] virtual/threaded/animations/insert-style-dependent-animation.html failed unexpectedly (test timed out, -expected.txt was missing)
[573/801] virtual/threaded/animations/stability/animation-start-event-destroy-renderer.html failed unexpectedly (test timed out, text diff)
[586/801] virtual/threaded/animations/stability/body-removal-crash.html failed unexpectedly (gpu crashed)
[596/801] virtual/threaded/animations/stability/base-render-style-crash.html failed unexpectedly (gpu crashed)
[597/801] virtual/threaded/animations/animation-shorthand-name-order.html failed unexpectedly (test timed out, text diff)
[623/801] virtual/threaded/animations/stability/element-animate-float-crash.html failed unexpectedly (test timed out, text diff)
[624/801] virtual/threaded/animations/duplicated-keyframes-name.html failed unexpectedly (test timed out, text diff)
[650/801] virtual/threaded/animations/transitions-replay.html failed unexpectedly (test timed out, -expected.txt was missing)
[663/801] virtual/threaded/animations/animation-none-keyword.html failed unexpectedly (gpu crashed)
[688/801] virtual/threaded/animations/display-change-does-not-terminate-animation.html failed unexpectedly (test timed out, text diff)
[695/801] virtual/threaded/animations/animation-offscreen-to-onscreen.html failed unexpectedly (gpu crashed)
[704/801] virtual/threaded/animations/composited-animations-timing-function.html failed unexpectedly (gpu crashed)
[759/801] virtual/threaded/animations/transition-and-animation-1.html failed unexpectedly (test timed out, -expected.txt was missing)
[790/801] virtual/threaded/animations/animation-properties-in-keyframe-are-ignored.html failed unexpectedly (gpu crashed)
[799/801] virtual/threaded/animations/transition-and-animation-2.html failed unexpectedly (test timed out, -expected.txt was missing)

Running individual tests produces no failures, so I somewhat suspect the problem is caused or made worse by many shells running concurrently. Failures of this magnitude however don't really seem like an Animations problem, so I'm also trying to see if there's a more general "Mac GPU goes boom" bug.

I'm also noticing a large number of Mac GPU crashes for layout tests. From inspecting the bots, it looks like some shaders are failing to compile: https://cs.chromium.org/chromium/src/components/viz/service/display/shader.cc?rcl=9a5de368ec0bd69ced89ef285c062c958012c471&l=244

Thanks for noting that mcnee@ - I'm at least a little happy to see that its probably not Animations causing this. I note that a lot of tests are also being attributed to  issue 726075  (owned by sugoi@ who was cc'd on this), I'm not sure if that relates to the shader failures you are seeing.

It is probably related, but since the tests pass individually, I don't know what the actual cause could be. As noted before, these failures seem to happen when running the tests concurrently, but I don't know the reason for that yet.

A recent change enabled using EGL on MacOS, so it definitely might enable other code paths that were previously unused/less used on MacOS. It's unlikely to be the actual cause, but it may have exposed this issue. What intrigues me is this: "(Video encoder not available)". This error comes from a system call into Core Media and seems to be correlated with the crashes.

How does Animations use Core Media and should there be some sort of system level lock when using this library? Is it the kind of thing that can only be used one at a time? (which would explain why the crashes happen when using it concurrently).

Looking at:
https://cs.chromium.org/search/?q=VTDecompressionSession
it seems to be used in only a handful of locations, always on MacOS.

I'm no expert, but it looks like VTCopyVideoEncoderList() could be used to retrieve the list of available encoders (not sure if this helps).

Adding sandersd@ for his input on this subject.

There is a VTDecompressionSession (and I believe a VTCompressionSession) created at GPU process startup time, the purpose of which is to load required libraries before the sandbox is enabled. These are expected to fail if the hardware is not capable of accelerated decode.

It is rare for log lines relating to them to be the cause of any other GPU issues. It's actually more likely for issues to arise later if they succeed, since in that case we may actually use the hardware decode path.

Of course it's always possible that some new issue is being hit. One change to VDA texture allocation was already required to correctly support the EGL transition, it's possible that there are lower-level issues.

If hardware decode is being used, then GLImageIOSurface (https://cs.chromium.org/chromium/src/ui/gl/gl_image_io_surface.mm) could be problematic, as it uses CGL operations. Possibly VTVDA needs to switch to GLImageIOSurfaceEGL.

I think the GLImageIOSurface issue shouldn't happen, since gl::GLImageIOSurface::Create() already takes care of creating a GLImageIOSurfaceEGL object when necessary:
https://cs.chromium.org/chromium/src/ui/gl/gl_image_io_surface.mm?l=189

Has anyone tried forcing "--disable-accelerated-video-decode --disable-accelerated-video-encode" while running layout tests to see if it has any effect on the failures?

I'll try it as soon as I have some time, hopefully tomorrow.

The suggestion in #12 doesn't immediately appear to make a difference. This is running using a Chrome build from approximately 1 week ago.

Command line: /Users/smcgruer/chromium/src/out/Release/Content Shell.app/Contents/MacOS/Content Shell --disable-accelerated-video-decode --disable-accelerated-video-encode --run-web-tests --ignore-certificate-errors-spki-list=Nxvaj3+bY3oVrTc+Jp7m3E3sB1n3lXtnMDCyBsqEXiY= --user-data-dir -

Manifest not found at /Users/smcgruer/chromium/src/third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json. See  http://crbug.com/698294 
Found 801 tests; running 801, skipping 0.
Running 18 Content Shells in parallel.                                        

[31/801] virtual/threaded/animations/hit-testing/composited-with-hit-testing.html failed unexpectedly (gpu crashed)
[41/801] virtual/threaded/animations/stability/webkit-filter-default-arg-crash.html failed unexpectedly (gpu crashed)
[42/801] virtual/threaded/animations/prefixed/duplicated-keyframes-name-unprefixed-03.html failed unexpectedly (gpu crashed)
[48/801] virtual/threaded/animations/custom-properties/registered-var-to-unregistered-animating.html failed unexpectedly (gpu crashed)
[59/801] virtual/threaded/animations/direction-and-fill/animation-direction-reverse-timing-functions-hardware.html failed unexpectedly (gpu crashed)
[66/801] virtual/threaded/animations/timing/translate-neutral-keyframe-easing.html failed unexpectedly (gpu crashed)
[68/801] virtual/threaded/animations/usecounters/animated-css-property-usecounter-for-transitions.html failed unexpectedly (gpu crashed)
[71/801] virtual/threaded/animations/3d/replace-filling-transform.html failed unexpectedly (gpu crashed)
[72/801] virtual/threaded/animations/responsive/interpolation/border-image-outset-responsive.html failed unexpectedly (gpu crashed)
[75/801] virtual/threaded/animations/composition/right-composition.html failed unexpectedly (gpu crashed)
[79/801] virtual/threaded/animations/transition-and-animation-3.html failed unexpectedly (gpu crashed)
[80/801] virtual/threaded/animations/svg-attribute-composition/svg-patternTransform-composition.html failed unexpectedly (gpu crashed)
[81/801] virtual/threaded/animations/svg/animated-filter-svg-element.html failed unexpectedly (gpu crashed)
[88/801] virtual/threaded/animations/stability/animation-iteration-event-destroy-renderer.html failed unexpectedly (gpu crashed)
[112/801] virtual/threaded/animations/responsive/animations-responsive-borderWidth.html failed unexpectedly (gpu crashed)
[118/801] virtual/threaded/animations/transition-and-animation-1.html failed unexpectedly (gpu crashed)
[124/801] virtual/threaded/animations/direction-and-fill/fill-mode-missing-from-to-keyframes.html failed unexpectedly (gpu crashed)
[157/801] virtual/threaded/animations/events/negative-delay-events.html failed unexpectedly (test timed out, text diff)
[167/801] virtual/threaded/animations/svg-attribute-interpolation/svg-specularConstant-interpolation.html failed unexpectedly (test timed out, -expected.txt was missing)
[178/801] virtual/threaded/animations/interpolation/column-gap-interpolation.html failed unexpectedly (test timed out, -expected.txt was missing)
[183/801] virtual/threaded/animations/stability/d-path-neutral-value-crash.html failed unexpectedly (gpu crashed)
[240/801] virtual/threaded/animations/events/animation-end-event-short-iterations.html failed unexpectedly (gpu crashed)
[316/801] virtual/threaded/animations/timing/delay-timer-cancel-bug.html failed unexpectedly (test timed out, -expected.txt was missing)
[338/801] virtual/threaded/animations/prefixed/animation-events-prefixed-03.html failed unexpectedly (test timed out, text diff)
[398/801] virtual/threaded/animations/keyframes-style-declaration-updates-animation.html failed unexpectedly (test timed out, -expected.txt was missing)
[453/801] virtual/threaded/animations/stability/empty-keyframes.html failed unexpectedly (test timed out, text diff)
[559/801] virtual/threaded/animations/composited-animations-translate-rotate-scale.html failed unexpectedly (gpu crashed)
[572/801] virtual/threaded/animations/stability/animation-add-events-in-handler.html failed unexpectedly (test timed out, text diff)
[583/801] virtual/threaded/animations/stability/zero-duration-large-start-delay.html failed unexpectedly (gpu crashed)
[603/801] virtual/threaded/animations/transform-post-multiplication.html failed unexpectedly (test timed out, -expected.txt was missing)
[627/801] virtual/threaded/animations/rotate-transform-equivalent.html failed unexpectedly (gpu crashed) 
[647/801] virtual/threaded/animations/cross-fade-background-image.html failed unexpectedly (test timed out, -expected.txt was missing)
[682/801] virtual/threaded/animations/duplicated-keyframes-name.html failed unexpectedly (gpu crashed)
[691/801] virtual/threaded/animations/missing-values-first-keyframe.html failed unexpectedly (gpu crashed)
[698/801] virtual/threaded/animations/animation-shorthand-overriding.html failed unexpectedly (gpu crashed)
[752/801] virtual/threaded/animations/import.html failed unexpectedly (test timed out, text diff)

This is a serious regression, causing dozens of tests to crash on OSX. Looking at  issue 726075 , and making the assumption that they are related, the scope isn't just the animations tests.

Are we considering a revert of the changes from  issue 726075 ? The fact that we don't understand why parallel execution is crashing the GPU is very scary to me - it feels like something that could definitely have real-world impact on anyone running multiple instances of Chrome?

Note: I tried reverting e889dc7e14b1c884521782832c2f8e214a3056e3, and that didn't seem to solve the issues seen in #5, #13 (still many GPU crashes when running 18 concurrent content_shells for the web_tests.py). It was a bit of a guess as to what CL to revert so perhaps that was not the correct one, but just wanted to add that information.

1) Reverting is not an option, unfortunately, we have to move forward with this and figure out whatever's wrong with the current setup. I'll investigate this today.
2) We landed a SwiftShader DEPS roll yesterday which greatly reduced the number of flaky failures in virtual/gpu-rasterization/images. It doesn't seem to affect this issue, though, but it should make it easier (reduced flakiness) to rebase the tests once we find the source of the issue.

Adding weiliangc@ to the thread for this question:
I'm seeing a lot of "Reached limit of pending sync queries." errors. Is that a benign warning or is this possibly related to the issue?

Hmmm... It seems forcing "targetRequiresSync" to true in Renderer::draw in SwiftShader solves this issue. That's a potential performance hit, though. I'll try to find which specific use case requires some synchronization to minimize the performance hit.

A fix is coming:
https://swiftshader-review.googlesource.com/c/SwiftShader/+/19288

If anyone's interested in the details, it seems like locking an IOSurface is more of a suggestion than an actual lock. Whenever SwiftShader renders something which includes an IOSurface backed texture (either as render target or sampler input), SwiftShader must complete the rendering synchronously (i.e. complete the rendering before yielding to Chromium, as opposed to queuing draw calls, which SwiftShader usually does), otherwise it appears that the IOSurface's memory can become no longer valid before SwiftShader is done rendering, causing the crashes.

We may try to figure out why IOSurfaces have such a flimsy locking mechanism at some point, but for now, we'll land this fix and hope it fixes the remaining crashes/flakiness on MacOS.

The following revision refers to this bug:
  https://swiftshader.googlesource.com/SwiftShader.git/+/88482c3ca96642733b3a4cc3566b7e2d1b5f8025

commit 88482c3ca96642733b3a4cc3566b7e2d1b5f8025
Author: Alexis Hetu <sugoi@google.com>
Date: Tue Jun 05 21:27:32 2018

Fix IOSurface synchronization issues

It appears that not only render targets, but also samplers that use
IOSurfaces require SwiftShader to perform synchronized draws,
otherwise it seems like using a shared IOSurface's CPU memory is
unsafe and can cause crashes in Layout Tests.

 Bug chromium:846693 

Change-Id: I0ce24700d34c657ac2447ceb2f6f837bfa3a9a58
Reviewed-on: https://swiftshader-review.googlesource.com/19288
Tested-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

[modify] https://crrev.com/88482c3ca96642733b3a4cc3566b7e2d1b5f8025/src/OpenGL/common/Image.cpp
[modify] https://crrev.com/88482c3ca96642733b3a4cc3566b7e2d1b5f8025/src/OpenGL/common/Image.hpp
[modify] https://crrev.com/88482c3ca96642733b3a4cc3566b7e2d1b5f8025/src/OpenGL/libGLESv2/Context.cpp
[modify] https://crrev.com/88482c3ca96642733b3a4cc3566b7e2d1b5f8025/src/OpenGL/libGLESv2/Texture.cpp
[modify] https://crrev.com/88482c3ca96642733b3a4cc3566b7e2d1b5f8025/src/OpenGL/libGLESv2/Texture.h
[modify] https://crrev.com/88482c3ca96642733b3a4cc3566b7e2d1b5f8025/src/Renderer/PixelProcessor.cpp
[modify] https://crrev.com/88482c3ca96642733b3a4cc3566b7e2d1b5f8025/src/Renderer/PixelProcessor.hpp
[modify] https://crrev.com/88482c3ca96642733b3a4cc3566b7e2d1b5f8025/src/Renderer/Renderer.cpp
[modify] https://crrev.com/88482c3ca96642733b3a4cc3566b7e2d1b5f8025/src/Renderer/Renderer.hpp
[modify] https://crrev.com/88482c3ca96642733b3a4cc3566b7e2d1b5f8025/src/Renderer/Sampler.cpp
[modify] https://crrev.com/88482c3ca96642733b3a4cc3566b7e2d1b5f8025/src/Renderer/Sampler.hpp
[modify] https://crrev.com/88482c3ca96642733b3a4cc3566b7e2d1b5f8025/src/Renderer/Surface.hpp
[modify] https://crrev.com/88482c3ca96642733b3a4cc3566b7e2d1b5f8025/src/Renderer/VertexProcessor.cpp
[modify] https://crrev.com/88482c3ca96642733b3a4cc3566b7e2d1b5f8025/src/Renderer/VertexProcessor.hpp

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06f66cde750e1f388e19a0390214bb988eed1768

commit 06f66cde750e1f388e19a0390214bb988eed1768
Author: Alexis Hetu <sugoi@google.com>
Date: Wed Jun 06 01:08:17 2018

Roll SwiftShader 57776df..88482c3

https://swiftshader.googlesource.com/SwiftShader.git/+log/57776df..88482c3

BUG= chromium:849217   chromium:846693 

TBR=kbr@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel

Change-Id: Ifd196a7e538ee5280f3af78db9e95913ad8365ac
Reviewed-on: https://chromium-review.googlesource.com/1087786
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564756}
[modify] https://crrev.com/06f66cde750e1f388e19a0390214bb988eed1768/DEPS

Wow, thanks for the fast turn-around on a fix sugoi@. Really appreciated.

Let me just keep this bug open to track the fact that the test is still disabled (I assume); once we know if its turned stable again I'll own re-enabling it (since its animations).

Dropping to P3 bug since the actual problem is likely fixed.

From https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=composited-animation-independent-transform-cancel.html it looks like #20 was the fix we needed, so I'm going to re-enable this test (and others in virtual/threaded/animation if they look related).

I'm already in the process of re-enabling these test here:
https://chromium-review.googlesource.com/c/chromium/src/+/1088197

You are my favorite person :)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/836dc8d422d51a671d1da96d996244fefbd71d24

commit 836dc8d422d51a671d1da96d996244fefbd71d24
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Mon Jun 11 15:17:28 2018

Re-enable some disabled MacOS Layout Tests

These appear to be no longer crashing now that the surfance
synchronization bug has been fixed on MacOS.

Bug:  846632 ,  846693 
Change-Id: I4ecc748429a6a19d565d88d84db9ad1427a6af48
Reviewed-on: https://chromium-review.googlesource.com/1094978
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566002}
[modify] https://crrev.com/836dc8d422d51a671d1da96d996244fefbd71d24/third_party/WebKit/LayoutTests/TestExpectations