org.chromium.chrome.browser.vr_shell.WebVrInputTest#testFocusUpdatesSynchronously are failing on Nougat Phone Tester |
|||||||
Issue descriptionWebVrInputTest#testFocusUpdatesSynchronously__ChromeTabbedActivity, WebVrInputTest#testFocusUpdatesSynchronously__CustomTabActivity and WebVrInputTest#testFocusUpdatesSynchronously__WebappActivity are failing consistently, I'll disable them. The first failed build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Nougat%20Phone%20Tester/6382 java.lang.RuntimeException: Exception occurred while waiting for runnable at org.chromium.base.ThreadUtils.runOnUiThreadBlocking(ThreadUtils.java:81) at org.chromium.chrome.browser.vr_shell.WebVrInputTest.testFocusUpdatesSynchronously(WebVrInputTest.java:580) at java.lang.reflect.Method.invoke(Native Method) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52) at org.chromium.base.test.params.ParameterizedFrameworkMethod.invokeExplosively(ParameterizedFrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37) at org.chromium.chrome.browser.vr_shell.rules.CustomTabActivityVrTestRule$1.evaluate(CustomTabActivityVrTestRule.java:36) at org.chromium.chrome.test.ChromeActivityTestRule$1.evaluate(ChromeActivityTestRule.java:115) at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55) at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270) at org.junit.rules.RunRules.evaluate(RunRules.java:20) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:202) at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:44) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:184) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:27) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:27) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at org.junit.runner.JUnitCore.run(JUnitCore.java:115) at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59) at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262) at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:122) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1932) Caused by: java.util.concurrent.ExecutionException: java.lang.AssertionError at java.util.concurrent.FutureTask.report(FutureTask.java:94) at java.util.concurrent.FutureTask.get(FutureTask.java:164) at org.chromium.base.ThreadUtils.runOnUiThreadBlocking(ThreadUtils.java:79) ... 47 more Caused by: java.lang.AssertionError at org.junit.Assert.fail(Assert.java:86) at org.junit.Assert.assertTrue(Assert.java:41) at org.junit.Assert.assertFalse(Assert.java:64) at org.junit.Assert.assertFalse(Assert.java:74) at org.chromium.chrome.browser.vr_shell.WebVrInputTest$9.run(WebVrInputTest.java:585) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:428) at java.util.concurrent.FutureTask.run(FutureTask.java:237) at android.os.Handler.handleCallback(Handler.java:751) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:154) at android.app.ActivityThread.main(ActivityThread.java:6119) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776) I suspect this change to be a culprit but I wasn't able to run these tests to confirm it: https://chromium-review.googlesource.com/c/chromium/src/+/1060637
,
May 25 2018
Bill, your change is a pretty likely suspect, mind triaging?
,
May 25 2018
If this ends up being a complicated fix, we might want to revert on the 68 branch and fix for 69. That test failing means we probably have bugs that will break headset insertion racily.
,
May 26 2018
Didn't notice this till now - looking.
,
May 26 2018
Looks like we are still listening for activation after a pause. Still looking, but I don't think this breaks headset insertion. It may allow a backgrounded page to activate though. Continuing to investigate.
,
May 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5345e319f856fc5f0421d4f8e78860748061e4a5 commit 5345e319f856fc5f0421d4f8e78860748061e4a5 Author: Bill Orr <billorr@chromium.org> Date: Mon May 28 17:15:52 2018 Fix a focus issue for VR headset activation. The bug here is that we aren't updating whether to listen for headset activation when focus changes. BUG= 846661 Change-Id: I029099a6de8b8337d51aa210ad58165fbd01a050 Reviewed-on: https://chromium-review.googlesource.com/1074742 Reviewed-by: Bill Orr <billorr@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#562282} [modify] https://crrev.com/5345e319f856fc5f0421d4f8e78860748061e4a5/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrInputTest.java [modify] https://crrev.com/5345e319f856fc5f0421d4f8e78860748061e4a5/chrome/browser/vr/service/vr_display_host.cc
,
May 29 2018
Looks like the tests are passing fine now after being re-enabled?
,
May 29 2018
,
May 30 2018
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e9c95fdc0e6345efe37deba90e05c2b4c933335 commit 8e9c95fdc0e6345efe37deba90e05c2b4c933335 Author: Bill Orr <billorr@chromium.org> Date: Wed May 30 20:09:00 2018 Fix a focus issue for VR headset activation. The bug here is that we aren't updating whether to listen for headset activation when focus changes. BUG= 846661 Change-Id: I029099a6de8b8337d51aa210ad58165fbd01a050 Reviewed-on: https://chromium-review.googlesource.com/1074742 Reviewed-by: Bill Orr <billorr@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#562282}(cherry picked from commit 5345e319f856fc5f0421d4f8e78860748061e4a5) Reviewed-on: https://chromium-review.googlesource.com/1079795 Cr-Commit-Position: refs/branch-heads/3440@{#49} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/8e9c95fdc0e6345efe37deba90e05c2b4c933335/chrome/browser/vr/service/vr_display_host.cc
,
Jul 4
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, May 25 2018