Issue metadata
Sign in to add a comment
|
Source maps not getting applied
Reported by
gautham....@gmail.com,
May 25 2018
|
||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36 Steps to reproduce the problem: The files to reproduce this issue can be found here - https://gist.github.com/GauthamBanasandra/fe9094919da22f207dc07bea264d5e79 (Assuming node.js has been installed) 1. node --inspect-brk input1.t.js 2. Copy the ws URL and open in Chrome browser. 3. We can see that the source map is detected but not applied. What is the expected behavior? We should see only the contents of input1.js in devtools. But we actually see the contents of input1.t.js What went wrong? I have found this work properly in Chromium version - 63.0.3239.0 Did this work before? Yes Chromium version - 63.0.3239.0 Chrome version: 66.0.3359.181 Channel: stable OS Version: OS X 10.12.6 Flash Version:
,
Jun 9 2018
@dgozman , @eostrukhov I would like to work on this bug. Could you please assign this to me? I'm very close to fixing this.
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7efc442c8dc9108f057144983987e74ddc6a0d4 commit f7efc442c8dc9108f057144983987e74ddc6a0d4 Author: GauthamBanasandra <gautham.bangalore@gmail.com> Date: Tue Jun 19 18:30:57 2018 DevTools: Enable JS Capability for inspector_main Presently, the isNodeJS() method uses '===' operator which evaluates to true only for JS Capability. This check fails for inspector_main target as multiple capabilities are set for it. As a result, source maps doesn't get applied for inspector_main because the isNodeJS() check fails and prevents prefixing of "file://" to sourceMapURL as a consequence, leading to the source maps resource not being served. In this patch, we set only the JS Capability for inspector_main if the 'v8only' parameter in the URL is set to true. Bug: 846642 Change-Id: I96a01f3b984bf552c89c873d10f3bf0b5ecd67c8 Reviewed-on: https://chromium-review.googlesource.com/1095064 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#568539} [modify] https://crrev.com/f7efc442c8dc9108f057144983987e74ddc6a0d4/AUTHORS [modify] https://crrev.com/f7efc442c8dc9108f057144983987e74ddc6a0d4/third_party/blink/renderer/devtools/front_end/inspector_main/InspectorMain.js
,
Oct 12
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by dgozman@chromium.org
, May 25 2018Owner: eostroukhov@chromium.org
Status: Assigned (was: Unconfirmed)