I believe this previously worked as intended in 68.0.3431.0.

+omrilio I am seeing this too, touch Chrome issue?

I should revise my previous comment and note that this appears to just break the omnibox text input period once you touch an arrow key.  This makes moving forward/backward to edit a query also produce the same result of being bumped out of the omnibox.

Also on Pixelbook 68.0.3437.0 (Official Build) dev (64-bit)

This seems minor enough it can wait for beta, and it is already live on dev.

I would disagree that this is a "minor" accessibility regression. 

For dev if it does not break the regular workflow to the point a typical dev user would consider moving off of dev it can be considered minor as a rule of thumb, this is not to say we don't want to fix it or anything. In this case there is even less reason to hold dev since this was discovered on a version that is already live on dev, so it is too late to prevent. 

We can hold beta on this but we do need to get a fix in soon, we hope to promote to beta next week. 

Does this breakage appear to be ChromeOS only?

yes


*Wes Hewatt*

whewatt@google.com

Cloud Customer Engineer

M: 678.756.3820

Does this still reproduce on Canary? 

This bug seems very similar to 849175 which I can no longer reproduce.

Nope.  Last update seemed to fix it.


*Wes Hewatt*

whewatt@google.com

Cloud Customer Engineer

M: 678.756.3820

Great, thanks. 

[Auto-generated comment by a script] We noticed that this issue is targeted for M-68; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-68 label, otherwise remove Merge-TBD label. Thanks.

I had initially thought this was resolved, however, I am now able to replicate the behavior (though it seems flaky) on 68.0.3440.15 dev again.  Same steps to reproduce, however, as I mention, the issue appeared again only after some uptime.

We cannot afford to hold beta on this any further, punting to stable. 

 Issue 852870  has been merged into this issue.

Merged-in bug reports, in addition to the down arrow, the left and right arrows also don't work well.

I'm having trouble reproducing. Can anyone provide a screenshot?

Has anyone been able to reproduce this behavior on anything other than ChromeOS?

I see it all the time on cros but never saw it on Linux.

Jean-Marc

I also see this all the time, most frequently when I arrow right to move the cursor to the end of the selected completion. I don't think I have ever seen this actually work on ChromeOS since it stopped working correctly.

Currently I am on Dev channel at 68.0.3440.15.

And I just got the update to 68.0.3440.25 where I can no longer reproduce this issue.

Still happens to me with 68.0.3440.25.

Jean-Marc

Fixed on 69.0.3464.0

I'm still seeing the same issue on Pixelbook, dev 69.0.3464.0

Agreed, doesn't seem to be fixed.

Seeing this on Chromebook Pixel LS running Version 68.0.3440.25 (Official Build) beta (64-bit).

Seeing this intermittently on 69.0.3464.0 (Official Build) dev (64-bit) on Chell and on M68 before that. I was not able to find a way to reliably reproduce this, but only session restart helps once the browser gets into a bad state.

And a reboot fixed the issue.

Problem came back within an hour of rebooting 

I think I have found a way of reliably reproducing this issue with 69.0.3464.0 (Official Build) dev (64-bit) on Pixelbook. It occurs when you push the power button briefly and gets resolved if you push the power button again. Essentially toggling the power button would trigger the bug.

hcindyl: Wow that is extremely reliable repro - and very fascinating that the power button seems to turn the bug on and off like a binary toggle.

Can we get someone from ChromeOS Ash to weigh in?

I've done a lot of investigation on this and haven't really gotten anywhere -- but the power button is a lead that the problem could be related to window management on ChromeOS.

hcindyl that's great ! Power button toggles such behaviour. I'm on 68.0.3440.25 (Official Build) beta (64-bit) on Lenovo Chromebook 13

 Issue 854344  has been merged into this issue.

Morphing summary to made bad behaviors clear:
* up/down does not select results
* left/right makes the omnibox lose focus

From the video, I thought the symptom was that up/down did select the results (the Omnibox is getting updated) but that the drop down simply didn't update.

Up/down were causing my dropdown to close.

Bad in any case.  Hopefully with a consistent repro (great find hcindyl!) we can track this down.

Justin, I hope it's OK if I stick this in your queue to officially find someone to tackle?

I can repro this even with MD Refresh OFF. So it's not MD Refresh specific. The power button toggling the bug on and off seems to be an extremely key hint.

It briefly shows an overlay on ChromeOS when you press the power button.

This bug used to be assigned to me but I unassigned it in hopes someone from Ash would comment.

Kevin and I have been working on this during today afternoon.

We noticed that pressing the Power button (for at least a second) opens the shutdown overlay and the overlay captures the arrow keys for keyboard accessibility.

But it only captures the arrow keys EVERY OTHER TIME.

And the Omnibox popup only breaks EVERY OTHER TIME as well.

The two must be related.

This bug also seems to effect the Lock Screen of ChromeOS as well.

1. Lock your Chromebook. You should be on the Lock screen now.

2. Notice that the Arrow keys move the keyboard focus between various controls on your lock screen.

3. Press the Power button to bring up the overlay. Press some arrow keys. They DO NOT work on the shutdown overlay.

4. Dismiss the shutdown overlay.

5. Now the arrow keys don't work on the lock screen either.

6. Press the power button to bring up the shutdown overlay again. Now the arrow keys DO work on the shut down overlay.

7. Dismiss the shutdown overlay. Now the arrow keys work on the lock screen again.

omrilio: Hey, would you be able to route this bug to the ChromeOS shutdown overlay implementer? I would be curious to hear some thoughts from that person.

Routing to zork@ since omri is in Korea.

Min, could you take a look at this?  It sounds like it might be related to the power button menu.

Have some feedback reports from users (with logs) about this issue.

From users on 68.0.3440.25 beta
- http://listnr/product/208/report/85513232938
- http://listnr/product/208/report/85513214979
- http://listnr/product/208/report/85506622721


From users on 68.0.3440.34 beta
- http://listnr/product/208/report/85514846240
- http://listnr/product/208/report/85517235105

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a71ca1b7e6979ad89f6ae64c290422797df11b54

commit a71ca1b7e6979ad89f6ae64c290422797df11b54
Author: Min Chen <minch@google.com>
Date: Tue Jun 26 03:46:46 2018

Enable arrow key in PowerButtonController instead of PowerButtonMenuScreenView.

The contents view of |menu_widget_| in PowerButtonController will be updated
when showing menu, which means the destructor of PowerButtonMenuScreenView
will not be called when DismissMenu. This will cause the arrow key traversal
enabled value in FocusManager will not be restored correctly. Move the logic from
PowerbuttonMenuScreenView into PowerButtonController to make sure the value
can be restored correctly if dismiss the menu.

Bug:  846639 
Change-Id: I32ceebb8e81cf19e3fed119af0ccee3bd8c55638
Reviewed-on: https://chromium-review.googlesource.com/1114309
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570323}
[modify] https://crrev.com/a71ca1b7e6979ad89f6ae64c290422797df11b54/ash/system/power/power_button_controller.cc
[modify] https://crrev.com/a71ca1b7e6979ad89f6ae64c290422797df11b54/ash/system/power/power_button_controller.h
[modify] https://crrev.com/a71ca1b7e6979ad89f6ae64c290422797df11b54/ash/system/power/power_button_menu_screen_view.cc
[modify] https://crrev.com/a71ca1b7e6979ad89f6ae64c290422797df11b54/ash/system/power/power_button_menu_screen_view.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e043d1006c809516a2de62723bb91684ffc878ff

commit e043d1006c809516a2de62723bb91684ffc878ff
Author: Min Chen <minch@google.com>
Date: Wed Jun 27 01:19:05 2018

[Merge to M68]Enable arrow key in PowerButtonController instead of PowerButtonMenuScreenView.

TBR=minch@chromium.org

The contents view of |menu_widget_| in PowerButtonController will be updated
when showing menu, which means the destructor of PowerButtonMenuScreenView
will not be called when DismissMenu. This will cause the arrow key traversal
enabled value in FocusManager will not be restored correctly. Move the logic from
PowerbuttonMenuScreenView into PowerButtonController to make sure the value
can be restored correctly if dismiss the menu.

(cherry picked from commit a71ca1b7e6979ad89f6ae64c290422797df11b54)

Bug:  846639 
Change-Id: I32ceebb8e81cf19e3fed119af0ccee3bd8c55638
Reviewed-on: https://chromium-review.googlesource.com/1114309
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#570323}
Reviewed-on: https://chromium-review.googlesource.com/1116193
Reviewed-by: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#545}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/e043d1006c809516a2de62723bb91684ffc878ff/ash/system/power/power_button_controller.cc
[modify] https://crrev.com/e043d1006c809516a2de62723bb91684ffc878ff/ash/system/power/power_button_controller.h
[modify] https://crrev.com/e043d1006c809516a2de62723bb91684ffc878ff/ash/system/power/power_button_menu_screen_view.cc
[modify] https://crrev.com/e043d1006c809516a2de62723bb91684ffc878ff/ash/system/power/power_button_menu_screen_view.h

How / when do I receive this bugfix?
Will moving off dev channel fix it?

Re #56, the fix was landed in #51 and merged to m68 in #54. Please update your chrome to tot to see whether the bug was fixed. Thanks.

 Issue 857102  has been merged into this issue.

Issue 857118 has been merged into this issue.

 Issue 856895  has been merged into this issue.

Do we know when the fix would be available for m69 dev?

The fix was initially landed in 69.0.3474.0
Please check out a version later than that and try whether the issue is fixed. Thanks.

Thanks! The dev channel right now is at 69.0.3473.0. Will test at the next release.

 Issue 859486  has been merged into this issue.

 Issue 860405  has been merged into this issue.

 Issue 860534  has been merged into this issue.

 Issue 862142  has been merged into this issue.

Updated to 69.0.3486.0 this afternoon and I don't see the issue anymore. Thanks so much for the fix!

Not sure if it's related to this fix, but the securekey doesn't work anymore when pressing the power button;-(

Re#69: The build-in gnubby still works fine on my Pixelbook.