New issue
Advanced search Search tips

Issue 846637 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 846235



Sign in to add a comment

Fix virtual/service-worker-servicification/external/wpt/service-workers/service-worker/worker-interception-redirect.https.html

Project Member Reported by falken@chromium.org, May 25 2018

Issue description

I'm planning to reland patch https://chromium-review.googlesource.com/c/1073037/ which will break the service-worker-servicification virtual test.

Probably this is using NetworkService when S13nServiceWorker without NetworkService is on, so I'll have to fix that somehow.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7e6a5626720fc556b4159f5903780a0d364b845

commit d7e6a5626720fc556b4159f5903780a0d364b845
Author: Matt Falkenhagen <falken@chromium.org>
Date: Fri May 25 13:12:48 2018

Reland "shared worker: Give the renderer a factory bundle when NetworkService is enabled."

This relands r561423 and r561793.
Original code review: https://chromium-review.googlesource.com/1069956
Second code review: https://chromium-review.googlesource.com/1073037

This collided with the landing of the S13nSW virtual test suite. I'm relanding
with an expectation for the S13nSW failure. Probably we're using
NetworkService when S13nSW is on and NetworkService is off.

Bug:  839982 ,  846545 ,  846637 
Change-Id: Ib1c3122ee532cce56a040356433002a24edc5553
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
TBR: nhiroki, kinuko, dcheng
Reviewed-on: https://chromium-review.googlesource.com/1072991
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561844}
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/browser/shared_worker/mock_shared_worker.cc
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/browser/shared_worker/mock_shared_worker.h
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/browser/shared_worker/shared_worker_host.cc
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/browser/shared_worker/shared_worker_host.h
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/browser/shared_worker/shared_worker_host_unittest.cc
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/browser/shared_worker/shared_worker_service_impl.cc
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/browser/shared_worker/shared_worker_service_impl.h
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/common/shared_worker/shared_worker_factory.mojom
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/renderer/shared_worker/embedded_shared_worker_stub.h
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/renderer/shared_worker/shared_worker_factory_impl.cc
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/renderer/shared_worker/shared_worker_factory_impl.h
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/public/platform/DEPS
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/public/platform/platform.h
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/public/web/web_shared_worker.h
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/renderer/core/DEPS
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/renderer/core/exported/web_shared_worker_impl.h
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/renderer/core/exported/worker_shadow_page.cc
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/renderer/core/exported/worker_shadow_page.h
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/renderer/modules/DEPS
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc
[modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/tools/audit_non_blink_usage.py

Project Member

Comment 2 by bugdroid1@chromium.org, May 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2653866a102c51f59ee4ce55d04ddc26e919543

commit d2653866a102c51f59ee4ce55d04ddc26e919543
Author: Matt Falkenhagen <falken@chromium.org>
Date: Mon May 28 07:51:14 2018

shared worker: Fix default loader when S13nServiceWorker is enabled and NetworkService is disabled.

When S13nSW was enabled we were using the NetworkService, but should
not when that is disabled.

Bug:  846637 
Change-Id: If23aaf4e789c5c35f6d0bc754fec7a82b5f62898
Reviewed-on: https://chromium-review.googlesource.com/1074804
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562202}
[modify] https://crrev.com/d2653866a102c51f59ee4ce55d04ddc26e919543/content/browser/shared_worker/shared_worker_host.cc
[modify] https://crrev.com/d2653866a102c51f59ee4ce55d04ddc26e919543/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/d2653866a102c51f59ee4ce55d04ddc26e919543/third_party/WebKit/LayoutTests/TestExpectations

Comment 3 by falken@chromium.org, May 28 2018

Labels: M-69
Status: Fixed (was: Assigned)

Sign in to add a comment