New issue
Advanced search Search tips

Issue 846631 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

navigation_preload/navigation-preload-resource-timing.html is failing/flaky

Project Member Reported by olka@chromium.org, May 25 2018

Issue description

The following layout test is failing on [insert platform]

virtual/service-worker-servicification/http/tests/serviceworker/navigation_preload/navigation-preload-resource-timing.html

tests/serviceworker/navigation_preload/navigation-preload-resource-timing.html

Dashboard:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=navigation-preload-resource-timing.html

 

Comment 1 by olka@chromium.org, May 25 2018

Owner: olka@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ef224c0aff621fd94b856d346e5b7a26100a89f

commit 0ef224c0aff621fd94b856d346e5b7a26100a89f
Author: Olga Sharonova <olka@chromium.org>
Date: Fri May 25 12:32:58 2018

Updaiting navigation-preload-resource-timing.html expectations

Failing flakily.

NOTRY=true
TBR=sky@chromium.org

Bug:  846631 
Change-Id: I5378035496d8b0009c5cc024d3feb68dcccc027a
Reviewed-on: https://chromium-review.googlesource.com/1073448
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561841}
[modify] https://crrev.com/0ef224c0aff621fd94b856d346e5b7a26100a89f/third_party/WebKit/LayoutTests/TestExpectations

Comment 3 by olka@chromium.org, May 25 2018

Cc: horo@chromium.org
Labels: -Sheriff-Chromium Test-Disabled
Owner: ----
Status: Available (was: Started)

Comment 4 by npm@chromium.org, May 25 2018

Blocking: 846235
Blocking: -846235
Components: Blink>ServiceWorker
Labels: -Pri-1 Target-69 Pri-2
Confusingly we have external/wpt/navigation_preload/resource-timing.https.html which also flaky, but is a different test than this http one, so I'll open a new bug for that.

This http test is flaky even without NetworkService or S13nSW, removing the block on  846235.

This http test is testing Resource Timing of navigation preload after the service worker is terminated. That seems really edge case. I'm setting Pri-2.

Error:
FAIL Navigation Preload Resource Timing. assert_equals: performance.getEntriesByName() must returns one PerformanceResourceTiming entry for the navigation preload. expected 1 but got 0




OK we already had  issue 804682  for the external/wpt one.
horo@ you added this test, are you a good owner for this bug?
Owner: bashi@chromium.org
Status: Assigned (was: Available)
This should have the same fix as  issue 804682  fixed by bashi@.
Cc: bashi@chromium.org
Owner: falken@chromium.org
Status: Started (was: Assigned)
Picking this up during bug triage.
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c157b57df3962bfe1ee4b21ef522a8cc496ec784

commit c157b57df3962bfe1ee4b21ef522a8cc496ec784
Author: Matt Falkenhagen <falken@chromium.org>
Date: Thu Nov 29 02:31:36 2018

Deflake http test navigation-preload-resource-timing.html

This is the same fix as r583483 did for  issue 872078 . As that commit
description says: "Before this CL, this test tried to get performance
entries right after Response#text() is resolved, but Chrome doesn't
guarantee that there will be a performance entry for the response at
that point. This CL changes the test to use PerformanceObserver so that
we can make sure that there will be a performance entry for the
response."

Bug:  846631 
Change-Id: Ia8aaf82939f4457b7e2427bbefacce79150fbb20
Reviewed-on: https://chromium-review.googlesource.com/c/1353032
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611989}
[modify] https://crrev.com/c157b57df3962bfe1ee4b21ef522a8cc496ec784/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/c157b57df3962bfe1ee4b21ef522a8cc496ec784/third_party/blink/web_tests/http/tests/serviceworker/navigation_preload/navigation-preload-resource-timing.html
[modify] https://crrev.com/c157b57df3962bfe1ee4b21ef522a8cc496ec784/third_party/blink/web_tests/http/tests/serviceworker/navigation_preload/resources/navigation-preload-resource-timing-worker.js

Labels: M-72
Status: Fixed (was: Started)

Sign in to add a comment