New issue
Advanced search Search tips

Issue 846618 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 836410



Sign in to add a comment

Refactor EventQueue

Project Member Reported by hajimehoshi@chromium.org, May 25 2018

Issue description

EventQueue basically just posts a task to a task runner so we should be able to replace them with a simple task runner or timer.

Note: DOMWindowEventQueue is the last user of TaskType::kUnthrottled.

EDIT:

Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit#
 
Blocking: 836410
Cc: nhiroki@chromium.org
I realized that WorkerEventQueue doesn't use PausableTimer, while DOMWindowEventQueue uses it. Both event queues are used by IndexedDB, and I was wondering both should use PausableTimer so that events are not dispatched after inspector's breakpoint. Then, I'm trying to merge WorkerEventQueue implementation and DOMWindowEventQueue implementation to use PausableTimer before eliminating EventQueues, but I'd like to confirm if WorkerEventQueue doesn't use PausableTimer intentionally.

+nhiroki@, do you have any suggestion?

Project Member

Comment 3 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bae0afc1b2b5b295a140d1bbfb1ca4d642d4cc18

commit bae0afc1b2b5b295a140d1bbfb1ca4d642d4cc18
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Fri May 25 12:02:18 2018

De-couple MediaElementEventQueue and EventQueue

This CL also removes MediaElementEventQueue::CancelEvent, which is not
called anywhere.

This is one of the steps to eliminate EventQueue.

Bug:  846618 
Change-Id: I6e67a84d7bbd5344a5758e58d1db7be0192ac53f
Reviewed-on: https://chromium-review.googlesource.com/1072992
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561835}
[modify] https://crrev.com/bae0afc1b2b5b295a140d1bbfb1ca4d642d4cc18/third_party/blink/renderer/core/dom/events/media_element_event_queue.cc
[modify] https://crrev.com/bae0afc1b2b5b295a140d1bbfb1ca4d642d4cc18/third_party/blink/renderer/core/dom/events/media_element_event_queue.h

Components: Blink>Workers
Status: Assigned (was: Untriaged)
Merging/Removing WorkerEventQueue SGTM as long as IndexedDB etc work.
Project Member

Comment 5 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c5e85697bfc9126ad09e7435e0898e0d40dd443

commit 0c5e85697bfc9126ad09e7435e0898e0d40dd443
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed May 30 06:22:34 2018

Remove PausableTimer from MediaElementEventQueue

As the first step of refactoring EventQueue, remove PausableTimer usage
from MediaElementEventQueue.

Bug:  846618 
Change-Id: I410a4abcdc4e1626cd1b644d3bd7c0d7241d7755
Reviewed-on: https://chromium-review.googlesource.com/1075950
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562749}
[delete] https://crrev.com/32cf029fdc88c543b7d2e6a362874ca522cc7728/third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/media-elements/loading-the-media-resource/load-removes-queued-error-event-expected.txt
[modify] https://crrev.com/0c5e85697bfc9126ad09e7435e0898e0d40dd443/third_party/blink/renderer/core/dom/events/media_element_event_queue.cc
[modify] https://crrev.com/0c5e85697bfc9126ad09e7435e0898e0d40dd443/third_party/blink/renderer/core/dom/events/media_element_event_queue.h

Project Member

Comment 6 by bugdroid1@chromium.org, May 31 2018

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f493b5ee90945d728557c3a8b9d77663f9efd331

commit f493b5ee90945d728557c3a8b9d77663f9efd331
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Fri Jun 01 07:16:16 2018

Unfiy WorkerEventQueue and DOMWindowEventQueue into EventQueueImpl

This is part of efforts to refactor EventQueue. This CL is a pure
refactoring to reduce duplication. I'll merge MediaElementEventQueue
into EventQueueImpl later.

Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit#

Bug:  846618 
Change-Id: I03bd276f7ca863868c39ad4b34afbab9a0e03620
Reviewed-on: https://chromium-review.googlesource.com/1082061
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563558}
[modify] https://crrev.com/f493b5ee90945d728557c3a8b9d77663f9efd331/third_party/blink/renderer/core/dom/BUILD.gn
[rename] https://crrev.com/f493b5ee90945d728557c3a8b9d77663f9efd331/third_party/blink/renderer/core/dom/events/event_queue_impl.cc
[rename] https://crrev.com/f493b5ee90945d728557c3a8b9d77663f9efd331/third_party/blink/renderer/core/dom/events/event_queue_impl.h
[modify] https://crrev.com/f493b5ee90945d728557c3a8b9d77663f9efd331/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/f493b5ee90945d728557c3a8b9d77663f9efd331/third_party/blink/renderer/core/frame/local_dom_window.h
[modify] https://crrev.com/f493b5ee90945d728557c3a8b9d77663f9efd331/third_party/blink/renderer/core/workers/BUILD.gn
[delete] https://crrev.com/9e0169368d66a438e7f45482971614eb0ef2f8fa/third_party/blink/renderer/core/workers/worker_event_queue.cc
[delete] https://crrev.com/9e0169368d66a438e7f45482971614eb0ef2f8fa/third_party/blink/renderer/core/workers/worker_event_queue.h
[modify] https://crrev.com/f493b5ee90945d728557c3a8b9d77663f9efd331/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/f493b5ee90945d728557c3a8b9d77663f9efd331/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.h

Summary: Refactor EventQueue (was: Replace EventQueue with just task runner or timer)
Description: Show this description
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cda18c6c84ec8ce5672690ec9b7f7b69b51aec6e

commit cda18c6c84ec8ce5672690ec9b7f7b69b51aec6e
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Mon Jun 04 07:17:07 2018

Refactoring: Remove unnecessary update of event target

This was introduced at https://chromium.googlesource.com/chromium/src/+/f5bf1eaa7c969922365e17dea1fa6bf888080e87
and it looks like there is no reason to update the event target there.

Bug:  846618 
Change-Id: I0f0a70674be2aa86d96bf067953ea45e38cd9e5f
Reviewed-on: https://chromium-review.googlesource.com/1082134
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564008}
[modify] https://crrev.com/cda18c6c84ec8ce5672690ec9b7f7b69b51aec6e/third_party/blink/renderer/core/dom/events/media_element_event_queue.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/310d19e18d17e98e1d735b0529b86927f4946db0

commit 310d19e18d17e98e1d735b0529b86927f4946db0
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Mon Jun 04 09:48:49 2018

Replace EventQueue::CancelEvent with EventQueue::CancelAllEvents

This is a preparation of merging MediaElementEventQueue and
EventQueueImpl. This CL also changes IndexedDB objects to own
EventQueueImpl instead of queued Event vector.

Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit#

Bug:  846618 
Change-Id: I8eb49f876507ef4e62251fc4510bffefa687431e
Reviewed-on: https://chromium-review.googlesource.com/1082190
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564039}
[modify] https://crrev.com/310d19e18d17e98e1d735b0529b86927f4946db0/third_party/blink/renderer/core/dom/events/event_queue.h
[modify] https://crrev.com/310d19e18d17e98e1d735b0529b86927f4946db0/third_party/blink/renderer/core/dom/events/event_queue_impl.cc
[modify] https://crrev.com/310d19e18d17e98e1d735b0529b86927f4946db0/third_party/blink/renderer/core/dom/events/event_queue_impl.h
[modify] https://crrev.com/310d19e18d17e98e1d735b0529b86927f4946db0/third_party/blink/renderer/core/testing/null_execution_context.cc
[modify] https://crrev.com/310d19e18d17e98e1d735b0529b86927f4946db0/third_party/blink/renderer/modules/indexeddb/idb_database.cc
[modify] https://crrev.com/310d19e18d17e98e1d735b0529b86927f4946db0/third_party/blink/renderer/modules/indexeddb/idb_database.h
[modify] https://crrev.com/310d19e18d17e98e1d735b0529b86927f4946db0/third_party/blink/renderer/modules/indexeddb/idb_open_db_request.cc
[modify] https://crrev.com/310d19e18d17e98e1d735b0529b86927f4946db0/third_party/blink/renderer/modules/indexeddb/idb_request.cc
[modify] https://crrev.com/310d19e18d17e98e1d735b0529b86927f4946db0/third_party/blink/renderer/modules/indexeddb/idb_request.h

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2a875c92ddd55d3ccdf1818ad685b57590a0565

commit c2a875c92ddd55d3ccdf1818ad685b57590a0565
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Jun 06 07:00:02 2018

Make MediaElementEventQueue and EventQueueImpl inherit ContextLifecycleObserver

When the ExecutionContext is destroyed in an event queue, the event
queue should no longer be available. Then it must delete all the queued
events and close itself.

Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit#

Bug:  846618 
Change-Id: I2de831956238bc2e783e9c8c2eadc56f75f3faaf
Reviewed-on: https://chromium-review.googlesource.com/1088341
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564810}
[modify] https://crrev.com/c2a875c92ddd55d3ccdf1818ad685b57590a0565/third_party/blink/renderer/core/dom/events/event_queue_impl.cc
[modify] https://crrev.com/c2a875c92ddd55d3ccdf1818ad685b57590a0565/third_party/blink/renderer/core/dom/events/event_queue_impl.h
[modify] https://crrev.com/c2a875c92ddd55d3ccdf1818ad685b57590a0565/third_party/blink/renderer/core/dom/events/media_element_event_queue.cc
[modify] https://crrev.com/c2a875c92ddd55d3ccdf1818ad685b57590a0565/third_party/blink/renderer/core/dom/events/media_element_event_queue.h

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b270692a660d5554ebe0e92a716fb86846d5391

commit 0b270692a660d5554ebe0e92a716fb86846d5391
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Jun 06 09:03:44 2018

Always use GetExecutionContext() instead of event targets in EventQueueImpl and MediaElementEventQueue

This is a preparation for merging EventQueueImpl and
MediaElementEventQueue. This CL resuces the dependencies on usages of
|event->target()|.

Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit#

Bug:  846618 
Change-Id: Ib17a49226ea24a33b053f31a70ae3fe050dccb36
Reviewed-on: https://chromium-review.googlesource.com/1088356
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564829}
[modify] https://crrev.com/0b270692a660d5554ebe0e92a716fb86846d5391/third_party/blink/renderer/core/dom/events/event_queue_impl.cc
[modify] https://crrev.com/0b270692a660d5554ebe0e92a716fb86846d5391/third_party/blink/renderer/core/dom/events/event_queue_impl.h
[modify] https://crrev.com/0b270692a660d5554ebe0e92a716fb86846d5391/third_party/blink/renderer/core/dom/events/media_element_event_queue.cc
[modify] https://crrev.com/0b270692a660d5554ebe0e92a716fb86846d5391/third_party/blink/renderer/core/dom/events/media_element_event_queue.h

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71475b1e564ee6638b619568196cddf26fd009ca

commit 71475b1e564ee6638b619568196cddf26fd009ca
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Jun 06 11:37:41 2018

Remove a redundant argument from MediaElementEventQueue

This is a pure refactoring.

Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit#

Bug:  846618 
Change-Id: Ied94509c9d5af1a937142addebbc414da9c0e95f
Reviewed-on: https://chromium-review.googlesource.com/1088449
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564859}
[modify] https://crrev.com/71475b1e564ee6638b619568196cddf26fd009ca/third_party/blink/renderer/core/dom/events/media_element_event_queue.cc
[modify] https://crrev.com/71475b1e564ee6638b619568196cddf26fd009ca/third_party/blink/renderer/core/dom/events/media_element_event_queue.h
[modify] https://crrev.com/71475b1e564ee6638b619568196cddf26fd009ca/third_party/blink/renderer/core/html/media/html_media_element.cc
[modify] https://crrev.com/71475b1e564ee6638b619568196cddf26fd009ca/third_party/blink/renderer/core/html/track/text_track_list.cc
[modify] https://crrev.com/71475b1e564ee6638b619568196cddf26fd009ca/third_party/blink/renderer/modules/encryptedmedia/media_key_session.cc
[modify] https://crrev.com/71475b1e564ee6638b619568196cddf26fd009ca/third_party/blink/renderer/modules/mediasource/media_source.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f8391bbed526936ce1c32e47b4e6e5ae8baba6c

commit 1f8391bbed526936ce1c32e47b4e6e5ae8baba6c
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Jun 06 12:26:54 2018

EventQueue(Impl) for each user instead of ExecutionContext

To decouple the relationships between EventQueue(Impl) and
ExecutionContext, make each user have their own EventQueueImpl object.

For ContentSecurityPolicy class, I'll make a follow-up CL later.

Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit#

Bug:  846618 
Change-Id: I3177bf1e69ef1db61cb8056c2309e93ad5539b94
Reviewed-on: https://chromium-review.googlesource.com/1088534
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564865}
[modify] https://crrev.com/1f8391bbed526936ce1c32e47b4e6e5ae8baba6c/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/1f8391bbed526936ce1c32e47b4e6e5ae8baba6c/third_party/blink/renderer/core/exported/web_plugin_container_impl.h
[modify] https://crrev.com/1f8391bbed526936ce1c32e47b4e6e5ae8baba6c/third_party/blink/renderer/modules/broadcastchannel/broadcast_channel.cc
[modify] https://crrev.com/1f8391bbed526936ce1c32e47b4e6e5ae8baba6c/third_party/blink/renderer/modules/broadcastchannel/broadcast_channel.h
[modify] https://crrev.com/1f8391bbed526936ce1c32e47b4e6e5ae8baba6c/third_party/blink/renderer/modules/indexeddb/idb_transaction.cc
[modify] https://crrev.com/1f8391bbed526936ce1c32e47b4e6e5ae8baba6c/third_party/blink/renderer/modules/indexeddb/idb_transaction.h
[modify] https://crrev.com/1f8391bbed526936ce1c32e47b4e6e5ae8baba6c/third_party/blink/renderer/modules/indexeddb/idb_transaction_test.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08e5d3c0856e04526d2d8bf025c4322b6ed4eeab

commit 08e5d3c0856e04526d2d8bf025c4322b6ed4eeab
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Jun 07 10:34:51 2018

Remove EventQueue::Close and MediaElementEventQueue::Close

This CL is pure refactoring. As both classes are
ContextLifecycleObserver, we don't have to call Close explicitly.

Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit#

Bug:  846618 
Change-Id: I38fb655612d8c1205fe5ae88646d8fd1797b5c5b
Reviewed-on: https://chromium-review.googlesource.com/1090597
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565220}
[modify] https://crrev.com/08e5d3c0856e04526d2d8bf025c4322b6ed4eeab/third_party/blink/renderer/core/dom/events/event_queue.h
[modify] https://crrev.com/08e5d3c0856e04526d2d8bf025c4322b6ed4eeab/third_party/blink/renderer/core/dom/events/event_queue_impl.cc
[modify] https://crrev.com/08e5d3c0856e04526d2d8bf025c4322b6ed4eeab/third_party/blink/renderer/core/dom/events/event_queue_impl.h
[modify] https://crrev.com/08e5d3c0856e04526d2d8bf025c4322b6ed4eeab/third_party/blink/renderer/core/dom/events/media_element_event_queue.cc
[modify] https://crrev.com/08e5d3c0856e04526d2d8bf025c4322b6ed4eeab/third_party/blink/renderer/core/dom/events/media_element_event_queue.h
[modify] https://crrev.com/08e5d3c0856e04526d2d8bf025c4322b6ed4eeab/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/08e5d3c0856e04526d2d8bf025c4322b6ed4eeab/third_party/blink/renderer/core/html/media/html_media_element.cc
[modify] https://crrev.com/08e5d3c0856e04526d2d8bf025c4322b6ed4eeab/third_party/blink/renderer/core/testing/null_execution_context.cc
[modify] https://crrev.com/08e5d3c0856e04526d2d8bf025c4322b6ed4eeab/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/08e5d3c0856e04526d2d8bf025c4322b6ed4eeab/third_party/blink/renderer/modules/encryptedmedia/media_key_session.cc
[modify] https://crrev.com/08e5d3c0856e04526d2d8bf025c4322b6ed4eeab/third_party/blink/renderer/modules/mediasource/media_source.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa6f05dff4a1cfc932f4edf6f052b12722db7bb0

commit aa6f05dff4a1cfc932f4edf6f052b12722db7bb0
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Fri Jun 08 11:51:35 2018

Remove TaskType::kUnthrottled

Now LocalDOMWindow::event_queue_ is no longer used by IndexedDB, the
task type doesn't have to be 'kUnthrottled'. This was the last one usage
of kUnthrottled and we can remove this now.

Bug: 836410,  846618 
Change-Id: Ifb5913d93a36cc6f8a5f645c6ecbf0016e424ad4
Reviewed-on: https://chromium-review.googlesource.com/1092225
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565611}
[modify] https://crrev.com/aa6f05dff4a1cfc932f4edf6f052b12722db7bb0/third_party/blink/public/platform/task_type.h
[modify] https://crrev.com/aa6f05dff4a1cfc932f4edf6f052b12722db7bb0/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/aa6f05dff4a1cfc932f4edf6f052b12722db7bb0/third_party/blink/renderer/core/workers/parent_execution_context_task_runners.cc
[modify] https://crrev.com/aa6f05dff4a1cfc932f4edf6f052b12722db7bb0/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
[modify] https://crrev.com/aa6f05dff4a1cfc932f4edf6f052b12722db7bb0/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/aa6f05dff4a1cfc932f4edf6f052b12722db7bb0/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler.cc

Status: Started (was: Assigned)
Project Member

Comment 19 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43f28b2c02dce3f392e96fa70e2a68105ba7a458

commit 43f28b2c02dce3f392e96fa70e2a68105ba7a458
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Jun 13 06:39:28 2018

Add EventTarget::EnqueueAsyncEvent and probe functions

Now we're trying not to depend on event's target when dispatch an event
asyncly in EventQueueImpl since event target is set also when actual
dispatching, and setting the target before dispatching should be
redundant. In the current situation, there is no consistent rule whether
event target is set before dispatching or not.

However, there is no other way to inform what is the target
for the given event at EventQueueImpl::EnqueueEvent.

In the usecase of EventQueue in ContentSecurityPolicy, there is no need
to cancel events actively. Then, just posting tasks for events and
dispatching them or canceling them when execution context is not present
are enough.

Instead of EventQueueImpl, this CL introduces EventTarget::
EnqueueAsyncEvent.

Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit#

Bug:  846618 
Change-Id: I33e67390762cba233ce31634238d4fd477b8d8da
Reviewed-on: https://chromium-review.googlesource.com/1090591
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566737}
[modify] https://crrev.com/43f28b2c02dce3f392e96fa70e2a68105ba7a458/third_party/blink/renderer/core/dom/events/event_target.cc
[modify] https://crrev.com/43f28b2c02dce3f392e96fa70e2a68105ba7a458/third_party/blink/renderer/core/dom/events/event_target.h
[modify] https://crrev.com/43f28b2c02dce3f392e96fa70e2a68105ba7a458/third_party/blink/renderer/core/frame/csp/content_security_policy.cc

Project Member

Comment 20 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58799c93883e8dff71be74828580ef63194f05d3

commit 58799c93883e8dff71be74828580ef63194f05d3
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Jun 13 10:16:47 2018

Remove ExecutionContext::GetEventQueue

EventQueue no longer belongs to ExecutionContext but event target.

This is a preparation of merging MediaElementEventQueue and
EventQueueImpl.

Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit#

Bug:  846618 
Change-Id: Ib09cc7ca837e9900885824b3786209bafba59a30
Reviewed-on: https://chromium-review.googlesource.com/1090697
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566786}
[modify] https://crrev.com/58799c93883e8dff71be74828580ef63194f05d3/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/58799c93883e8dff71be74828580ef63194f05d3/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/58799c93883e8dff71be74828580ef63194f05d3/third_party/blink/renderer/core/execution_context/execution_context.h
[modify] https://crrev.com/58799c93883e8dff71be74828580ef63194f05d3/third_party/blink/renderer/core/exported/web_plugin_container_impl.h
[modify] https://crrev.com/58799c93883e8dff71be74828580ef63194f05d3/third_party/blink/renderer/core/frame/csp/content_security_policy.cc
[modify] https://crrev.com/58799c93883e8dff71be74828580ef63194f05d3/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/58799c93883e8dff71be74828580ef63194f05d3/third_party/blink/renderer/core/frame/local_dom_window.h
[modify] https://crrev.com/58799c93883e8dff71be74828580ef63194f05d3/third_party/blink/renderer/core/testing/null_execution_context.cc
[modify] https://crrev.com/58799c93883e8dff71be74828580ef63194f05d3/third_party/blink/renderer/core/testing/null_execution_context.h
[modify] https://crrev.com/58799c93883e8dff71be74828580ef63194f05d3/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/58799c93883e8dff71be74828580ef63194f05d3/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.h
[modify] https://crrev.com/58799c93883e8dff71be74828580ef63194f05d3/third_party/blink/renderer/modules/broadcastchannel/broadcast_channel.h
[modify] https://crrev.com/58799c93883e8dff71be74828580ef63194f05d3/third_party/blink/renderer/modules/indexeddb/idb_request.cc
[modify] https://crrev.com/58799c93883e8dff71be74828580ef63194f05d3/third_party/blink/renderer/modules/indexeddb/idb_transaction.h

Project Member

Comment 21 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18a428bac6496339ef47c527584716793c7a9a05

commit 18a428bac6496339ef47c527584716793c7a9a05
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Jun 14 11:12:10 2018

Add EventQueueImpl::target_

This CL is a continuation of
https://chromium-review.googlesource.com/c/chromium/src/+/1088356.

This CL gives an event target to EventQueueImpl and use it instead of
event->target() so that we can have EventQueueImpl and
MediaElementEventQueue with the same structure.

Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit#

Bug:  846618 
Change-Id: I394e3b1c01df3a2af671bb6d72fe9d32ac9ea94e
Reviewed-on: https://chromium-review.googlesource.com/1098736
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567220}
[modify] https://crrev.com/18a428bac6496339ef47c527584716793c7a9a05/third_party/blink/renderer/core/dom/events/event_queue_impl.cc
[modify] https://crrev.com/18a428bac6496339ef47c527584716793c7a9a05/third_party/blink/renderer/core/dom/events/event_queue_impl.h
[modify] https://crrev.com/18a428bac6496339ef47c527584716793c7a9a05/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/18a428bac6496339ef47c527584716793c7a9a05/third_party/blink/renderer/modules/broadcastchannel/broadcast_channel.cc
[modify] https://crrev.com/18a428bac6496339ef47c527584716793c7a9a05/third_party/blink/renderer/modules/indexeddb/idb_database.cc
[modify] https://crrev.com/18a428bac6496339ef47c527584716793c7a9a05/third_party/blink/renderer/modules/indexeddb/idb_request.cc
[modify] https://crrev.com/18a428bac6496339ef47c527584716793c7a9a05/third_party/blink/renderer/modules/indexeddb/idb_transaction.cc
[modify] https://crrev.com/18a428bac6496339ef47c527584716793c7a9a05/third_party/blink/renderer/modules/indexeddb/idb_transaction_test.cc

Project Member

Comment 22 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60d31377796a6a455e1fd2c9d193ac6c5b43d3df

commit 60d31377796a6a455e1fd2c9d193ac6c5b43d3df
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Fri Jun 15 09:16:58 2018

Remove some Event::SetTarget for MediaElementEventQueue

Before merging MediaElementEventQueue into EventQueueImpl, we need to
eliminate code to set the target for an event. This is part of this work.

Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit#

Bug:  846618 
Change-Id: Ic3b19ff2af19d931356ff72800797b36506f5ff0
Reviewed-on: https://chromium-review.googlesource.com/1102233
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567587}
[modify] https://crrev.com/60d31377796a6a455e1fd2c9d193ac6c5b43d3df/third_party/blink/renderer/core/dom/events/media_element_event_queue.cc
[modify] https://crrev.com/60d31377796a6a455e1fd2c9d193ac6c5b43d3df/third_party/blink/renderer/modules/encryptedmedia/media_key_session.cc
[modify] https://crrev.com/60d31377796a6a455e1fd2c9d193ac6c5b43d3df/third_party/blink/renderer/modules/mediasource/media_source.cc

Project Member

Comment 23 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/124e793cc967987b1db77488f2020c59e172b2d0

commit 124e793cc967987b1db77488f2020c59e172b2d0
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Jun 19 08:01:41 2018

Revert "Remove some Event::SetTarget for MediaElementEventQueue"

This reverts commit 60d31377796a6a455e1fd2c9d193ac6c5b43d3df.

Reason for revert: We realized that MediaElementEventQueue : target is not 1:1. Instead of MediaElementEventQueue with a target, each event should have its target.

Original change's description:
> Remove some Event::SetTarget for MediaElementEventQueue
> 
> Before merging MediaElementEventQueue into EventQueueImpl, we need to
> eliminate code to set the target for an event. This is part of this work.
> 
> Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit#
> 
> Bug:  846618 
> Change-Id: Ic3b19ff2af19d931356ff72800797b36506f5ff0
> Reviewed-on: https://chromium-review.googlesource.com/1102233
> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567587}

TBR=hajimehoshi@chromium.org,haraken@chromium.org,altimin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  846618 
Change-Id: I28cf7c58e123b66e2472f64b233684cbf1006dd4
Reviewed-on: https://chromium-review.googlesource.com/1105540
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568370}
[modify] https://crrev.com/124e793cc967987b1db77488f2020c59e172b2d0/third_party/blink/renderer/core/dom/events/media_element_event_queue.cc
[modify] https://crrev.com/124e793cc967987b1db77488f2020c59e172b2d0/third_party/blink/renderer/modules/encryptedmedia/media_key_session.cc
[modify] https://crrev.com/124e793cc967987b1db77488f2020c59e172b2d0/third_party/blink/renderer/modules/mediasource/media_source.cc

Project Member

Comment 24 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e5607f8bda83ab23f9976b1acadafacaa973e24

commit 4e5607f8bda83ab23f9976b1acadafacaa973e24
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Jun 19 11:24:52 2018

Use event->target() instead of MediaElementEventQueue::owner_

We realized that MediaElementEventQueue : target is not 1 : 1. Then,
Having MediaElementEventQueue own a target doesn't make sense. This CL
enforces to set a target of an event before enqueuing and use it when
dispatching.

Bug:  846618 
Change-Id: Iacc19e6c55040fe05e4883fa33f570b3424650e0
Reviewed-on: https://chromium-review.googlesource.com/1105803
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568403}
[modify] https://crrev.com/4e5607f8bda83ab23f9976b1acadafacaa973e24/third_party/blink/renderer/core/dom/events/media_element_event_queue.cc
[modify] https://crrev.com/4e5607f8bda83ab23f9976b1acadafacaa973e24/third_party/blink/renderer/core/dom/events/media_element_event_queue.h
[modify] https://crrev.com/4e5607f8bda83ab23f9976b1acadafacaa973e24/third_party/blink/renderer/core/html/media/html_media_element.cc
[modify] https://crrev.com/4e5607f8bda83ab23f9976b1acadafacaa973e24/third_party/blink/renderer/core/html/track/text_track_list.cc
[modify] https://crrev.com/4e5607f8bda83ab23f9976b1acadafacaa973e24/third_party/blink/renderer/modules/encryptedmedia/media_key_session.cc
[modify] https://crrev.com/4e5607f8bda83ab23f9976b1acadafacaa973e24/third_party/blink/renderer/modules/mediasource/media_source.cc

Project Member

Comment 25 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/244004461ffaad05ec5daa5eaaccbe0110097642

commit 244004461ffaad05ec5daa5eaaccbe0110097642
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Jun 19 11:53:14 2018

Revert "Add EventQueueImpl::target_"

This reverts commit 18a428bac6496339ef47c527584716793c7a9a05.

Reason for revert: We realized that EventQueueImpl (after merged with MediaElementEventQueue) : target is not 1:1. Instead of EventQueueImpl with a target, each event should have its target.

Original change's description:
> Add EventQueueImpl::target_
> 
> This CL is a continuation of
> https://chromium-review.googlesource.com/c/chromium/src/+/1088356.
> 
> This CL gives an event target to EventQueueImpl and use it instead of
> event->target() so that we can have EventQueueImpl and
> MediaElementEventQueue with the same structure.
> 
> Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit#
> 
> Bug:  846618 
> Change-Id: I394e3b1c01df3a2af671bb6d72fe9d32ac9ea94e
> Reviewed-on: https://chromium-review.googlesource.com/1098736
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567220}

TBR=hajimehoshi@chromium.org,haraken@chromium.org,altimin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  846618 
Change-Id: Ic2f63364ec2d76d3aef51432d9e4c1258034c867
Reviewed-on: https://chromium-review.googlesource.com/1105653
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568406}
[modify] https://crrev.com/244004461ffaad05ec5daa5eaaccbe0110097642/third_party/blink/renderer/core/dom/events/event_queue_impl.cc
[modify] https://crrev.com/244004461ffaad05ec5daa5eaaccbe0110097642/third_party/blink/renderer/core/dom/events/event_queue_impl.h
[modify] https://crrev.com/244004461ffaad05ec5daa5eaaccbe0110097642/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/244004461ffaad05ec5daa5eaaccbe0110097642/third_party/blink/renderer/modules/broadcastchannel/broadcast_channel.cc
[modify] https://crrev.com/244004461ffaad05ec5daa5eaaccbe0110097642/third_party/blink/renderer/modules/indexeddb/idb_database.cc
[modify] https://crrev.com/244004461ffaad05ec5daa5eaaccbe0110097642/third_party/blink/renderer/modules/indexeddb/idb_request.cc
[modify] https://crrev.com/244004461ffaad05ec5daa5eaaccbe0110097642/third_party/blink/renderer/modules/indexeddb/idb_transaction.cc
[modify] https://crrev.com/244004461ffaad05ec5daa5eaaccbe0110097642/third_party/blink/renderer/modules/indexeddb/idb_transaction_test.cc

Project Member

Comment 26 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c077cf688813825c78d697ff715633345bb7691e

commit c077cf688813825c78d697ff715633345bb7691e
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Jun 20 08:38:21 2018

Merge MediaElementEventQueue into EventQueueImpl

Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit#

Bug:  846618 
Change-Id: I15903843b0377c45db9caf3d54914ed942caf361
Reviewed-on: https://chromium-review.googlesource.com/1098742
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568767}
[modify] https://crrev.com/c077cf688813825c78d697ff715633345bb7691e/third_party/blink/renderer/core/dom/BUILD.gn
[modify] https://crrev.com/c077cf688813825c78d697ff715633345bb7691e/third_party/blink/renderer/core/dom/events/event_queue.h
[modify] https://crrev.com/c077cf688813825c78d697ff715633345bb7691e/third_party/blink/renderer/core/dom/events/event_queue_impl.cc
[modify] https://crrev.com/c077cf688813825c78d697ff715633345bb7691e/third_party/blink/renderer/core/dom/events/event_queue_impl.h
[delete] https://crrev.com/7787593dc70315ae5dfad94136013d10f36f1f82/third_party/blink/renderer/core/dom/events/media_element_event_queue.cc
[delete] https://crrev.com/7787593dc70315ae5dfad94136013d10f36f1f82/third_party/blink/renderer/core/dom/events/media_element_event_queue.h
[modify] https://crrev.com/c077cf688813825c78d697ff715633345bb7691e/third_party/blink/renderer/core/html/media/html_media_element.cc
[modify] https://crrev.com/c077cf688813825c78d697ff715633345bb7691e/third_party/blink/renderer/core/html/media/html_media_element.h
[modify] https://crrev.com/c077cf688813825c78d697ff715633345bb7691e/third_party/blink/renderer/core/html/track/text_track_list.cc
[modify] https://crrev.com/c077cf688813825c78d697ff715633345bb7691e/third_party/blink/renderer/core/html/track/text_track_list.h
[modify] https://crrev.com/c077cf688813825c78d697ff715633345bb7691e/third_party/blink/renderer/modules/encryptedmedia/media_key_session.cc
[modify] https://crrev.com/c077cf688813825c78d697ff715633345bb7691e/third_party/blink/renderer/modules/encryptedmedia/media_key_session.h
[modify] https://crrev.com/c077cf688813825c78d697ff715633345bb7691e/third_party/blink/renderer/modules/indexeddb/idb_request.cc
[modify] https://crrev.com/c077cf688813825c78d697ff715633345bb7691e/third_party/blink/renderer/modules/mediasource/media_source.cc
[modify] https://crrev.com/c077cf688813825c78d697ff715633345bb7691e/third_party/blink/renderer/modules/mediasource/media_source.h
[modify] https://crrev.com/c077cf688813825c78d697ff715633345bb7691e/third_party/blink/renderer/modules/mediasource/source_buffer.cc
[modify] https://crrev.com/c077cf688813825c78d697ff715633345bb7691e/third_party/blink/renderer/modules/mediasource/source_buffer.h
[modify] https://crrev.com/c077cf688813825c78d697ff715633345bb7691e/third_party/blink/renderer/modules/mediasource/source_buffer_list.cc
[modify] https://crrev.com/c077cf688813825c78d697ff715633345bb7691e/third_party/blink/renderer/modules/mediasource/source_buffer_list.h

Project Member

Comment 27 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d35b92b9d21b2d299fdddaf07c3bcb0e32a0b16d

commit d35b92b9d21b2d299fdddaf07c3bcb0e32a0b16d
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Jun 21 06:19:54 2018

Merge EventQueueImpl into EventQueue

This CL merges EventQueue and EventQueueImpl into one class.

Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit#

Bug:  846618 
Change-Id: I302f99848ec59f16e7c8c2f1a5ca14aa0896a21a
Reviewed-on: https://chromium-review.googlesource.com/1107527
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569170}
[modify] https://crrev.com/d35b92b9d21b2d299fdddaf07c3bcb0e32a0b16d/third_party/blink/renderer/core/dom/BUILD.gn
[rename] https://crrev.com/d35b92b9d21b2d299fdddaf07c3bcb0e32a0b16d/third_party/blink/renderer/core/dom/events/event_queue.cc
[modify] https://crrev.com/d35b92b9d21b2d299fdddaf07c3bcb0e32a0b16d/third_party/blink/renderer/core/dom/events/event_queue.h
[delete] https://crrev.com/387f2151790f84b88d4c6617e4560646d9e2edad/third_party/blink/renderer/core/dom/events/event_queue_impl.h
[modify] https://crrev.com/d35b92b9d21b2d299fdddaf07c3bcb0e32a0b16d/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/d35b92b9d21b2d299fdddaf07c3bcb0e32a0b16d/third_party/blink/renderer/core/html/media/html_media_element.cc
[modify] https://crrev.com/d35b92b9d21b2d299fdddaf07c3bcb0e32a0b16d/third_party/blink/renderer/core/html/track/text_track_list.cc
[modify] https://crrev.com/d35b92b9d21b2d299fdddaf07c3bcb0e32a0b16d/third_party/blink/renderer/core/testing/null_execution_context.h
[modify] https://crrev.com/d35b92b9d21b2d299fdddaf07c3bcb0e32a0b16d/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/d35b92b9d21b2d299fdddaf07c3bcb0e32a0b16d/third_party/blink/renderer/modules/broadcastchannel/broadcast_channel.cc
[modify] https://crrev.com/d35b92b9d21b2d299fdddaf07c3bcb0e32a0b16d/third_party/blink/renderer/modules/encryptedmedia/media_key_session.cc
[modify] https://crrev.com/d35b92b9d21b2d299fdddaf07c3bcb0e32a0b16d/third_party/blink/renderer/modules/indexeddb/idb_database.cc
[modify] https://crrev.com/d35b92b9d21b2d299fdddaf07c3bcb0e32a0b16d/third_party/blink/renderer/modules/indexeddb/idb_request.cc
[modify] https://crrev.com/d35b92b9d21b2d299fdddaf07c3bcb0e32a0b16d/third_party/blink/renderer/modules/indexeddb/idb_transaction.cc
[modify] https://crrev.com/d35b92b9d21b2d299fdddaf07c3bcb0e32a0b16d/third_party/blink/renderer/modules/mediasource/media_source.cc
[modify] https://crrev.com/d35b92b9d21b2d299fdddaf07c3bcb0e32a0b16d/third_party/blink/renderer/modules/mediasource/source_buffer.cc

Status: Fixed (was: Started)
Finished :-)
Project Member

Comment 29 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b43edaf30d719eaad21ad277da37d07a9525763

commit 0b43edaf30d719eaad21ad277da37d07a9525763
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Mon Jun 25 06:13:23 2018

Use EventTarget::EnqueueAsyncEvent instead of EventQueue at WebPluginContainerImpl

This CL is a pure refacotring.

Bug:  846618 
Change-Id: Ia858ad02d5ae14db59eb5bc947d6463e08f98ae8
Reviewed-on: https://chromium-review.googlesource.com/1113090
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569972}
[modify] https://crrev.com/0b43edaf30d719eaad21ad277da37d07a9525763/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/0b43edaf30d719eaad21ad277da37d07a9525763/third_party/blink/renderer/core/exported/web_plugin_container_impl.h

Project Member

Comment 30 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2141bfe20d779999dd4a21f71b1ee5fcb914bcd5

commit 2141bfe20d779999dd4a21f71b1ee5fcb914bcd5
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Mon Jun 25 12:17:26 2018

Add DCHECK to check event target existence at EventQueue

This check was in MediaElementEventQueue but lost when merging this into
EventQueueImpl.

Bug:  846618 
Change-Id: I354ab7a4787624c6269e6abd0a67eb0a63680ad6
Reviewed-on: https://chromium-review.googlesource.com/1113397
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570016}
[modify] https://crrev.com/2141bfe20d779999dd4a21f71b1ee5fcb914bcd5/third_party/blink/renderer/core/dom/events/event_queue.cc

Project Member

Comment 31 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4d30f28be0322184f5cd75fde80cb198ecba44b

commit e4d30f28be0322184f5cd75fde80cb198ecba44b
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Jun 26 09:48:57 2018

Add TaskType to EventTarget::EnqueueAsyncEvent

Events and task sources are orthogonal things, and it would not make
sense to determine a task source (task type) from an event. This CL adds
a TaskType argument to specify the task source explicitly.

Bug:  846618 
Change-Id: I2c3c5d51e8d94ee12905bc8b850162f10433ad76
Reviewed-on: https://chromium-review.googlesource.com/1114529
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570360}
[modify] https://crrev.com/e4d30f28be0322184f5cd75fde80cb198ecba44b/third_party/blink/renderer/core/dom/events/event_queue.h
[modify] https://crrev.com/e4d30f28be0322184f5cd75fde80cb198ecba44b/third_party/blink/renderer/core/dom/events/event_target.cc
[modify] https://crrev.com/e4d30f28be0322184f5cd75fde80cb198ecba44b/third_party/blink/renderer/core/dom/events/event_target.h
[modify] https://crrev.com/e4d30f28be0322184f5cd75fde80cb198ecba44b/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/e4d30f28be0322184f5cd75fde80cb198ecba44b/third_party/blink/renderer/core/frame/csp/content_security_policy.cc
[modify] https://crrev.com/e4d30f28be0322184f5cd75fde80cb198ecba44b/third_party/blink/renderer/core/frame/local_dom_window.cc

Project Member

Comment 32 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1df3171e8b42e9f866f7dba2ce4fed5725d25d16

commit 1df3171e8b42e9f866f7dba2ce4fed5725d25d16
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Jun 27 09:21:39 2018

Use EventTarget::EnqueueAsyncEvent instead of EventQueue when possible

EventQueue is necessary when queued events might be cancelled. This CL
replaces unnecessary usages of EventQueue wherever possible for code
simplicity.

This CL also adds comments about task sources that should have been
added at https://chromium-review.googlesource.com/c/chromium/src/+/1114672

Bug:  846618 
Change-Id: I610e7163c36faea11f9abd9a7c4550acb5b6188c
Reviewed-on: https://chromium-review.googlesource.com/1116516
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570709}
[modify] https://crrev.com/1df3171e8b42e9f866f7dba2ce4fed5725d25d16/third_party/blink/renderer/core/editing/frame_selection.cc
[modify] https://crrev.com/1df3171e8b42e9f866f7dba2ce4fed5725d25d16/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/1df3171e8b42e9f866f7dba2ce4fed5725d25d16/third_party/blink/renderer/core/html/track/text_track_list.cc
[modify] https://crrev.com/1df3171e8b42e9f866f7dba2ce4fed5725d25d16/third_party/blink/renderer/core/html/track/text_track_list.h
[modify] https://crrev.com/1df3171e8b42e9f866f7dba2ce4fed5725d25d16/third_party/blink/renderer/modules/broadcastchannel/broadcast_channel.cc
[modify] https://crrev.com/1df3171e8b42e9f866f7dba2ce4fed5725d25d16/third_party/blink/renderer/modules/broadcastchannel/broadcast_channel.h

Project Member

Comment 33 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/859d89c4abccbf6ec55010016b5fe2fca1977efd

commit 859d89c4abccbf6ec55010016b5fe2fca1977efd
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Aug 01 10:58:04 2018

Use TaskType::kPostedMessage instead of kInternalMedia at BroardcastChannel

The task type was introduced at https://chromium-review.googlesource.com/c/chromium/src/+/1088534
but kInternalMedia was not appropriate since BroardcastChannel has
nothing to do with media. Use kPostedMessage instead.

Bug:  846618 
Change-Id: Icdb72bd88aa4de9b6a7d415dde41268a5d7ca4bc
Reviewed-on: https://chromium-review.googlesource.com/1158314
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579756}
[modify] https://crrev.com/859d89c4abccbf6ec55010016b5fe2fca1977efd/third_party/blink/renderer/modules/broadcastchannel/broadcast_channel.cc

Sign in to add a comment