AEC3: Delay estimator sensitive to noise |
|||||||
Issue descriptionIn noisy environments it can be difficult for the delay estimator to quickly find the delay. Sometimes, in strong noise, the delay is not found at all.
,
May 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6705ca906863c6f5f96e3cf8f8cf4a381ba491b commit a6705ca906863c6f5f96e3cf8f8cf4a381ba491b Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Mon May 28 07:54:11 2018 Roll src/third_party/webrtc/ 547e3169d..d7a076cc8 (39 commits) https://webrtc.googlesource.com/src.git/+log/547e3169d9e0..d7a076cc8e3f $ git log 547e3169d..d7a076cc8 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG= chromium:846615 ,chromium:None,chromium:843477,chromium:None,chromium:None,chromium:None,chromium:None,chromium:749455,chromium:600254,chromium:600254,chromium:None,chromium:776681,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib82ca259df1fa58c02182b7bcf69740af5b766bc Reviewed-on: https://chromium-review.googlesource.com/1074448 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562203} [modify] https://crrev.com/a6705ca906863c6f5f96e3cf8f8cf4a381ba491b/DEPS
,
May 31 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/435187d18d8e72b046458fb7fc2c9cd10495e4c7 commit 435187d18d8e72b046458fb7fc2c9cd10495e4c7 Author: Gustaf Ullberg <gustaf@webrtc.org> Date: Thu May 31 13:45:15 2018 AEC3: CascadedBiQuadFilter can run different filters in cascade CascadedBiQuadFilter can run identical filters multiple times. This CL allows the use of different filters in each step. This enables the use of more elaborate filters. The filters are defined by zeros, poles and gains. The 'old' way of initializing CascadedBiQuadFilter with a transfer function and number of filters is left intact. Bug: webrtc:9288 , chromium:846615 Change-Id: Ie4a5b98eba044415571cdcac087b20870a0b5d33 Reviewed-on: https://webrtc-review.googlesource.com/80060 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23473} [modify] https://crrev.com/435187d18d8e72b046458fb7fc2c9cd10495e4c7/modules/audio_processing/aec3/cascaded_biquad_filter.cc [modify] https://crrev.com/435187d18d8e72b046458fb7fc2c9cd10495e4c7/modules/audio_processing/aec3/cascaded_biquad_filter.h [modify] https://crrev.com/435187d18d8e72b046458fb7fc2c9cd10495e4c7/modules/audio_processing/aec3/cascaded_biquad_filter_unittest.cc [modify] https://crrev.com/435187d18d8e72b046458fb7fc2c9cd10495e4c7/modules/audio_processing/aec3/decimator.cc
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ffd783bcfeffa70258c0bb47773e4858c7b4f78 commit 5ffd783bcfeffa70258c0bb47773e4858c7b4f78 Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Jun 01 07:35:49 2018 Roll src/third_party/webrtc 942b360..5234a49 (29 commits) https://webrtc.googlesource.com/src.git/+log/942b360..5234a49 git log 942b360..5234a49 --date=short --no-merges --format='%ad %ae %s' 2018-05-29 benwright@webrtc.org Create PeerConnectionFactoryDependencies to prevent new function overloads. 2018-05-31 buildbot@webrtc.org Roll chromium_revision 54223a6fbb..2fd473c996 (563301:563409) 2018-05-31 deadbeef@webrtc.org Implement proper SCTP data channel closing procedure. 2018-05-24 deadbeef@webrtc.org Fixing bug with PseudoTcp that corrupts data if initial packet is lost. 2018-05-31 xz4215@gmail.com Remove unnecessary set_stream_ids call 2018-05-31 buildbot@webrtc.org Roll chromium_revision 812f7cad93..54223a6fbb (563201:563301) 2018-05-30 braveyao@webrtc.org [desktopCapture Windows] ignore Chrome notification window on top 2018-05-31 gustaf@webrtc.org AEC3: CascadedBiQuadFilter can run different filters in cascade 2018-05-31 buildbot@webrtc.org Roll chromium_revision 64b2aa35c9..812f7cad93 (563090:563201) 2018-05-31 hta@webrtc.org Add collection of usage signatures on PeerConnections 2018-05-31 ilnik@webrtc.org Add test against crashes in VideoQualityObserver 2018-05-31 brandtr@webrtc.org Refactor SimulcastTestUtility into SimulcastTestFixture{,Impl} 2018-05-31 mbonadei@webrtc.org Revert "Use absl::optional instead or rtc::Optional" 2018-05-31 srte@webrtc.org Adds loss rate filter in BBR controller. 2018-05-29 asapersson@webrtc.org Add min_bitrate_bps to RtpEncodingParameters. 2018-05-31 nisse@webrtc.org Add placeholder header file api/video_codecs/video_codec.h. 2018-05-30 terelius@webrtc.org Split IceCandidatePairEventType enum. 2018-05-30 deadbeef@webrtc.org Fixing null rtc::Optional dereference in VideoQualityObserver. 2018-05-30 nisse@webrtc.org Delete definitions of NULL. 2018-05-30 kthelgason@webrtc.org iOS SDK 10.0 compatability. 2018-05-31 danilchap@webrtc.org Reland "Use absl::optional instead or rtc::Optional" 2018-05-30 buildbot@webrtc.org Roll chromium_revision 372312ba2f..64b2aa35c9 (562984:563090) 2018-05-30 xz4215@gmail.com ObjC: Notify local video track 2018-05-30 buildbot@webrtc.org Roll chromium_revision ebe721b053..372312ba2f (562863:562984) 2018-05-30 buildbot@webrtc.org Roll chromium_revision 9d94097261..ebe721b053 (562745:562863) 2018-05-30 jtteh@webrtc.org Revert "Metal rendering should account for cropping." 2018-05-30 kthelgason@webrtc.org Remove deprecated mac capture code. 2018-05-30 andersc@webrtc.org Add missing header file to WebRTC iOS SDK. 2018-05-23 peterhanspers@webrtc.org Metal rendering should account for cropping. Created with: gclient setdep -r src/third_party/webrtc@5234a49 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:449934,chromium:None,chromium:None,chromium:847664,chromium:846615,chromium:None,chromium:718508,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I41813f1030635c268c626c688bebc71c6b03d739 Reviewed-on: https://chromium-review.googlesource.com/1082012 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#563560} [modify] https://crrev.com/5ffd783bcfeffa70258c0bb47773e4858c7b4f78/DEPS
,
Jun 1 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/c4b7f037b775be165afa4c7d17ec34976c70bae2 commit c4b7f037b775be165afa4c7d17ec34976c70bae2 Author: Gustaf Ullberg <gustaf@webrtc.org> Date: Fri Jun 01 10:07:16 2018 AEC3: Adjust active render limits for downsampling factor 8 The signal used for delay estimation at downsampling factor 8 is bandpass filtered and contains less energy than for other downsampling factors. This CL adjusts the energy threshold used for determining if there is enough farend activity to update the matched filters in the delay estimator. Only downsampling factor 8 is affected. Bug: webrtc:9288 , chromium:846615 Change-Id: I6f38f5609a31e7a08e60571ac75ea75c9962e026 Reviewed-on: https://webrtc-review.googlesource.com/80443 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23486} [modify] https://crrev.com/c4b7f037b775be165afa4c7d17ec34976c70bae2/api/audio/echo_canceller3_config.h [modify] https://crrev.com/c4b7f037b775be165afa4c7d17ec34976c70bae2/modules/audio_processing/aec3/echo_path_delay_estimator.cc
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1d09ee808614bc1832c854b29726f0b7f26e60d commit c1d09ee808614bc1832c854b29726f0b7f26e60d Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Jun 01 14:16:45 2018 Roll src/third_party/webrtc f2fae87..79ce820 (4 commits) https://webrtc.googlesource.com/src.git/+log/f2fae87..79ce820 git log f2fae87..79ce820 --date=short --no-merges --format='%ad %ae %s' 2018-06-01 andersc@webrtc.org Obj-C SDK for parsing and generating H264 ProfileLevelIds. 2018-06-01 kwiberg@webrtc.org Remove the audio codec factory methods that don't take AudioCodecPairId 2018-06-01 gustaf@webrtc.org AEC3: Adjust active render limits for downsampling factor 8 2018-06-01 philipel@webrtc.org Update packet_buffer_fuzzer to fuzz full packets. Created with: gclient setdep -r src/third_party/webrtc@79ce820 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:846615 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic75ac52ac2904f5d7e23677336ec89802dbc72ee Reviewed-on: https://chromium-review.googlesource.com/1082241 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#563614} [modify] https://crrev.com/c1d09ee808614bc1832c854b29726f0b7f26e60d/DEPS
,
Jun 4 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/267287407adfbf62da2444ca2683cbc4814d901e commit 267287407adfbf62da2444ca2683cbc4814d901e Author: Gustaf Ullberg <gustaf@webrtc.org> Date: Mon Jun 04 19:04:10 2018 AEC3: Set default down sampling factor to 4 This change sets the default down sampling factor of the delay estimator 4. Down sampling factor 8 is still problematic for some signals. Bug: webrtc:9288 , chromium:846615 Change-Id: I125371f3caf4f660ea2a386d2b89d7a488dcf802 Reviewed-on: https://webrtc-review.googlesource.com/80965 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23512} [modify] https://crrev.com/267287407adfbf62da2444ca2683cbc4814d901e/api/audio/echo_canceller3_config.h
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1078a680e3d07bf431961993b118e85ddda987ea commit 1078a680e3d07bf431961993b118e85ddda987ea Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue Jun 05 13:09:25 2018 Roll src/third_party/webrtc 27300c3..3ea3e30 (4 commits) https://webrtc.googlesource.com/src.git/+log/27300c3..3ea3e30 git log 27300c3..3ea3e30 --date=short --no-merges --format='%ad %ae %s' 2018-06-05 natashenka@google.com Fixing some SIGFPEs that are making my tests crash 2018-06-05 ilnik@webrtc.org Remove deprecated API methods in video pipeline 2018-06-04 mbonadei@webrtc.org Remove warning suppression flags from sdk/android. 2018-06-04 gustaf@webrtc.org AEC3: Set default down sampling factor to 4 Created with: gclient setdep -r src/third_party/webrtc@3ea3e30 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:none,chromium:none,chromium:846615 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I59e269ee00bb609bce3483aefbf37f1c0ed2f1ef Reviewed-on: https://chromium-review.googlesource.com/1086770 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564471} [modify] https://crrev.com/1078a680e3d07bf431961993b118e85ddda987ea/DEPS
,
Jun 7 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/34c9f1252af71da694bf76f9d1fc21ffc9bd343b commit 34c9f1252af71da694bf76f9d1fc21ffc9bd343b Author: Gustaf Ullberg <gustaf@webrtc.org> Date: Thu Jun 07 08:09:17 2018 AEC3: Move decimator filters to the new notation Preparing for changing the filters of the decimator by moving the old filters to the new zero, pole, gain notation. Bug: webrtc:9288 , chromium:846615 Change-Id: I2b01a2555d34617e0bf251c782703753f72cd56f Reviewed-on: https://webrtc-review.googlesource.com/81189 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23528} [modify] https://crrev.com/34c9f1252af71da694bf76f9d1fc21ffc9bd343b/modules/audio_processing/aec3/cascaded_biquad_filter.cc [modify] https://crrev.com/34c9f1252af71da694bf76f9d1fc21ffc9bd343b/modules/audio_processing/aec3/cascaded_biquad_filter.h [modify] https://crrev.com/34c9f1252af71da694bf76f9d1fc21ffc9bd343b/modules/audio_processing/aec3/cascaded_biquad_filter_unittest.cc [modify] https://crrev.com/34c9f1252af71da694bf76f9d1fc21ffc9bd343b/modules/audio_processing/aec3/decimator.cc
,
Jun 7 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/f469b63d44bc8ccbf18873a153f277e507731249 commit f469b63d44bc8ccbf18873a153f277e507731249 Author: Gustaf Ullberg <gustaf@webrtc.org> Date: Thu Jun 07 12:21:36 2018 AEC3: Improved anti-aliasing filter for DSF 4 This change contains a new anti-aliasing filter for the delay estimator for down-sampling factor 4. The new (elliptic) filter has a much wider main lobe allowing for faster convergence. Bug: webrtc:9288 , chromium:846615 Change-Id: Id109974a59fe6f48c5e0ccc4f4e06c0d94c8bd03 Reviewed-on: https://webrtc-review.googlesource.com/81680 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23534} [modify] https://crrev.com/f469b63d44bc8ccbf18873a153f277e507731249/modules/audio_processing/aec3/decimator.cc [modify] https://crrev.com/f469b63d44bc8ccbf18873a153f277e507731249/modules/audio_processing/aec3/echo_path_delay_estimator_unittest.cc
,
Jun 7 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/ed51a6e6655a1d7f76b5b855d6589464ae95d830 commit ed51a6e6655a1d7f76b5b855d6589464ae95d830 Author: Gustaf Ullberg <gustaf@webrtc.org> Date: Thu Jun 07 18:13:01 2018 AEC3: Avoid static initializers Bug: webrtc:9288 , chromium:846615 Change-Id: I9df7f07454bdba45181972b7ed3dff77c370abb3 Reviewed-on: https://webrtc-review.googlesource.com/81750 Reviewed-by: Christian Fremerey <chfremer@webrtc.org> Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23538} [modify] https://crrev.com/ed51a6e6655a1d7f76b5b855d6589464ae95d830/modules/audio_processing/aec3/decimator.cc
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3596e65961370cfb3618ee256d1b90dd636d09c1 commit 3596e65961370cfb3618ee256d1b90dd636d09c1 Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Jun 08 00:02:49 2018 Roll src/third_party/webrtc 81327d5..ed51a6e (12 commits) https://webrtc.googlesource.com/src.git/+log/81327d5..ed51a6e git log 81327d5..ed51a6e --date=short --no-merges --format='%ad %ae %s' 2018-06-07 gustaf@webrtc.org AEC3: Avoid static initializers 2018-06-07 peah@webrtc.org AEC3: Delay stabilization after a delay change 2018-06-07 peah@webrtc.org AEC3: Added filter preprocessing to avoid low frequency artefacts 2018-06-07 magjed@webrtc.org Android: Throw exception in CallSessionFileRotatingLogSink if dir is null 2018-06-07 gustaf@webrtc.org AEC3: Improved anti-aliasing filter for DSF 4 2018-06-07 mbonadei@webrtc.org Removing warning suppression flags from test/. 2018-06-07 mbonadei@webrtc.org Re-enabling SanitizerTest.MsanUninitialized. 2018-06-07 srte@webrtc.org Fixing issue where pacer budget increased in congestion. 2018-06-07 asapersson@webrtc.org Remove unused methods in VCMDecoderDataBase. 2018-06-07 nisse@webrtc.org Delete unused stats for preferred_bitrate. 2018-06-07 gustaf@webrtc.org AEC3: Move decimator filters to the new notation 2018-06-07 nisse@webrtc.org Delete RTP-specific values from the VideoCodecType enum. Created with: gclient setdep -r src/third_party/webrtc@ed51a6e The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= chromium:846615 , chromium:850451 , chromium:848231 ,chromium:b/106732994,chromium:846615,chromium:none,chromium:846615,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5fa6c8ebdf457e84a74bc440a044f50ba4915e21 Reviewed-on: https://chromium-review.googlesource.com/1091287 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565471} [modify] https://crrev.com/3596e65961370cfb3618ee256d1b90dd636d09c1/DEPS
,
Jun 18 2018
,
Jun 18 2018
We kindly ask for merge approval to M68. This code increases the robustness of AEC3 in noisy environments and has been part of Canary since 2018-06-08. AEC3 can be deactivated remotely if something goes wrong. The CLs to merge: https://webrtc-review.googlesource.com/78703 https://webrtc-review.googlesource.com/80060 https://webrtc-review.googlesource.com/80443 https://webrtc-review.googlesource.com/80965 https://webrtc-review.googlesource.com/81189 https://webrtc-review.googlesource.com/81680 https://webrtc-review.googlesource.com/81750
,
Jun 18 2018
This bug requires manual review: DEPS changes referenced in bugdroid comments. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 18 2018
Can you please explain why this is critical for M68? These are fairly large CLs.
,
Jun 19 2018
The change fixes serious issues found during beta testing, and we find it critical for M68. I would like to stress that AEC3 can be fully disabled from the server side if something goes wrong, which minimizes the risk of this change.
,
Jun 19 2018
Per #14,17, large CLs, but tested for over 10 days in canary, and can be turned off server side. Approving merge to M68.
,
Jun 20 2018
,
Jun 25 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 26 2018
The changes have been merged to M68. abdulsyed@, can you help me setting the correct labels? I am not completely sure what the correct prodecure is. Replacing Merge-Approved-68 with something else?
,
Jun 28 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 29 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, May 25 2018