New issue
Advanced search Search tips

Issue 846614 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: May 2018
Cc:
mard...@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-06-06
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Remove close all from TabGrid popup menu

Project Member Reported by gambard@chromium.org, May 25 2018 
Per discussion, the TabGrid popup should be the same in incognito and non-incognito.
The Close All Incognito Tabs action should be removed.
Project Member

Comment 1 by bugdroid1@chromium.org, May 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64733616d2a4d8f62b8759d47ef84627b3e2d038

commit 64733616d2a4d8f62b8759d47ef84627b3e2d038
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri May 25 13:49:55 2018

Remove Close All Incognito Tab from TabGrid popup

This CL removes the Close All Incognito Tabs action from the TabGrid
popup menu in incognito, making it the same as the non-incognito.

Bug:  846614 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib19301aa9582c7bb2eb94512c50082c40c6dc510
Reviewed-on: https://chromium-review.googlesource.com/1073150
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561851}
[modify] https://crrev.com/64733616d2a4d8f62b8759d47ef84627b3e2d038/ios/chrome/browser/ui/popup_menu/cells/popup_menu_item.h
[modify] https://crrev.com/64733616d2a4d8f62b8759d47ef84627b3e2d038/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm
[modify] https://crrev.com/64733616d2a4d8f62b8759d47ef84627b3e2d038/ios/chrome/browser/ui/popup_menu/popup_menu_mediator_unittest.mm
[modify] https://crrev.com/64733616d2a4d8f62b8759d47ef84627b3e2d038/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm

Comment 2 by gambard@chromium.org, May 25 2018

NextAction: 2018-06-06
Status: Fixed (was: Assigned)

Comment 3 by monor...@bugs.chromium.org, Jun 6 2018 

The NextAction date has arrived: 2018-06-06
►

Sign in to add a comment